Re: [Xen-devel] [Wg-test-framework] osstest outage over the weekend

2015-04-21 Thread Don Koch
On Mon, 20 Apr 2015 06:40:18 -0400 Ian Jackson wrote: > osstest service user writes ("[qemu-mainline test] 50651: trouble: > blocked/broken"): > > flight 50651 qemu-mainline real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/50651/ > > > > Failures and problems with tests :-( > >

Re: [Xen-devel] [PATCH] xen/Coverity: Audit of MISSING_BREAK defects

2015-02-13 Thread Don Koch
On Fri, 13 Feb 2015 11:01:27 + Andrew Cooper wrote: > On 12/02/15 21:06, Don Koch wrote: > > On Thu, 12 Feb 2015 20:08:46 + > > Andrew Cooper wrote: > > [...] > > I'm surprised that coverity didn't complain about the fallthrough in > > the ne

Re: [Xen-devel] [PATCH] xen/Coverity: Audit of MISSING_BREAK defects

2015-02-12 Thread Don Koch
s1++; > break; > diff --git a/xen/common/schedule.c b/xen/common/schedule.c > index b73177f..ef79847 100644 > --- a/xen/common/schedule.c > +++ b/xen/common/schedule.c > @@ -1179,6 +1179,7 @@ static void schedule(void) > { > case TASKLET_enqueued: > set_bit(_TASKLET_scheduled, tasklet_work); > +/* fallthrough */ > case TASKLET_enqueued|TASKLET_scheduled: > tasklet_work_scheduled = 1; > break; I'm surprised that coverity didn't complain about the fallthrough in the next case: case TASKLET_scheduled: clear_bit(_TASKLET_scheduled, tasklet_work); case 0: /*tasklet_work_scheduled = 0;*/ break; Or is my code out of date? With or without that change, Reviewed-by: Don Koch > -- > 1.7.10.4 ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] tools/Coverity: Audit of MISSING_BREAK defects

2015-02-12 Thread Don Koch
case KEY_F(4): > exit(EXIT_SUCCESS); > } > diff --git a/tools/xenstat/xentop/xentop.c b/tools/xenstat/xentop/xentop.c > index 3062cb5..23b57f1 100644 > --- a/tools/xenstat/xentop/xentop.c > +++ b/tools/xenstat/xentop/xentop.c > @@ -4

Re: [Xen-devel] [PATCH SECURITY-POLICY 4/9] Use a public mailing list for predisclosure membership applications.

2015-01-19 Thread Don Koch
On Mon, 19 Jan 2015 13:19:03 + Ian Campbell wrote: > On Mon, 2015-01-19 at 13:10 +, Ian Jackson wrote: > > Ian Campbell writes ("Re: [Xen-devel] [PATCH SECURITY-POLICY 4/9] Use a > > public mailing list for predisclosure membership applications."): > > > On Fri, 2015-01-16 at 19:52 +

Re: [Xen-devel] [PATCH] libxl: Set path to console on domain startup.

2014-12-05 Thread Don Koch
Not really familiar with libvirt, but... On Fri, 5 Dec 2014 16:30:06 + Anthony PERARD wrote: > The path to the pty of a Xen PV console is set only in > virDomainOpenConsole. But this is done too late. A call to > virDomainGetXMLDesc done before OpenConsole will not have the path to > the pty

Re: [Xen-devel] [PATCH] Ignore non-zero data in unused xsave area.

2014-11-20 Thread Don Koch
This change can be ignored. Details below. On Tue, 18 Nov 2014 10:26:31 -0500 Don Koch wrote: > If we restore an xsave area from an older xen that has a larger > size than the xcr0 bit call for, it is possible to have non-zero > data in the unused area if an xsave has ever been done

Re: [Xen-devel] [PATCH] Ignore non-zero data in unused xsave area.

2014-11-18 Thread Don Koch
On Tue, 18 Nov 2014 16:35:42 + Jan Beulich wrote: > >>> On 18.11.14 at 16:26, wrote: > > If we restore an xsave area from an older xen that has a larger > > size than the xcr0 bit call for, it is possible to have non-zero > > data in the unused area if an xsave has ever been done that used >

[Xen-devel] [PATCH] Ignore non-zero data in unused xsave area.

2014-11-18 Thread Don Koch
itial allocation, that data is still there. Since we are told that said area was not written to during the save or migration, there is no need to restore it. Signed-off-by: Don Koch --- Turns out the assertion that the unused xsave area is zero is wrong. Unfortunately, that leaves the following a