Re: [Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

2016-04-22 Thread Konrad Rzeszutek Wilk
> Overall I think that all of the cited examples are such which already > don't really lend themselves to live patching. Hence I think we're > going to be fine without these extra two pieces for the initial round, /me nods. > taking into consideration just those cases where live patching is > reas

Re: [Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

2016-04-22 Thread Jan Beulich
>>> On 11.04.16 at 10:23, wrote: > On 04/08/2016 06:39 PM, Jan Beulich wrote: > On 08.04.16 at 17:57, wrote: >>> I've marked the following XSAs as potentially requiring hook functions >>> or shadow variables: >>> >>> XSA-36 Again an example that I don't think can be live patched: The ACPI ta

Re: [Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

2016-04-22 Thread Jan Beulich
>>> On 11.04.16 at 10:23, wrote: > Some examples: > XSA-80: In addition to patching the code, a hook function is needed to > set iommu_dont_flush_iotlb back to 0. I don't think this is an issue that can be reasonably life patched: Doing so would likely lead to the false impression that everythin

Re: [Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

2016-04-11 Thread Ross Lagerwall
On 04/08/2016 06:39 PM, Jan Beulich wrote: On 08.04.16 at 17:57, wrote: On 04/07/2016 02:15 AM, Jan Beulich wrote: Martin Pohlack 04/06/16 8:42 AM >>> On 06.04.2016 04:42, Konrad Rzeszutek Wilk wrote: The normal use-case is to modify structures values where we have to be delicate about it a

Re: [Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

2016-04-08 Thread Jan Beulich
>>> On 08.04.16 at 17:57, wrote: > On 04/07/2016 02:15 AM, Jan Beulich wrote: > Martin Pohlack 04/06/16 8:42 AM >>> >>> On 06.04.2016 04:42, Konrad Rzeszutek Wilk wrote: The normal use-case is to modify structures values where we have to be delicate about it and can't just replace t

Re: [Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

2016-04-08 Thread Ross Lagerwall
On 04/07/2016 02:15 AM, Jan Beulich wrote: Martin Pohlack 04/06/16 8:42 AM >>> On 06.04.2016 04:42, Konrad Rzeszutek Wilk wrote: The normal use-case is to modify structures values where we have to be delicate about it and can't just replace the value. As in we may have to recompute the value.

Re: [Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

2016-04-06 Thread Jan Beulich
>>> Martin Pohlack 04/06/16 8:42 AM >>> >On 06.04.2016 04:42, Konrad Rzeszutek Wilk wrote: >> The normal use-case is to modify structures values where we have to >> be delicate about it and can't just replace the value. As in we >> may have to recompute the value. > >Agree on the default use (e.g.

Re: [Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

2016-04-06 Thread Jan Beulich
>>> Konrad Rzeszutek Wilk 04/06/16 4:44 AM >>> >On Fri, Apr 01, 2016 at 09:50:31AM -0600, Jan Beulich wrote: >> >>> On 24.03.16 at 21:00, wrote: >> > From: Ross Lagerwall >> > >> > Add hook functions which run during patch apply and patch revert. >> > Hook functions are used by xsplice payloads

Re: [Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

2016-04-05 Thread Martin Pohlack
On 06.04.2016 04:42, Konrad Rzeszutek Wilk wrote: > On Fri, Apr 01, 2016 at 09:50:31AM -0600, Jan Beulich wrote: > On 24.03.16 at 21:00, wrote: >>> From: Ross Lagerwall >>> >>> Add hook functions which run during patch apply and patch revert. >>> Hook functions are used by xsplice payloads to

Re: [Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

2016-04-05 Thread Konrad Rzeszutek Wilk
On Fri, Apr 01, 2016 at 09:50:31AM -0600, Jan Beulich wrote: > >>> On 24.03.16 at 21:00, wrote: > > From: Ross Lagerwall > > > > Add hook functions which run during patch apply and patch revert. > > Hook functions are used by xsplice payloads to manipulate data structures > > during patching, et

Re: [Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

2016-04-01 Thread Jan Beulich
>>> On 24.03.16 at 21:00, wrote: > From: Ross Lagerwall > > Add hook functions which run during patch apply and patch revert. > Hook functions are used by xsplice payloads to manipulate data structures > during patching, etc. Since the added documentation here didn't enlighten me, I've gone bac

[Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

2016-03-24 Thread Konrad Rzeszutek Wilk
From: Ross Lagerwall Add hook functions which run during patch apply and patch revert. Hook functions are used by xsplice payloads to manipulate data structures during patching, etc. Also add macros to be used by payloads for excluding functions or sections from being included in a patch. Furth