Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-19 Thread Juergen Gross
On 03/19/2015 02:38 PM, Juergen Gross wrote: On 03/19/2015 12:34 PM, Daniel Kiper wrote: On Thu, Mar 19, 2015 at 10:55:37AM +0100, Juergen Gross wrote: On 03/18/2015 04:14 PM, Daniel Kiper wrote: [...] I have checked new p2m code and I think that this is reasonable solution too. Do I need

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-19 Thread Juergen Gross
On 03/19/2015 12:34 PM, Daniel Kiper wrote: On Thu, Mar 19, 2015 at 10:55:37AM +0100, Juergen Gross wrote: On 03/18/2015 04:14 PM, Daniel Kiper wrote: [...] I have checked new p2m code and I think that this is reasonable solution too. Do I need any patches for xl to be able to test this? I

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-19 Thread Daniel Kiper
On Thu, Mar 19, 2015 at 10:55:37AM +0100, Juergen Gross wrote: > On 03/18/2015 04:14 PM, Daniel Kiper wrote: [...] > >I have checked new p2m code and I think that this is reasonable solution too. > > Do I need any patches for xl to be able to test this? I did: > > xl mem-max 2 4096 > xl mem-set 2

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-19 Thread Juergen Gross
On 03/18/2015 04:14 PM, Daniel Kiper wrote: On Wed, Mar 18, 2015 at 01:59:58PM +, David Vrabel wrote: On 18/03/15 13:57, Juergen Gross wrote: On 03/18/2015 11:36 AM, David Vrabel wrote: On 16/03/15 10:31, Juergen Gross wrote: On 03/16/2015 11:03 AM, Daniel Kiper wrote: On Mon, Mar 16, 20

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-18 Thread Daniel Kiper
On Wed, Mar 18, 2015 at 01:59:58PM +, David Vrabel wrote: > On 18/03/15 13:57, Juergen Gross wrote: > > On 03/18/2015 11:36 AM, David Vrabel wrote: > >> On 16/03/15 10:31, Juergen Gross wrote: > >>> On 03/16/2015 11:03 AM, Daniel Kiper wrote: > On Mon, Mar 16, 2015 at 06:35:04AM +0100, Jue

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-18 Thread David Vrabel
On 18/03/15 13:57, Juergen Gross wrote: > On 03/18/2015 11:36 AM, David Vrabel wrote: >> On 16/03/15 10:31, Juergen Gross wrote: >>> On 03/16/2015 11:03 AM, Daniel Kiper wrote: On Mon, Mar 16, 2015 at 06:35:04AM +0100, Juergen Gross wrote: > On 03/11/2015 04:40 PM, Boris Ostrovsky wrote: >

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-18 Thread Juergen Gross
On 03/18/2015 11:36 AM, David Vrabel wrote: On 16/03/15 10:31, Juergen Gross wrote: On 03/16/2015 11:03 AM, Daniel Kiper wrote: On Mon, Mar 16, 2015 at 06:35:04AM +0100, Juergen Gross wrote: On 03/11/2015 04:40 PM, Boris Ostrovsky wrote: On 03/11/2015 10:42 AM, David Vrabel wrote: On 10/03/1

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-18 Thread David Vrabel
On 16/03/15 10:31, Juergen Gross wrote: > On 03/16/2015 11:03 AM, Daniel Kiper wrote: >> On Mon, Mar 16, 2015 at 06:35:04AM +0100, Juergen Gross wrote: >>> On 03/11/2015 04:40 PM, Boris Ostrovsky wrote: On 03/11/2015 10:42 AM, David Vrabel wrote: > On 10/03/15 13:35, Boris Ostrovsky wrote:

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-17 Thread Juergen Gross
On 03/17/2015 01:40 PM, Daniel Kiper wrote: On Mon, Mar 16, 2015 at 11:31:49AM +0100, Juergen Gross wrote: On 03/16/2015 11:03 AM, Daniel Kiper wrote: On Mon, Mar 16, 2015 at 06:35:04AM +0100, Juergen Gross wrote: On 03/11/2015 04:40 PM, Boris Ostrovsky wrote: On 03/11/2015 10:42 AM, David Vr

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-17 Thread Daniel Kiper
On Mon, Mar 16, 2015 at 11:31:49AM +0100, Juergen Gross wrote: > On 03/16/2015 11:03 AM, Daniel Kiper wrote: > >On Mon, Mar 16, 2015 at 06:35:04AM +0100, Juergen Gross wrote: > >>On 03/11/2015 04:40 PM, Boris Ostrovsky wrote: > >>>On 03/11/2015 10:42 AM, David Vrabel wrote: > On 10/03/15 13:35,

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-16 Thread Juergen Gross
On 03/16/2015 11:03 AM, Daniel Kiper wrote: On Mon, Mar 16, 2015 at 06:35:04AM +0100, Juergen Gross wrote: On 03/11/2015 04:40 PM, Boris Ostrovsky wrote: On 03/11/2015 10:42 AM, David Vrabel wrote: On 10/03/15 13:35, Boris Ostrovsky wrote: On 03/10/2015 07:40 AM, David Vrabel wrote: On 09/03

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-16 Thread Daniel Kiper
On Mon, Mar 16, 2015 at 06:35:04AM +0100, Juergen Gross wrote: > On 03/11/2015 04:40 PM, Boris Ostrovsky wrote: > >On 03/11/2015 10:42 AM, David Vrabel wrote: > >>On 10/03/15 13:35, Boris Ostrovsky wrote: > >>>On 03/10/2015 07:40 AM, David Vrabel wrote: > On 09/03/15 14:10, David Vrabel wrote:

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-15 Thread Juergen Gross
On 03/11/2015 04:40 PM, Boris Ostrovsky wrote: On 03/11/2015 10:42 AM, David Vrabel wrote: On 10/03/15 13:35, Boris Ostrovsky wrote: On 03/10/2015 07:40 AM, David Vrabel wrote: On 09/03/15 14:10, David Vrabel wrote: Memory hotplug doesn't work with PV guests because: a) The p2m cannot be

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-11 Thread Boris Ostrovsky
On 03/11/2015 10:42 AM, David Vrabel wrote: On 10/03/15 13:35, Boris Ostrovsky wrote: On 03/10/2015 07:40 AM, David Vrabel wrote: On 09/03/15 14:10, David Vrabel wrote: Memory hotplug doesn't work with PV guests because: a) The p2m cannot be expanded to cover the new sections. Broken by

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-11 Thread David Vrabel
On 10/03/15 13:35, Boris Ostrovsky wrote: > On 03/10/2015 07:40 AM, David Vrabel wrote: >> On 09/03/15 14:10, David Vrabel wrote: >>> Memory hotplug doesn't work with PV guests because: >>> >>>a) The p2m cannot be expanded to cover the new sections. >> Broken by 054954eb051f35e74b75a566a96fe756

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-10 Thread Boris Ostrovsky
On 03/10/2015 07:40 AM, David Vrabel wrote: On 09/03/15 14:10, David Vrabel wrote: Memory hotplug doesn't work with PV guests because: a) The p2m cannot be expanded to cover the new sections. Broken by 054954eb051f35e74b75a566a96fe756015352c8 (xen: switch to linear virtual mapped sparse p2m

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-10 Thread David Vrabel
On 09/03/15 14:10, David Vrabel wrote: > Memory hotplug doesn't work with PV guests because: > > a) The p2m cannot be expanded to cover the new sections. Broken by 054954eb051f35e74b75a566a96fe756015352c8 (xen: switch to linear virtual mapped sparse p2m list). This one would be non-trivial to

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-09 Thread Daniel Kiper
On Mon, Mar 09, 2015 at 03:31:30PM +, David Vrabel wrote: > On 09/03/15 15:25, Boris Ostrovsky wrote: > > On 03/09/2015 11:13 AM, David Vrabel wrote: > >> On 09/03/15 15:09, Boris Ostrovsky wrote: > >>> On 03/09/2015 10:10 AM, David Vrabel wrote: > Memory hotplug doesn't work with PV guest

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-09 Thread Daniel Kiper
On Mon, Mar 09, 2015 at 11:25:07AM -0400, Boris Ostrovsky wrote: > On 03/09/2015 11:13 AM, David Vrabel wrote: > >On 09/03/15 15:09, Boris Ostrovsky wrote: > >>On 03/09/2015 10:10 AM, David Vrabel wrote: > >>>Memory hotplug doesn't work with PV guests because: > >>> > >>>a) The p2m cannot be ex

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-09 Thread Boris Ostrovsky
On 03/09/2015 11:31 AM, David Vrabel wrote: On 09/03/15 15:25, Boris Ostrovsky wrote: On 03/09/2015 11:13 AM, David Vrabel wrote: On 09/03/15 15:09, Boris Ostrovsky wrote: On 03/09/2015 10:10 AM, David Vrabel wrote: Memory hotplug doesn't work with PV guests because: a) The p2m cannot b

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-09 Thread Konrad Rzeszutek Wilk
On Mon, Mar 09, 2015 at 03:31:30PM +, David Vrabel wrote: > On 09/03/15 15:25, Boris Ostrovsky wrote: > > On 03/09/2015 11:13 AM, David Vrabel wrote: > >> On 09/03/15 15:09, Boris Ostrovsky wrote: > >>> On 03/09/2015 10:10 AM, David Vrabel wrote: > Memory hotplug doesn't work with PV guest

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-09 Thread David Vrabel
On 09/03/15 15:25, Boris Ostrovsky wrote: > On 03/09/2015 11:13 AM, David Vrabel wrote: >> On 09/03/15 15:09, Boris Ostrovsky wrote: >>> On 03/09/2015 10:10 AM, David Vrabel wrote: Memory hotplug doesn't work with PV guests because: a) The p2m cannot be expanded to cover the new

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-09 Thread Boris Ostrovsky
On 03/09/2015 11:13 AM, David Vrabel wrote: On 09/03/15 15:09, Boris Ostrovsky wrote: On 03/09/2015 10:10 AM, David Vrabel wrote: Memory hotplug doesn't work with PV guests because: a) The p2m cannot be expanded to cover the new sections. b) add_memory() builds page tables for the new

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-09 Thread David Vrabel
On 09/03/15 15:09, Boris Ostrovsky wrote: > On 03/09/2015 10:10 AM, David Vrabel wrote: >> Memory hotplug doesn't work with PV guests because: >> >>a) The p2m cannot be expanded to cover the new sections. >> >>b) add_memory() builds page tables for the new sections which means >> the

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-09 Thread Boris Ostrovsky
On 03/09/2015 10:10 AM, David Vrabel wrote: Memory hotplug doesn't work with PV guests because: a) The p2m cannot be expanded to cover the new sections. b) add_memory() builds page tables for the new sections which means the new pages must have valid p2m entries (or a BUG occurs).

[Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-09 Thread David Vrabel
Memory hotplug doesn't work with PV guests because: a) The p2m cannot be expanded to cover the new sections. b) add_memory() builds page tables for the new sections which means the new pages must have valid p2m entries (or a BUG occurs). So, in PV guests, clamp the target to the current