Re: [Xen-devel] [PATCH v3 3/4] docs: add pvscsi.txt

2015-03-06 Thread Olaf Hering
On Fri, Mar 06, Wei Liu wrote: > On Fri, Mar 06, 2015 at 10:45:55AM +0100, Olaf Hering wrote: > > +== TODO === > > + > > +How to do live migration? > > + - pdev will likely be evaluated again on the target host if it came from > > + domU.cfg. But what about pd

Re: [Xen-devel] [PATCH v3 2/4] docs: add vscsi to xenstore-paths.markdown

2015-03-06 Thread Olaf Hering
On Fri, Mar 06, Wei Liu wrote: > On Fri, Mar 06, 2015 at 10:45:54AM +0100, Olaf Hering wrote: > [...] > > ~/backend/console/$DOMID/$DEVID/* [] > > > > A PV console backend. Described in [console.txt](console.txt) > > @@ -403,6 +412,7 @@ ifb device used by

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-06 Thread Olaf Hering
spot something that is better done with flex? > On Fri, Mar 06, 2015 at 10:45:56AM +0100, Olaf Hering wrote: > > Port pvscsi support from xend to libxl. See pvscsi.txt for details. > > Outstanding work is listed in the TODO section. > There is no TODO section in this patch. :-)

[Xen-devel] libxl__device_nextid and holes

2015-03-09 Thread Olaf Hering
I wonder if libxl__device_nextid is robust enough to handle holes. If there are 3 devices (0,1,2) of type X, and device #0 or #1 is removed with "X-detach", wouldn't the code return nextid==2? The result would be that the caller will write to the wrong path. I have not veified this theory in pract

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-09 Thread Olaf Hering
On Fri, Mar 06, Wei Liu wrote: > > +void libxl__device_vscsi_add(libxl__egc *egc, uint32_t domid, > > + libxl_device_vscsi *vscsi, > > + libxl__ao_device *aodev) > You need to update this domain's JSON configuration. Cf. > libxl__device_vtpm_

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-10 Thread Olaf Hering
On Thu, Sep 10, George Dunlap wrote: > On Fri, Dec 19, 2014 at 11:25 AM, Olaf Hering wrote: > > Using SELinux mount options per default breaks several systems. > > Either the context= mount option is not known at all to the kernel, > > as reported for ArchLinux. Or the de

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-09-10 Thread Olaf Hering
On Thu, Sep 10, Ian Jackson wrote: > Wei Liu writes ("Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to > start xenstored"): > > On Thu, Sep 10, 2015 at 03:19:35PM +0100, George Dunlap wrote: > > > ExecStart=/usr/bin/env $XENSTORED --no-fork $XENSTORED_ARGS > > > > And the difference bet

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-14 Thread Olaf Hering
On Mon, Sep 14, George Dunlap wrote: > Well if you "know nothing about SELinux", and you don't use it, and > don't have any test systems that use it, then why did you assert > "The proper place to specify [an SELinux mount context] is /etc/fstab"? > This patchset was accepted because you represen

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-15 Thread Olaf Hering
On Tue, Sep 15, George Dunlap wrote: > It's very reasonable for you to expect it to be fixed on non-SELinux > systems. But what you did is fix it for non-SELinux systems by simply > breaking it on SELinux systems -- that's not at all reasonable. Konrad did some testing at that time and said 4.5

[Xen-devel] xen-4.6 compile error

2015-09-30 Thread Olaf Hering
Current xen-4.6-staging fails to compile on openSUSE 11.4 and SLES11 [ 1227s] gcc -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .libxl_psr.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fmessage

Re: [Xen-devel] xen-4.6 compile error

2015-09-30 Thread Olaf Hering
On Wed, Sep 30, Wei Liu wrote: > On Wed, Sep 30, 2015 at 03:46:35PM +0200, Olaf Hering wrote: > > [ 1227s] libxl_psr.c:342: error: declaration of 'socket' shadows a global > > declaration > I will provide a patch to fix it. Thanks. Staging is broken as well

Re: [Xen-devel] [PATCH for-4.6] libxl: don't shadow global "socket" in psr code

2015-09-30 Thread Olaf Hering
On Wed, Sep 30, Wei Liu wrote: > Change "socket" to "socketid" to fix the problem. Tested-by: Olaf Hering Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] tools/hotplug: update systemd dependency to use service instead of socket

2014-12-03 Thread Olaf Hering
On Wed, Dec 03, M A Young wrote: > On Wed, 3 Dec 2014, Konrad Rzeszutek Wilk wrote: > >Options=mode=755,context="$XENSTORED_MOUNT_CTX" > > Yes, that was on my probable bug list, as context="none" isn't a valid mount > option (on Fedora at least), presumably because context has to be followed > by

Re: [Xen-devel] [PATCH v4 0/9] toolstack-based approach to pvhvm guest kexec

2014-12-04 Thread Olaf Hering
On Wed, Dec 03, Vitaly Kuznetsov wrote: > Original description: > > When a PVHVM linux guest performs kexec there are lots of things which > require taking care of: > - shared info, vcpu_info > - grants > - event channels > - ... > Instead of taking care of all these things we can rebuild the dom

Re: [Xen-devel] [PATCH] tools/hotplug: update systemd dependency to use service instead of socket

2014-12-04 Thread Olaf Hering
On Thu, Dec 04, Konrad Rzeszutek Wilk wrote: > On Thu, Dec 04, 2014 at 08:47:56AM +0100, Olaf Hering wrote: > > Is that something the sysadmin has to adjust, or should the xen source > > provide proper values? > It would be rather cumbersome if the sysadmin had to adjust it. The

Re: [Xen-devel] [PATCH] tools/hotplug: update systemd dependency to use service instead of socket

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Olaf Hering wrote: > On Thu, Dec 04, Konrad Rzeszutek Wilk wrote: > > > On Thu, Dec 04, 2014 at 08:47:56AM +0100, Olaf Hering wrote: > > > Is that something the sysadmin has to adjust, or should the xen source > > > provide proper values? > >

Re: [Xen-devel] [PATCH] tools/hotplug: update systemd dependency to use service instead of socket

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Olaf Hering wrote: > So looking again at > tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in it seems that it > happens to work for me because XENSTORED_MOUNT_CTX is set within that > file. So if something happens to need a different value for > XENSTORED_MOUN

Re: [Xen-devel] [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability

2014-12-05 Thread Olaf Hering
On Tue, Dec 02, Wei Liu wrote: > AC_CHECK_LIB fails on Debian Jessie since the ld flag it generates is > incorrect, even in the event systemd library is available. Use > PKG_CHECK_MODULES instead. > > Tested on Debian Jessie and Arch Linux. I just tested this and got this failure. The reason is

Re: [Xen-devel] [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Ian Campbell wrote: > On Fri, 2014-12-05 at 10:51 +0100, Olaf Hering wrote: > > On Tue, Dec 02, Wei Liu wrote: > > > > > AC_CHECK_LIB fails on Debian Jessie since the ld flag it generates is > > > incorrect, even in the event s

[Xen-devel] [PATCH] tools/xenstore: fix link error with libsystemd

2014-12-05 Thread Olaf Hering
Linking fails with undefined reference to the used systemd functions. Move LDFLAGS after the object files to fix the failure. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/xenstore/Makefile | 10 +- 1 file changed, 5

[Xen-devel] [PATCH 0/5] tools/hotplug: systemd changes for 4.5

2014-12-05 Thread Olaf Hering
service files. They reference non-existant sysconfig files. We should fix this before the release of 4.5 to avoid stale sysconfig files if someone wants to adjust the values. I have tested this series on openSUSE 13.1. Please review and apply for 4.5. Olaf Olaf Hering (5): tools/hotplu

[Xen-devel] [PATCH 1/5] tools/hotplug: move XENSTORED_MOUNT_CTX to sysconfig.xencommons

2014-12-05 Thread Olaf Hering
onfig file, just reuse the existing /etc/sysconfig/xencommons file. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 7 +++ tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in

[Xen-devel] [PATCH 2/5] tools/hotplug: use existing sysconfig file for xenconsoled

2014-12-05 Thread Olaf Hering
D_ARGS and XENCONSOLED_LOG_DIR - Adjust the runlevel script to handle XENCONSOLED_TRACE properly. If an old sysconfig file exist the XENCONSOLED_TRACE will remain empty. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Li

[Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-05 Thread Olaf Hering
The sysv runlevel script handles the boolean variable XENSTORED_TRACE from sysconfig.xencommons to enable tracing. Recognize this also to the systemd service file. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Linux/systemd

[Xen-devel] [PATCH 3/5] tools/hotplug: remove EnvironmentFile from xen-qemu-dom0-disk-backend.service

2014-12-05 Thread Olaf Hering
The references Environment file does not exist, and the service file does not make use of variables anyway. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service.in | 1 - 1 file

[Xen-devel] [PATCH 4/5] tools/hotplug: remove XENSTORED_ROOTDIR from service file

2014-12-05 Thread Olaf Hering
There is no need to export XENSTORED_ROOTDIR. This variable can be enabled in sysconfig/xencommons. If the variable is unset xenstored will automatically use @XEN_LIB_STORED@. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug

Re: [Xen-devel] [PATCH 1/5] tools/hotplug: move XENSTORED_MOUNT_CTX to sysconfig.xencommons

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Ian Jackson wrote: > Olaf Hering writes ("[PATCH 1/5] tools/hotplug: move XENSTORED_MOUNT_CTX to > sysconfig.xencommons"): > > On a non-SELinux system the mount option "context=none" works fine. But > > with SELinux enabled a proper va

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Ian Jackson wrote: > I think the only way to make this work properly is to factor the > necessary parts out of init.d/xencommons into a new script which can > be used by both xencommons and systemd. I'm not sure such a patch > would be appropriate for 4.5 at this stage. Yes, a he

Re: [Xen-devel] [PATCH 1/5] tools/hotplug: move XENSTORED_MOUNT_CTX to sysconfig.xencommons

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Olaf Hering wrote: > On Fri, Dec 05, Ian Jackson wrote: > > And won't this break existing systems which have an > > /etc/{default,sysconfig}/xenstored ? > Which systems would that be? That file is new in 4.5. ... Not the file itself but the usage of a to-be

Re: [Xen-devel] [PATCH 1/5] tools/hotplug: move XENSTORED_MOUNT_CTX to sysconfig.xencommons

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Ian Jackson wrote: > Olaf Hering writes ("Re: [PATCH 1/5] tools/hotplug: move XENSTORED_MOUNT_CTX > to sysconfig.xencommons"): > > On Fri, Dec 05, Ian Jackson wrote: > > > This patch looks like just the hook. It seems to be missing the part > &g

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Ian Jackson wrote: > Can systemd not launch these daemons by running the existing > xencommons et al init scripts ? Obviously that won't give you all of > systemd's shiny features but IMO it ought to work. I think the point was to let systemd pass the file descriptors. Thats why

Re: [Xen-devel] [PATCH 1/5] tools/hotplug: move XENSTORED_MOUNT_CTX to sysconfig.xencommons

2014-12-05 Thread Olaf Hering
On Fri, Dec 05, Anthony PERARD wrote: > On Fri, Dec 05, 2014 at 01:05:48PM +0100, Olaf Hering wrote: > > On a non-SELinux system the mount option "context=none" works fine. > > That's not true. I've tested 'context=none' on ArchLinux which have n

Re: [Xen-devel] [Xen-users] 4.5 git: regression in xen systemd shutdown hangs the OS

2014-12-05 Thread Olaf Hering
On Tue, Dec 02, Olaf Hering wrote: > On Tue, Dec 02, Ian Campbell wrote: > > > On Mon, 2014-12-01 at 23:41 +, Mark Pryor wrote: > > > list, > > > > Thanks. If you've identified a buggy changeset then it is fine to post > > to the devel lists. I&

Re: [Xen-devel] [PATCH V5] Update pvSCSI protocol description / libxl

2014-12-07 Thread Olaf Hering
On Sun, Dec 07, Pasi Kärkkäinen wrote: > Hello, > > Juergen/Olaf: Now that Xen PVSCSI drivers are in upstream Linux 3.18 kernel > I was wondering if you guys also have plans to work on adding xl / libxl > support for PVSCSI ? Its still on the TODO list. Will most likely make into 4.6. Olaf

Re: [Xen-devel] [PATCH] tools/hotplug: update systemd dependency to use service instead of socket

2014-12-08 Thread Olaf Hering
On Fri, Dec 05, Konrad Rzeszutek Wilk wrote: > OK. That might be complicated in that the context could change between > bootup and run-time (I think that is what Michael told me). The proper place to handle mount options is /etc/fstab. My version of systemd is kind enough to use the values frm fs

[Xen-devel] [PATCH 3/4] tools/hotplug: remove EnvironmentFile from xen-qemu-dom0-disk-backend.service

2014-12-08 Thread Olaf Hering
The references Environment file does not exist, and the service file does not make use of variables anyway. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service.in | 1 - 1 file

[Xen-devel] [PATCH 4/4] tools/hotplug: use xencommons as EnvironmentFile

2014-12-08 Thread Olaf Hering
The referenced sysconfig/xenconsoled does not exist. If anything needs to be specified it has to go into the existing sysconfig/xencommons file. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Linux/systemd

[Xen-devel] [PATCH 0/4 v2] tools/hotplug: systemd changes for 4.5

2014-12-08 Thread Olaf Hering
is ready. Olaf Olaf Hering (4): tools/hotplug: remove SELinux options from var-lib-xenstored.mount tools/hotplug: remove XENSTORED_ROOTDIR from service file tools/hotplug: remove EnvironmentFile from xen-qemu-dom0-disk-backend.service tools/hotplug: use xencommons as EnvironmentFile

[Xen-devel] [PATCH 1/4] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2014-12-08 Thread Olaf Hering
en-devel/2014-03/msg02462.html Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu Cc: Anthony PERARD Cc: M A Young Cc: Luis R. Rodriguez --- tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(

[Xen-devel] [PATCH 2/4] tools/hotplug: remove XENSTORED_ROOTDIR from service file

2014-12-08 Thread Olaf Hering
There is no need to export XENSTORED_ROOTDIR. This variable can be enabled in sysconfig/xencommons. If the variable is unset xenstored will automatically use @XEN_LIB_STORED@. Signed-off-by: Olaf Hering Acked-by: Ian Jackson Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-08 Thread Olaf Hering
On Fri, Dec 05, Ian Jackson wrote: > I think the only way to make this work properly is to factor the > necessary parts out of init.d/xencommons into a new script which can > be used by both xencommons and systemd. I'm not sure such a patch > would be appropriate for 4.5 at this stage. I came up

Re: [Xen-devel] [Xen-users] 4.5 git: regression in xen systemd shutdown hangs the OS

2014-12-08 Thread Olaf Hering
On Fri, Dec 05, Olaf Hering wrote: > But even with that change xendomains is hanging if it cant talk to > xenstored for whatever reason. The result is that the sytem hangs > forever at shutdown. This looks like a bug in the tools. xl or xenstore-ls hang forever if xenstored disappea

Re: [Xen-devel] [Xen-users] 4.5 git: regression in xen systemd shutdown hangs the OS

2014-12-08 Thread Olaf Hering
On Mon, Dec 08, Wei Liu wrote: > I think we have xenstored stubdom in tree, don't we? If we do, isnt that a "special" setup which does not appear all by its own? If so, shouldnt there be some config file knob to let xs_open use socket only unless told otherwise by the to-be-created knob? Olaf _

Re: [Xen-devel] [Xen-users] 4.5 git: regression in xen systemd shutdown hangs the OS

2014-12-09 Thread Olaf Hering
On Mon, Dec 08, Wei Liu wrote: > However I think the problem you're seeing is due to xenstored exits too > early, which should be fixable by rearranging the shutdown order? I.e. > xenstored shuts down after xendomains. True, and this is addressed by 268b8f1. Perhaps a crashed or otherwise unavai

[Xen-devel] [PATCH] tools/hotplug: xendomains.service depends on network

2014-12-09 Thread Olaf Hering
Starting domains during boot will most likely require network for the local bridge and it may need access to remote filesystems. Add ordering tags to systemd service file. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- This should go into

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-09 Thread Olaf Hering
On Tue, Dec 09, Ian Jackson wrote: > Olaf Hering writes ("Re: [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE > in systemd"): > > On Fri, Dec 05, Ian Jackson wrote: > > > I think the only way to make this work properly is to factor the > > > necessary p

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-10 Thread Olaf Hering
On Tue, Dec 09, Ian Jackson wrote: > Bottom line: as relevant maintainer, I'm afraid I'm going to insist > that this script be in /etc. I dont agree with the reasoning, but to get this done: Which place would that be, XEN_SCRIPT_DIR? > > > I don't think this script wants to contain an option par

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-10 Thread Olaf Hering
On Wed, Dec 10, Ian Campbell wrote: > I'm not sure why we don't want to exec in both cases, making this whole > problem moot. Good point! That will probably work because sysv lets xenstored do the fork, so the script will return to its caller. In systemd case --no-fork is passed so the started p

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-10 Thread Olaf Hering
On Wed, Dec 10, Ian Campbell wrote: > That results in a wrapper which unconditionally execs, the systemd unit > just calls that while the sysv script runs the wrapper and then does the > xenstore-read -s loop. Since systemd handles the socket there is already a listener. http://lists.freedesktop

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-10 Thread Olaf Hering
On Wed, Dec 10, Ian Campbell wrote: > Separately from the above I wonder if it might be worth moving the > xenstore readiness check into the xen-init-dom0 helper and having most > things which currently depend on xenstore actually depend on the > "dom0-is-ready" unit, which itself depends on xenst

Re: [Xen-devel] [PATCH 0/4 v2] tools/hotplug: systemd changes for 4.5

2014-12-11 Thread Olaf Hering
On Wed, Dec 10, Konrad Rzeszutek Wilk wrote: > On Mon, Dec 08, 2014 at 11:18:05AM +0100, Olaf Hering wrote: > > This is a resend of this series, with just the low hanging fruits: > > http://lists.xenproject.org/archives/html/xen-devel/2014-12/msg00669.html > This looks like it

Re: [Xen-devel] [PATCH 0/4 v2] tools/hotplug: systemd changes for 4.5

2014-12-11 Thread Olaf Hering
On Thu, Dec 11, M A Young wrote: > Yes, you do need to set explicit selinux permissions when mounting > /var/lib/xenstored as otherwise it gets a tmpfs selinux context which > xenstored can't use in enforcing mode. Is that "enforcing mode" the default? And would it be too cumbersome to have these

Re: [Xen-devel] [PATCH 0/4 v2] tools/hotplug: systemd changes for 4.5

2014-12-11 Thread Olaf Hering
On Thu, Dec 11, Olaf Hering wrote: > This sounds like xenstored has to parse the possible environment > variables found in sysconfig.xencommons all by itself? Is there perhaps > a way out of the SELinux jail? Does all that work with the sysv runlevel scrip

Re: [Xen-devel] [PATCH v4 0/9] toolstack-based approach to pvhvm guest kexec

2014-12-11 Thread Olaf Hering
On Wed, Dec 03, Vitaly Kuznetsov wrote: > When a PVHVM linux guest performs kexec there are lots of things which > require taking care of: > - shared info, vcpu_info > - grants > - event channels > - ... > Instead of taking care of all these things we can rebuild the domain > performing kexec from

Re: [Xen-devel] [PATCH v4 0/9] toolstack-based approach to pvhvm guest kexec

2014-12-11 Thread Olaf Hering
On Thu, Dec 11, David Vrabel wrote: > Nothing special needs to be done with ballooned pages. If frames are > not populated in the original domain, they will be unpopulated in the > new domain. > > It's the responsibility of the guest to ensure it either doesn't kexec > when it is ballooned or th

Re: [Xen-devel] [PATCH 0/4 v2] tools/hotplug: systemd changes for 4.5

2014-12-11 Thread Olaf Hering
On Thu, Dec 11, Konrad Rzeszutek Wilk wrote: > I wonder if we can detect the context during build-time (an autoconf function > that checks whether the build is done for Fedora?) > But what if the version of Fedora is different and the object is called > something else? Exactly. The build host is

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-12 Thread Olaf Hering
On Fri, Dec 12, Ian Campbell wrote: > Seems ok. I wonder if the wrapper ought to source > @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons to obtain XENSTORED_* itself > rather than relying on the initscript and unit file to do so. Especially > in the initscript case it looks a bit ugly to have to manual

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-12 Thread Olaf Hering
On Fri, Dec 12, Olaf Hering wrote: > On Fri, Dec 12, Ian Campbell wrote: > > > Seems ok. I wonder if the wrapper ought to source > > @CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons to obtain XENSTORED_* itself > > rather than relying on the initscript and unit file to do s

Re: [Xen-devel] [PATCH 5/5] tools/hotplug: support XENSTORED_TRACE in systemd

2014-12-12 Thread Olaf Hering
On Fri, Dec 12, Olaf Hering wrote: > This works: > ExecStart=@XENSTORED@ --no-fork $XENSTORED_ARGS > > This fails: > ExecStart=$XENSTORED --no-fork $XENSTORED_ARGS But this will likely work: ExecStart=/usr/bin/env $XENSTORED --no-fork $XENSTORED_ARGS Let me know how to p

Re: [Xen-devel] Xen 4.5 Development Update (RC4)

2014-12-16 Thread Olaf Hering
On Tue, Dec 16, konrad.w...@oracle.com wrote: > In terms of bugs, we have: ... systemd SELinux, but its not listed. Whats your plan with the failures you see? Should I continue to be concerned about that, or will all the be postponed to 4.6? Olaf ___

Re: [Xen-devel] Xen 4.5 Development Update (RC4)

2014-12-16 Thread Olaf Hering
On Tue, Dec 16, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 16, 2014 at 05:34:51PM +0100, Olaf Hering wrote: > > On Tue, Dec 16, konrad.w...@oracle.com wrote: > > > > > In terms of bugs, we have: > > > > ... systemd SELinux, but its not listed. > > &g

Re: [Xen-devel] Packaging xen 4.5.0 RC4 on Arch Linux

2014-12-17 Thread Olaf Hering
On Tue, Dec 16, Julian Sivertsen wrote: > The default Arch Linux kernel does not have SELinux, causing the > var-lib-xenstored.mount unit to fail due to an invalid context. This > can be worked around by removing the context option from the mount > options in that unit file. Mine does not have SE

Re: [Xen-devel] Packaging xen 4.5.0 RC4 on Arch Linux

2014-12-17 Thread Olaf Hering
On Tue, Dec 16, Julian Sivertsen wrote: > It would be reallly helpful if could get some pointers on how xen > should be built for packaging into a distribution, and whether I'm on > the right track. See the INSTALL file in the toplevel directory. Olaf ___

Re: [Xen-devel] [Testday] Arch Linux Test report

2014-12-18 Thread Olaf Hering
On Thu, Dec 18, Julian Sivertsen wrote: > == Issues === > Brief: Invalid FETCHER by ./configure > Importance: nuisance > Location: xen > Workaround: Install wget and reconfigure > The m4/fetcher.m4 script checks for the precence of wget before falling > back to "ftp -o". On Arch Linux curl is ship

Re: [Xen-devel] Xen 4.5 Development Update (RC4)

2014-12-18 Thread Olaf Hering
On Wed, Dec 17, Konrad Rzeszutek Wilk wrote: > [root@l konrad]# systemctl status xenstored.service > ● xenstored.service - The Xen xenstore >Loaded: loaded (/usr/lib/systemd/system/xenstored.service; disabled) >Active: failed (Result: timeout) since Wed 2014-12-17 16:39:35 EST; 2min > 10s

[Xen-devel] [PATCH 6/7] tools/hotplug: remove EnvironmentFile from xen-qemu-dom0-disk-backend.service

2014-12-19 Thread Olaf Hering
The references Environment file does not exist, and the service file does not make use of variables anyway. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service.in | 1 - 1 file

[Xen-devel] [PATCH 5/7] tools/hotplug: use XENCONSOLED_TRACE in xenconsoled.service

2014-12-19 Thread Olaf Hering
Instead of inventing a new XENCONSOLED_LOG= variable reuse the existing XENCONSOLED_TRACE= variable in xenconsoled.service. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Linux/systemd/xenconsoled.service.in | 4 ++-- 1 file

[Xen-devel] [PATCH 4/7] tools/hotplug: use xencommons as EnvironmentFile in xenconsoled.service

2014-12-19 Thread Olaf Hering
The referenced sysconfig/xenconsoled does not exist. If anything needs to be specified it has to go into the existing sysconfig/xencommons file. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Linux/systemd

[Xen-devel] [PATCH 0/7 v3] tools/hotplug: systemd changes for 4.5

2014-12-19 Thread Olaf Hering
env $XENSTORED pro: - $XENSTORED can be set in sysconfig file con: - may have the same socket issue as starting via shell - XENSTORED_TRACE boolean is not handled I will be offline until 2015-01-07, so any further adjustments to this series has to be done by someone else. Good luck! O

[Xen-devel] [PATCH 3/7] tools/hotplug: xendomains.service depends on network

2014-12-19 Thread Olaf Hering
Starting domains during boot will most likely require network for the local bridge and it may need access to remote filesystems. Add ordering tags to systemd service file. Signed-off-by: Olaf Hering Acked-by: Wei Liu Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu

[Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2014-12-19 Thread Olaf Hering
s. http://lists.xenproject.org/archives/html/xen-devel/2014-03/msg02462.html Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu Cc: Anthony PERARD Cc: M A Young Cc: Luis R. Rodriguez --- tools/hotplug/Linux/systemd/var-lib-xenstored.mount.

[Xen-devel] [PATCH 2/7] tools/hotplug: remove XENSTORED_ROOTDIR from xenstored.service

2014-12-19 Thread Olaf Hering
There is no need to export XENSTORED_ROOTDIR. This variable can be enabled in sysconfig/xencommons. If the variable is unset xenstored will automatically use @XEN_LIB_STORED@. Signed-off-by: Olaf Hering Acked-by: Ian Jackson Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu

[Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2014-12-19 Thread Olaf Hering
-fork, which causes xenstored to fork internally to return to the caller of the wrapper script. The place of the wrapper is currently LIBEXEC_BIN, it has to be decided what the final location is supposed to be. IanJ wants it in "/etc". Signed-off-by: Olaf Hering Cc: Ian Jackson C

Re: [Xen-devel] [PATCH] libxc: check return values on mmap() and madvise() on xc_alloc_hypercall_buffer()

2014-12-19 Thread Olaf Hering
Please backport this patch to 4.4. Other branches may need the mmap() check as well. The callers expect either NULL or a valid pointer. It is upstream commit e86539a388314cd3dca88f5e69d7873343197cd8 Thanks, Olaf On Wed, May 21, Ian Campbell wrote: > On Tue, 2014-05-20 at 05:37 -0700, Luis R.

Re: [Xen-devel] [PATCH 0/7 v3] tools/hotplug: systemd changes for 4.5

2014-12-22 Thread Olaf Hering
On Fri, Dec 19, Konrad Rzeszutek Wilk wrote: > On Fri, Dec 19, 2014 at 12:25:26PM +0100, Olaf Hering wrote: > > This is a resend of these two series: > > http://lists.xenproject.org/archives/html/xen-devel/2014-12/msg00858.html > > http://lists.xenproject.org/archives/h

Re: [Xen-devel] [PATCH v5 0/9] toolstack-based approach to pvhvm guest kexec

2015-01-07 Thread Olaf Hering
On Mon, Jan 05, Vitaly Kuznetsov wrote: > Wei Liu writes: > > > Olaf mentioned his concern about handling ballooned pages in > > <20141211153029.ga1...@aepfle.de>. Is that point moot now? > > Well, the limitation is real and some guest-side handling will be > required in case we want to support

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-01-07 Thread Olaf Hering
On Tue, Jan 06, Ian Campbell wrote: > On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote: ... > Acked-by: Ian Campbell > > (on commit s/Appearently/Apparently/; s/non-existant/non-existent/ in > the commit log) I made typos also in other commit messages. Should I resend th

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-01-07 Thread Olaf Hering
On Tue, Jan 06, Ian Campbell wrote: > On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote: > > The shell wrapper in xenstored.service does not handle XENSTORE_TRACE. > > > > Create a separate wrapper script which is used in the sysv runlevel > > script and in sy

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-01-07 Thread Olaf Hering
On Tue, Jan 06, Ian Jackson wrote: > Olaf Hering writes ("[PATCH 7/7] tools/hotplug: add wrapper to start > xenstored"): > > The shell wrapper in xenstored.service does not handle XENSTORE_TRACE. > ... > > +XENSTORED_LIBEXEC = xenstored.sh > > Shou

Re: [Xen-devel] [PATCH 0/7 v3] tools/hotplug: systemd changes for 4.5

2015-01-07 Thread Olaf Hering
On Mon, Jan 05, Konrad Rzeszutek Wilk wrote: > +Release Issues > +== > + > +While we did the utmost to get a release out, there are certain > +fixes which were not complete on time. As such please reference this > +section if you are running into trouble. > + > +* systemd not worki

Re: [Xen-devel] [PATCH v5 0/9] toolstack-based approach to pvhvm guest kexec

2015-01-07 Thread Olaf Hering
On Wed, Jan 07, David Vrabel wrote: > 2. Reducing the balloon prior to kexec. We carry a patch for kexec(1) which does balloon up before doing the actual kexec call. I propose to get such change into the upstream kexec tools if that is indeed the way to go. The benefit is that the guest waits unt

Re: [Xen-devel] [PATCH v5 0/9] toolstack-based approach to pvhvm guest kexec

2015-01-07 Thread Olaf Hering
On Wed, Jan 07, Vitaly Kuznetsov wrote: > The thing is .. we don't have these pages when kexec is being performed, > they are already ballooned out and the hypervisor doesn't have the > knowledge of which GFNs should be re-populated. I think it is possible > to keep track of all pages the guest ba

Re: [Xen-devel] Xen 4.5 Development Update (GA slip by a week)

2015-01-07 Thread Olaf Hering
On Tue, Jan 06, Konrad Rzeszutek Wilk wrote: > There is only one outstanding patch and that is "#7 tools/hotplug: add > wrapper to > start xenstored". Olaf is back tomorrow so it might make it .. or not. See my other replies. I think once we know how to deal with SELinux and systemd this change

[Xen-devel] check-headers error in staging

2015-01-07 Thread Olaf Hering
After upgrade to current staging, my test packages fail to build: [ 289s] + make -j4 -k -C tools/include/xen-foreign [ 289s] make: Entering directory `/usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign' [ 289s] python mkheader.py arm32 arm32.h /usr/src/packages/BUILD/x

Re: [Xen-devel] [PATCH 0/7 v3] tools/hotplug: systemd changes for 4.5

2015-01-07 Thread Olaf Hering
On Wed, Jan 07, Konrad Rzeszutek Wilk wrote: > On Wed, Jan 07, 2015 at 10:53:06AM +0100, Olaf Hering wrote: > > Its my understanding that the reported SELinux failure is not only > > related to the context= mount option, but also to the socket passing > > from systemd. >

[Xen-devel] [PATCH 2/2] tools/hotplug: remove usage of XENSTORED_TRACE boolean

2015-01-07 Thread Olaf Hering
The existing XENSTORED_TRACE= boolean cant be easily implemented in the xenstored.service file. All additional options should be added to the XENSTORED_ARGS= variable. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Linux

[Xen-devel] [PATCH 0/2] tools/hotplug/Linux changes

2015-01-07 Thread Olaf Hering
-4.5. Olaf Olaf Hering (2): tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file. tools/hotplug: remove usage of XENSTORED_TRACE boolean tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 8 +--- tools/hotplug/Linux/init.d/xencommons.in | 1 - 2 files changed, 5

[Xen-devel] [PATCH 1/2] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

2015-01-07 Thread Olaf Hering
It is already used in the runlevel script and the service file. It is supposed to replace XENSTORED_TRACE= boolean, which cant be easily supported in the xenstored.service file. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug

Re: [Xen-devel] [PATCH 1/2] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

2015-01-07 Thread Olaf Hering
On Wed, Jan 07, Ian Campbell wrote: > On Wed, 2015-01-07 at 16:49 +, Ian Jackson wrote: > > Certainly removing this feature this late in the 4.5 release cycle is > > not appropriate. > > I agree that faffing around with the initscripts/systemd units at the > eleventh hour seem liable to leave

Re: [Xen-devel] preparing for 4.4.2 / 4.3.4

2015-01-12 Thread Olaf Hering
On Thu, Jan 08, Jan Beulich wrote: > now that 4.5 is almost out the door, I'd like to get stable releases > prepared on the other two active branches. 4.3.4 is expected to be > the last xen.org managed release on the 4.3 branch. Aiming at RC1s > some time next week, please indicate commits you con

Re: [Xen-devel] [Xen-users] [TestDay] minor bug + possible configuration bug 4.5rc4 archlinux

2015-01-12 Thread Olaf Hering
On Mon, Jan 12, Ian Campbell wrote: > Adding some CC's, including the devel list. > > On Fri, 2015-01-09 at 19:49 -0600, Doug McMillan wrote: > > configuration(?) > > I compiled booted straight from bios with xen.efi during boot I received > > several errors. > > xl info works (see attachment).

Re: [Xen-devel] [Xen-users] [TestDay] minor bug + possible configuration bug 4.5rc4 archlinux

2015-01-12 Thread Olaf Hering
On Mon, Jan 12, Doug McMillan wrote: > ./configure \ >--localstatedir=/run \ This is wrong for every setup one can think of. It has to be /var. Olaf ___ Xen-devel mailin

Re: [Xen-devel] [Xen-users] [TestDay] minor bug + possible configuration bug 4.5rc4 archlinux

2015-01-13 Thread Olaf Hering
On Mon, Jan 12, Ian Campbell wrote: > @devs -- we obviously need to do something about this (too late for 4.5, > but for 4.6 + backport). Perhaps there is some alternative systemd > construction which disassociates the actual path from the abstract > service "xenstored dir mounted"? I dont think

Re: [Xen-devel] [PATCH] libxl: provide xenlight.pc

2015-01-13 Thread Olaf Hering
On Tue, Jan 13, Ian Campbell wrote: > On Fri, 2015-01-09 at 14:32 +, Wei Liu wrote: > > A pkg-config file for libxl. It also contains two variables > > (xenfirmwaredir and libexec_bin) so that tools that are very keen on > > knowing the locations of Xen binaries (say, libvirt) can use them to

Re: [Xen-devel] [Xen-users] [TestDay] minor bug + possible configuration bug 4.5rc4 archlinux

2015-01-13 Thread Olaf Hering
On Tue, Jan 13, Doug McMillan wrote: > Also quick question if I am understanding my remaining issue [tmpfs: Bad mount > option context] as described by a previous thread. Until > the code that generates it changes I need to manually change > var-lib-xenstored.mount from ... > Or am I misunderstand

Re: [Xen-devel] [PATCH] tools/configure: Check if pixman is present on the system

2015-01-14 Thread Olaf Hering
On Wed, Jan 14, Ian Campbell wrote: > A far more heavy weight (but probably better) solution would be to > arrange for the clone (and necessary downloads) + submodule configure to > happen at configure rather than build time. That's a much bigger job > though and I wouldn't expect anyone to take t

Re: [Xen-devel] [PATCH] Fix building error

2015-01-14 Thread Olaf Hering
On Thu, Jan 15, Wen Congyang wrote: > Commit 1166ecf7 disables optimization. But python's build > process may use CFLAGS -Wp,-D_FORTIFY_SOURCE=2, and suppose > the 3rd party python modules to use. The macro _FORTIFY_SOURCE > requires compiling with optimization (-O). Disable _FORTIFY_SOURCE > by a

Re: [Xen-devel] [PATCH] Fix building error

2015-01-15 Thread Olaf Hering
On Thu, Jan 15, Wen Congyang wrote: > Xen doesn't use the macro _FORTIFY_SOURCE, so it only affects python > modules now. It does if it is passed via global CFLAGS, like the RPM_OPT_FLAGS from a rpm package build. Olaf ___ Xen-devel mailing list Xen-d

Re: [Xen-devel] RFC: Survey on release cycle

2015-10-15 Thread Olaf Hering
On Thu, Oct 15, Ian Campbell wrote: > On Mon, 2015-10-12 at 18:32 +0100, Wei Liu wrote: > > > # 6 months release cycle + current stable release scheme > # 6 months release cycle + extended security support > > +1 to either of these, but +2 for picking one of them. +1, as Ian said. > (not rea

Re: [Xen-devel] [PATCH v7 2/3] x86: add domctl cmd to set/get CDP code/data CBM

2015-10-15 Thread Olaf Hering
On Tue, Oct 13, He Chen wrote: > +int psr_set_l3_cbm(struct domain *d, unsigned int socket, > + uint64_t cbm, enum cbm_type type) > { > +uint64_t cbm_data, cbm_code; > +switch ( type ) > { > +case PSR_CBM_TYPE_L3: > +cbm_code = cbm; > +break;

<    2   3   4   5   6   7   8   9   >