Re: Failure in detecting keyboard

2010-02-02 Thread Amey
On Mon, Feb 1, 2010 at 9:02 AM, Dan Nicholson wrote: > On Sun, Jan 31, 2010 at 4:58 PM, Peter Hutterer > wrote: > > On Sat, Jan 30, 2010 at 09:17:12AM +0530, Amey wrote: > >> Hello all, > >>I am a final year graduate student and I am trying to > >> configure X server.In that when

Re: "empty" model/layout for xkb

2010-02-02 Thread Peter Hutterer
On Tue, Jan 26, 2010 at 12:36:55PM -0800, Jeremy Huddleston wrote: > I'm trying to modify xkeyboard-config to create an "empty" xbk rules set. > This way, we can set "empty" as the default in XQuartz and have a clean > slate. > > I'm having a bit of trouble getting this to work. Firstly, I can't

Re: Failure in detecting keyboard

2010-02-02 Thread Dan Nicholson
On Tue, Feb 2, 2010 at 12:26 AM, Amey wrote: > > On Mon, Feb 1, 2010 at 9:02 AM, Dan Nicholson wrote: >> >> On Sun, Jan 31, 2010 at 4:58 PM, Peter Hutterer >> wrote: >> > On Sat, Jan 30, 2010 at 09:17:12AM +0530, Amey wrote: >> >> Hello all, >> >>                I am a final year graduate studen

Re: "empty" model/layout for xkb

2010-02-02 Thread Dan Nicholson
On Tue, Jan 26, 2010 at 12:36 PM, Jeremy Huddleston wrote: > I'm trying to modify xkeyboard-config to create an "empty" xbk rules set.   > This way, we can set "empty" as the default in XQuartz and have a clean slate. > > I'm having a bit of trouble getting this to work.  Firstly, I can't seem to

Re: "empty" model/layout for xkb

2010-02-02 Thread Dan Nicholson
On Tue, Feb 2, 2010 at 6:09 AM, Sergey Udaltsov wrote: > Dan > > Well, these changes look a bit odd, but ok, let's have them. Could you > please create a bug in bugzilla and attach your patch there. Just for > accountability sake. I think Jeremy was more asking why they weren't working as expecte

Re: "empty" model/layout for xkb

2010-02-02 Thread Sergey Udaltsov
Dan Well, these changes look a bit odd, but ok, let's have them. Could you please create a bug in bugzilla and attach your patch there. Just for accountability sake. Thanks, Sergey On Tue, Feb 2, 2010 at 2:06 PM, Dan Nicholson wrote: > On Tue, Jan 26, 2010 at 12:36 PM, Jeremy Huddleston > wro

[PATCH] parser: corrected xf86getBoolValue to use case insensitive compare

2010-02-02 Thread Oliver McFadden
commit c6e8637e29e0ca11dfb35c02da7ca6002ac8c597 introduced this regression; it can cause existing config files to be parsed incorrectly. Signed-off-by: Oliver McFadden --- hw/xfree86/parser/scan.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/xfree86/

Re: "empty" model/layout for xkb

2010-02-02 Thread Jeremy Huddleston
On Feb 2, 2010, at 03:18, Peter Hutterer wrote: > On Tue, Jan 26, 2010 at 12:36:55PM -0800, Jeremy Huddleston wrote: >> I'm trying to modify xkeyboard-config to create an "empty" xbk rules set. >> This way, we can set "empty" as the default in XQuartz and have a clean >> slate. >> >> I'm having

-fno-strict-aliasing in CWARNFLAGS?

2010-02-02 Thread Jeremy Huddleston
What's the rationale behind having -fno-strict-aliasing in CWARNFLAGS? Do we actually have code somewhere that needs -fno-strict-aliasing? If so, we should restrict -fno-strict-aliasing to that project (and try to address the reason for the need) rather than putting it in util-macros. ___

Re: [PATCH] parser: corrected xf86getBoolValue to use case insensitive compare

2010-02-02 Thread Dan Nicholson
On Tue, Feb 2, 2010 at 6:43 AM, Oliver McFadden wrote: > commit c6e8637e29e0ca11dfb35c02da7ca6002ac8c597 introduced this > regression; it can cause existing config files to be parsed incorrectly. > > Signed-off-by: Oliver McFadden > --- >  hw/xfree86/parser/scan.c |   16 >  1 fil

[PATCH libX11 0/4] Diverse manual improvements

2010-02-02 Thread Dirk Wallenstein
If the patch in response to the bug arrived already I'm sorry. I'll change my subsription to my main account (halsmit). Dirk Wallenstein (4): man: Redirect users from XKeycodeToKeysym to XkbKeycodeToKeysym #25732 man: Fix return value specification of XkbKeyActionEntry man: Fix value of XkbA

[PATCH libX11 4/4] man: Return value of XkbGetState is Status and not Bool

2010-02-02 Thread Dirk Wallenstein
Signed-off-by: Dirk Wallenstein --- man/xkb/XkbGetState.man |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/xkb/XkbGetState.man b/man/xkb/XkbGetState.man index d591b1e..4e0 100644 --- a/man/xkb/XkbGetState.man +++ b/man/xkb/XkbGetState.man @@ -24,7 +24,7 @@ XkbG

[PATCH libX11 3/4] man: Fix value of XkbAllComponentsMask in XkbGetKeyboard

2010-02-02 Thread Dirk Wallenstein
XkbAllComponentsMask is the combination of all component masks not just a single bit. Signed-off-by: Dirk Wallenstein --- man/xkb/XkbGetKeyboard.man |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/xkb/XkbGetKeyboard.man b/man/xkb/XkbGetKeyboard.man index ab6b8d7..0a

[PATCH libX11 1/4] man: Redirect users from XKeycodeToKeysym to XkbKeycodeToKeysym #25732

2010-02-02 Thread Dirk Wallenstein
XKeycodeToKeysym keeps compatibility with pre-XKB and thus only sees 2 groups with 2 levels each. It wraps the index into the next group. This behavior confuses the unaware user, and therefore this will add a reference to XkbKeycodeToKeysym in the corresponding man paragraph. Another bug had that

[PATCH libX11 2/4] man: Fix return value specification of XkbKeyActionEntry

2010-02-02 Thread Dirk Wallenstein
The XkbKeyActionEntry macro expands to a pointer. Signed-off-by: Dirk Wallenstein --- man/xkb/XkbKeyActionEntry.man |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/man/xkb/XkbKeyActionEntry.man b/man/xkb/XkbKeyActionEntry.man index 5acc7e8..c6ebc18 100644 --- a/ma

Re: [PATCH] parser: corrected xf86getBoolValue to use case insensitive compare

2010-02-02 Thread Julien Cristau
On Tue, Feb 2, 2010 at 16:43:00 +0200, Oliver McFadden wrote: > commit c6e8637e29e0ca11dfb35c02da7ca6002ac8c597 introduced this > regression; it can cause existing config files to be parsed incorrectly. > > Signed-off-by: Oliver McFadden Acked-by: Julien Cristau (with or without the change D

Re: [PATCH libX11 3/4] man: Fix value of XkbAllComponentsMask in XkbGetKeyboard

2010-02-02 Thread Julien Cristau
On Tue, Feb 2, 2010 at 21:24:31 +0100, Dirk Wallenstein wrote: > XkbAllComponentsMask is the combination of all component masks not just > a single bit. > > Signed-off-by: Dirk Wallenstein Reviewed-by: Julien Cristau Cheers, Julien ___ xorg-devel m

Re: [PATCH libX11 4/4] man: Return value of XkbGetState is Status and not Bool

2010-02-02 Thread Julien Cristau
On Tue, Feb 2, 2010 at 21:24:32 +0100, Dirk Wallenstein wrote: > Signed-off-by: Dirk Wallenstein Reviewed-by: Julien Cristau Cheers, Julien ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel

Re: -fno-strict-aliasing in CWARNFLAGS?

2010-02-02 Thread Gaetan Nadon
On Tue, 2010-02-02 at 09:28 -0800, Jeremy Huddleston wrote: > What's the rationale behind having -fno-strict-aliasing in CWARNFLAGS? > > Do we actually have code somewhere that needs -fno-strict-aliasing? If so, > we should restrict -fno-strict-aliasing to that project (and try to address > th

Re: [PATCH libX11 2/4] man: Fix return value specification of XkbKeyActionEntry

2010-02-02 Thread Julien Cristau
On Tue, Feb 2, 2010 at 21:24:30 +0100, Dirk Wallenstein wrote: > The XkbKeyActionEntry macro expands to a pointer. > > Signed-off-by: Dirk Wallenstein wow. what a mess of macros... Reviewed-by: Julien Cristau ___ xorg-devel mailing list xorg-devel

Re: [PATCH libX11 3/4] man: Fix value of XkbAllComponentsMask in XkbGetKeyboard

2010-02-02 Thread Jeremy Huddleston
I'd prefer to see this written as: (1L<<7) - 1L On Feb 2, 2010, at 12:24, Dirk Wallenstein wrote: > XkbAllComponentsMask is the combination of all component masks not just > a single bit. > > Signed-off-by: Dirk Wallenstein > --- > man/xkb/XkbGetKeyboard.man |2 +- > 1 files changed, 1 inse

Re: -fno-strict-aliasing in CWARNFLAGS?

2010-02-02 Thread Jeremy Huddleston
On Feb 2, 2010, at 13:18, Gaetan Nadon wrote: > I have not seen any compelling reasons to turn off this optimization. > Maybe 10 years ago when it was first introduced. I have seen reports of > large number of warnings, but from older gcc versions. As it is today, > we are losing some optimizatio

[PATCH util-macros 2/2] Add -Wformat=2 to the default CWARNFLAGS

2010-02-02 Thread Jeremy Huddleston
This will include -Wformat-security to catch possible security problems in formatting in printf, scanf, etc. Signed-off-by: Jeremy Huddleston --- xorg-macros.m4.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in index 40f5939..6d6f

[PATCH util-macros 1/2] Don't disable strict aliasing (-fno-strict-aliasing) globally

2010-02-02 Thread Jeremy Huddleston
Instead, we warn where this optimization might cause a problem! This was included for historic reasons and has persisted to the point of now infecting all X.org modules. Historically, it was just present in these modules before adding XORG_CWARNFLAGS to XORG_DEFAULT_OPTIONS: libICE libSM libX11

Re: [PATCH libX11 2/4] man: Fix return value specification of XkbKeyActionEntry

2010-02-02 Thread Dan Nicholson
On Tue, Feb 2, 2010 at 1:32 PM, Julien Cristau wrote: > On Tue, Feb  2, 2010 at 21:24:30 +0100, Dirk Wallenstein wrote: > >> The XkbKeyActionEntry macro expands to a pointer. >> >> Signed-off-by: Dirk Wallenstein > > wow.  what a mess of macros... > > Reviewed-by: Julien Cristau Venture into th

[PATCH libX11 1/2] Fix warnings for recent bigreqsproto, xcmiscproto, and xf86bigfontproto

2010-02-02 Thread Jeremy Huddleston
Signed-off-by: Jeremy Huddleston --- configure.ac |6 +++--- src/Font.c|2 +- src/OpenDis.c |2 +- src/XlibInt.c |2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 0eea575..00ab51c 100644 --- a/configure.ac +++ b/configure

[PATCH libX11 2/2] Fix various build warnings

2010-02-02 Thread Jeremy Huddleston
imLcIm.c: In function '_XimCachedFileName': imLcIm.c:361: warning: format '%03x' expects type 'unsigned int', but argument 8 has type 'long unsigned int' imLcIm.c:364: warning: format '%03x' expects type 'unsigned int', but argument 8 has type 'long unsigned int' imRm.c: In function '_XimDefaul

Re: "empty" model/layout for xkb

2010-02-02 Thread Sergey Udaltsov
Jeremy, I just tried setxkbmap -model "" -layout "" -option "" -print xkb_keymap { xkb_keycodes { include "evdev" }; xkb_types { include "complete" }; xkb_geometry { include "pc(pc104)" }; }; The values for keycodes, types, geometry are taken from rules/evd

Re: -fno-strict-aliasing in CWARNFLAGS?

2010-02-02 Thread Gaetan Nadon
On Tue, 2010-02-02 at 14:00 -0800, Jeremy Huddleston wrote: > On Feb 2, 2010, at 13:18, Gaetan Nadon wrote: > > > I have not seen any compelling reasons to turn off this optimization. > > Maybe 10 years ago when it was first introduced. I have seen reports of > > large number of warnings, but fro

Re: -fno-strict-aliasing in CWARNFLAGS?

2010-02-02 Thread Jeremy Huddleston
On Feb 2, 2010, at 17:11, Gaetan Nadon wrote: > On Tue, 2010-02-02 at 14:00 -0800, Jeremy Huddleston wrote: > >> On Feb 2, 2010, at 13:18, Gaetan Nadon wrote: >> >>> I have not seen any compelling reasons to turn off this optimization. >>> Maybe 10 years ago when it was first introduced. I have

Re: -fno-strict-aliasing in CWARNFLAGS?

2010-02-02 Thread Gaetan Nadon
On Tue, 2010-02-02 at 17:34 -0800, Jeremy Huddleston wrote: > On Feb 2, 2010, at 17:11, Gaetan Nadon wrote: > > > On Tue, 2010-02-02 at 14:00 -0800, Jeremy Huddleston wrote: > > > >> On Feb 2, 2010, at 13:18, Gaetan Nadon wrote: > >> > >>> I have not seen any compelling reasons to turn off this

Re: [PATCH libX11 2/2] Fix various build warnings

2010-02-02 Thread Dan Nicholson
On Tue, Feb 2, 2010 at 5:03 PM, Jeremy Huddleston wrote: > > imLcIm.c: In function '_XimCachedFileName': > imLcIm.c:361: warning: format '%03x' expects type 'unsigned int', but > argument 8 has type 'long unsigned int' > imLcIm.c:364: warning: format '%03x' expects type 'unsigned int', but > arg

Re: [PATCH libX11 1/2] Fix warnings for recent bigreqsproto, xcmiscproto, and xf86bigfontproto

2010-02-02 Thread Dan Nicholson
On Tue, Feb 2, 2010 at 5:03 PM, Jeremy Huddleston wrote: > > Signed-off-by: Jeremy Huddleston > --- >  configure.ac  |    6 +++--- >  src/Font.c    |    2 +- >  src/OpenDis.c |    2 +- >  src/XlibInt.c |    2 +- >  4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/configure.ac b/c

Re: [PATCH libX11 1/2] Fix warnings for recent bigreqsproto, xcmiscproto, and xf86bigfontproto

2010-02-02 Thread Jeremy Huddleston
On Feb 2, 2010, at 19:49, Dan Nicholson wrote: >> - X11_REQUIRES="${X11_REQUIRES} xau xcmiscproto bigreqsproto" >> + X11_REQUIRES="${X11_REQUIRES} xau [xcmiscproto >= 1.2.0] >> [bigreqsproto >= 1.1.0]" > > Do these actually change anything? autoconf is just going to remove > the []

Re: Failure in detecting keyboard

2010-02-02 Thread Peter Hutterer
On Mon, Feb 01, 2010 at 08:43:58AM +, Sergey Udaltsov wrote: > Hi Peter > > > Sergey, is there still reason for doing this? I note the commit dates back > > to 2004. > Well, at that point in 2004 something did not work without it, so I > created it. If you're saying that now it is not necessar