when a new damage object is created.
As this patch makes DamageReportDamage a public interface, the
function has been moved into the part of the file that contains all
the other public functions. The function has not been otherwise
modified.
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
window update when a new damage object is
created.
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
damageext/damageext.c |2 +-
miext/damage/damage.c | 12
miext/damage/damage.h |5 +
3 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/damageext
XauGetFileName is a thread-safe variant of XauFileName.
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi
---
AuGetAddr.c | 12 +++-
AuGetBest.c | 12 +++-
2 files changed, 14 insertions(+), 10 deletions(-)
diff --git
to
its documentation.
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi
---
AuFileName.c| 163 ++-
configure.ac|5 ++
include/X11/Xauth.h | 38
man/Xau.man
the
previous return values), by supporting the getenv_r function, if it is
available. XauGetFileName is still easy to use in the basic situation,
but it works in fixed size buffer situations as well.
Erkki Seppälä (2):
XauGetFileName: added a thread-safe variant of XauFileName
XauGet*AuthByAddr: use
DetermineClientPid didn't close file descriptor if read on
/proc/pid/cmdline failed. Adjusted the code to disregard the close
return value and perform the return after that, if the read failed or
returned EOF.
Signed-off-by: Mark Kettenis mark.kette...@xs4all.nl
Signed-off-by: Erkki Seppälä
is created.
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
damageext/damageext.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/damageext/damageext.c b/damageext/damageext.c
index cfef069..7a0a779 100644
--- a/damageext/damageext.c
+++ b/damageext/damageext.c
DetermineClientPid didn't close file descriptor if read on
/proc/pid/cmdline failed. Added close to that path of code.
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi
---
os/client.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions
.
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
Signed-off-by: Stefan Kost stefan.k...@nokia.com
---
Stefan, please ask a proper Reported-by tag for the bug from the
original reporter.
config/udev.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/config/udev.c b
The record allocated by miSpriteDeviceCursorInitialize was not being
released. This patch adds a call to free and resetting the private
record to miSpriteDeviceCursorCleanup.
Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
mi/misprite.c
if miDCDeviceInitialize succeeds. The record itself
is zeroed on cleanup to ensure that the assumptions in the code still
hold.
Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
mi/misprite.c | 41 +++--
1 files
...@vincit.fi
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
hw/xfree86/common/xf86Config.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c
index 28786ba..906d4bd 100644
--- a/hw/xfree86/common
with one that is gotoed into.
Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
hw/xfree86/modes/xf86Crtc.c | 21 -
1 files changed, 8 insertions(+), 13 deletions(-)
diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw
existing behavior, which may be relied upon.
Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
record/record.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/record/record.c b/record/record.c
index 6a93d7a..bea3046
Erkki Seppälä (1):
xcms/cmsProp: don't deal with uninitialized values, fail instead
src/xcms/LRGB.c|1 -
src/xcms/cmsProp.c | 24 +---
2 files changed, 13 insertions(+), 12 deletions(-)
___
xorg-devel@lists.x.org: X.Org
property_return in call to free
Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi
Signed-off-by: Ander Conselvan de Oliveira
ander.conselvan-de-olive...@nokia.com
---
src/xcms/LRGB.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/xcms/LRGB.c b/src/xcms/LRGB.c
index 750c492
not have been reached.
This patch alters the function to return XcmsFailure if the call to
XGetWindowProperty fails.
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
are available in the git repository at:
git://gitorious.org/erkkise/libx11-fixes.git fixes-reviewed-1
Erkki Seppälä (4):
Using freed pointer e
Dereferencing possibly NULL str in call to function memcpy (Deref
assumed on the basis of 'nonnull' parameter attribute.)
Variable
Check for the NULLness of prop-name and prop-value instead of
name and value, which was checked earlier anyway. Decided against
using strdup due to curious memory allocation functions and the
rest of the xkb not using it either.
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
diff --git
Here are revised versions of the fixes that got some review comments
on the list.
Erkki Seppälä (3):
Variable map goes out of scope
Using uninitialized value p-modifiers
Cannot reach dead statement return NULL;
modules/im/ximcp/imThaiFlt.c |9 +++--
src/KeyBind.c
Small fix by using Xcalloc instead of Xmalloc
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
diff --git a/src/KeyBind.c b/src/KeyBind.c
index 6d80a02..ac25ce2 100644
--- a/src/KeyBind.c
+++ b/src/KeyBind.c
@@ -996,7 +996,7 @@ XRebindKeysym (
tmp = dpy-key_bindings;
nb = sizeof
Release modifiermap before returning. Reordered code to call
XGetModifierMapping after the first return from the function.
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
diff --git a/modules/im/ximcp/imThaiFlt.c b/modules/im/ximcp/imThaiFlt.c
index e0b3988..e2b0458 100644
--- a/modules/im
uninitialized value conv-state in call to function
close_converter
Erkki Seppälä (19):
Variable fs not freed or pointed-to in function get_prop_name
Pointer pBuf returned from fgets(buf, 256, stream) is never used
Pointer pBuf returned from fgets(buf, 256, stream) is never used
Using
Removed unused assignment
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xcms/cmsColNm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xcms/cmsColNm.c b/src/xcms
Removed unused assignment
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xcms/cmsColNm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xcms/cmsColNm.c b/src/xcms
Fixed a missing call to XFreeFont
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xlibi18n/XDefaultOMIF.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/xlibi18n
Fixed memory leak by adding Xfree and initializing missing_list with NULL
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imRmAttr.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions
Fixed memory leak by adding Xfree
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/ImUtil.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/ImUtil.c b/src/ImUtil.c
index
Fixed by using strncpy and explicitly terminating the buffer
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/XlibInt.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src
Instead of copying the value returned by get_prop_name and then releasing it,
directly use the return value of get_prop_name, which allocates memory for the
name.
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
Fixed memory leak by adding Xfree
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imRmAttr.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im/ximcp/imRmAttr.c
index ae053c9..5035df5 100644
--- a/modules/im
Removed superfluous check for NULL target_dir; it is already handled
before this code.
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xlibi18n/lcFile.c |3 +--
1 files changed, 1 insertions(+), 2
Fixed memory leak by adding Xfree
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imRmAttr.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/modules/im/ximcp
Checked return value of XGetWindowProperty and return false if it fails.
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imTrX.c | 33 +
1 files changed, 21 insertions(+), 12 deletions(-)
diff --git a/modules/im/ximcp/imTrX.c b/modules
are XBufferOverflow,
XLookupNone, XLookupChars, XLookupKeySym, and XLookupBoth. Each of
these has a specific meaning attached.
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imLcLkup.c |4
1 files
From: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
info_list-watch_data was being reallocated, but the return value of the
reallocation was stored only into a local variable. This might cause some funky
behavior and crashes.
Reviewed-by: Erkki Seppälä erkki.sepp
Fixed memory leak by adding Xfree
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imRm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRm.c b
Fixed memory leak by adding Xfree
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imRm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRm.c b
From: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Fixed by zero'ing conv on allocation. Then close_converter works properly.
Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi
Signed-off-by: Ander Conselvan de Oliveira
ander.conselvan-de-olive...@nokia.com
Signed-off
Zero-initialized new
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xlibi18n/lcGeneric.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xlibi18n/lcGeneric.c b/src/xlibi18n
The NEWTABLE macro missed freeing its allocated memory on subsequent memory
allocation errors. Added call to Xfree.
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/Xrm.c |4 +++-
1 files changed, 3
From: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
The rest of the code uses goto's to free memory allocated later
and prevent memory leaks, but there were several paths were
property_return was free'd just before a goto.
Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi
From: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
property_return was not free'd if the allocation of pRedTbl failed.
Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi
Signed-off-by: Ander Conselvan de Oliveira
ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki
Fixed the handling of the extremely unlikely situation of fstat failing
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/Xrm.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git
Removed superfluous check for NULL target_dir; it is already handled
before this code.
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xlibi18n/lcFile.c |3 +--
1 files changed, 1 insertions(+), 2
Seppälä erkki.sepp...@vincit.fi
Signed-off-by: Ander Conselvan de Oliveira
ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xcms/cmsProp.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/xcms/cmsProp.c b/src
by zero'ing conv on allocation. Then close_converter works properly.
Erkki Seppälä (19):
Fixed a missing call to XFreeFont
Removed unused assignment
Removed unused assignment
Zero-initialized new
Fixed by using strncpy and explicitly terminating the buffer
Fixed memory
Pointer pBuf returned from fgets(buf, 256, stream) is never used
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xcms/cmsColNm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
Pointer pBuf returned from fgets(buf, 256, stream) is never used
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xcms/cmsColNm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
Variable table goes out of scope
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/Xrm.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/Xrm.c b/src/Xrm.c
index 21f0af3
Variable fs not freed or pointed-to in function get_prop_name
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xlibi18n/XDefaultOMIF.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff
Tracked variable size was passed to a negative sink.
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/Xrm.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/Xrm.c b/src
Variable colormap_ret goes out of scope
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imRm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp
From: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Double free of pointer property_return in call to free
Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi
Signed-off-by: Ander Conselvan de Oliveira
ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä
Variable colormap_ret goes out of scope
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imRmAttr.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im/ximcp/imRmAttr.c
index ae053c9..5035df5 100644
Variable image goes out of scope
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/ImUtil.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/ImUtil.c b/src/ImUtil.c
index cd418d8
Variable colormap_ret goes out of scope
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imRmAttr.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/modules/im/ximcp
Possible overrun of 8192 byte fixed size buffer buffer by copying ext-name
without length checking
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/XlibInt.c |7 ---
1 files changed, 4 insertions
From: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Using uninitialized value conv-state in call to function close_converter
Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi
Signed-off-by: Ander Conselvan de Oliveira
ander.conselvan-de-olive...@nokia.com
Signed-off
Using uninitialized value error.resourceID in call to function _XError
Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi
Signed-off-by: Ander Conselvan de Oliveira
ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/GetProp.c |2 +-
1 files
Using uninitialized value new
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xlibi18n/lcGeneric.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xlibi18n/lcGeneric.c b/src
-by: Erkki Seppälä erkki.sepp...@vincit.fi
Signed-off-by: Ander Conselvan de Oliveira
ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/XlibInt.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/XlibInt.c b/src/XlibInt.c
index
Return value of XGetWindowProperty(im-core.display, spec-lib_connect_wid,
prop, 0L, (length + bytes_after_ret + 3UL) / 4UL, 1, 0UL, type_ret,
format_ret, nitems, bytes_after_ret, prop_ret) is not checked
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imTrX.c | 33
From: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
xcms/LRGB: Add a label for freeing property_return.
Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi
Signed-off-by: Ander Conselvan de Oliveira
ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp
From: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
xcms/LRGB: Fix potential resource leak.
Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi
Signed-off-by: Ander Conselvan de Oliveira
ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp
Variable prop_name not freed or pointed-to in function strlen
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xlibi18n/XDefaultOMIF.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff
Cannot reach dead expression 0U inside statement if (1U + (target_dir ?
strl...
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xlibi18n/lcFile.c |3 +--
1 files changed, 1 insertions(+), 2 deletions
Cannot reach dead expression 0U inside statement if (1U + (target_dir ?
strl...
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xlibi18n/lcFile.c |3 +--
1 files changed, 1 insertions(+), 2 deletions
. Each of
these has a specific meaning attached.
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imLcLkup.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/modules/im
Variable missing_list goes out of scope
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imRmAttr.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/modules/im/ximcp
Fixed memory leak by adding Xfree
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imRmAttr.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im/ximcp/imRmAttr.c
index ae053c9..5035df5 100644
--- a/modules/im
Check entry for non-nullness before dereferencing it
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xkb/XKB.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xkb/XKB.c b/src
From: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
property_return was free'd before and in the case the conditional is
true, the call to XcmsGetProperty failed which means that
property_return wasn't set so there is no need to free it again.
Reviewed-by: Erkki Seppälä
The NEWTABLE macro missed freeing its allocated memory on subsequent memory
allocation errors. Added call to Xfree.
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/Xrm.c |4 +++-
1 files changed, 3
Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi
Signed-off-by: Ander Conselvan de Oliveira
ander.conselvan-de-olive...@nokia.com
---
src/GetProp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/GetProp.c b/src/GetProp.c
index a80c19c..5d6e0b8 100644
--- a/src
From: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
property_return was not free'd if the allocation of pRedTbl failed.
Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi
Signed-off-by: Ander Conselvan de Oliveira
ander.conselvan-de-olive...@nokia.com
---
src/xcms/LRGB.c
Fixed memory leak by adding Xfree
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imRm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRm.c b
Checked return value of XGetWindowProperty and return false if it fails.
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imTrX.c | 33 +
1 files changed, 21 insertions(+), 12 deletions(-)
diff --git a/modules/im/ximcp/imTrX.c b/modules
, unless the subsequent
if (format_ret == 0 || nitems_ret == 0)
ends up returning XcmsFailure, the freed value of prop_ret from the
previous call to XGWP will be returned.
This patches changes the funcion to behavior to return XcmsFailure
if the call do XGetWindowProperty fails.
Reviewed-by: Erkki
Fixed the handling of the extremely unlikely situation of fstat failing
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/Xrm.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git
Removed superfluous check for NULL target_dir; it is already handled
before this code.
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xlibi18n/lcFile.c |3 +--
1 files changed, 1 insertions(+), 2
Removed superfluous comparison.
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xkb/XKBMisc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xkb/XKBMisc.c b/src/xkb/XKBMisc.c
index fc5ae5f..4aa1f73 100644
--- a/src/xkb/XKBMisc.c
+++ b/src/xkb/XKBMisc.c
Removed superfluous check for NULL target_dir; it is already handled
before this code.
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xlibi18n/lcFile.c |3 +--
1 files changed, 1 insertions(+), 2
Fixed memory leak by adding Xfree
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imRm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/modules/im/ximcp/imRm.c b
Fixed memory leak by adding Xfree and initializing missing_list with NULL
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imRmAttr.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions
Instead of copying the value returned by get_prop_name and then releasing it,
directly use the return value of get_prop_name, which allocates memory for the
name.
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
If _XkbGetReadBufferPtr returns NULL, goto BAILOUT
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xkb/XKBList.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/xkb/XKBList.c
are XBufferOverflow,
XLookupNone, XLookupChars, XLookupKeySym, and XLookupBoth. Each of
these has a specific meaning attached.
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imLcLkup.c |4
1 files
From: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
info_list-watch_data was being reallocated, but the return value of the
reallocation was stored only into a local variable. This might cause some funky
behavior and crashes.
Reviewed-by: Erkki Seppälä erkki.sepp
From: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Fixed by zero'ing conv on allocation. Then close_converter works properly.
Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi
Signed-off-by: Ander Conselvan de Oliveira
ander.conselvan-de-olive...@nokia.com
---
modules/lc
From: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
The rest of the code uses goto's to free memory allocated later
and prevent memory leaks, but there were several paths were
property_return was free'd just before a goto.
Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi
Removed superfluous check for NULL. name == NULL is already checked
at the function entry.
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xkb/XKBGAlloc.c |2 --
1 files changed, 0 insertions(+), 2
close_converter
Erkki Seppälä (26):
Using freed pointer e
Variable map goes out of scope
Using uninitialized value p-modifiers
Variable fs not freed or pointed-to in function get_prop_name
Pointer pBuf returned from fgets(buf, 256, stream) is never used
Pointer pBuf returned from fgets(buf, 256
Reordered code to first to do the comparison and then to release data
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/XlibInt.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git
Release modifiermap before returning
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imThaiFlt.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/modules/im/ximcp
Removed unused assignment
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xcms/cmsColNm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xcms/cmsColNm.c b/src/xcms
Smal fix by using calloc instead of Xmalloc
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/KeyBind.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/KeyBind.c b/src
Removed unused assignment
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xcms/cmsColNm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xcms/cmsColNm.c b/src/xcms
Fixed memory leak by adding Xfree
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
modules/im/ximcp/imRmAttr.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/modules/im/ximcp
Zero-initialized new
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com
Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi
---
src/xlibi18n/lcGeneric.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xlibi18n/lcGeneric.c b/src/xlibi18n
1 - 100 of 129 matches
Mail list logo