[PATCH] mi/mibitblt: Fix an overflow bug of bit shift.

2012-01-03 Thread zhigang . gong
From: Zhigang Gong When depth equal to 32 and planeMask equal to 0, the overflow will occur and cause the pixmap can't be cleared. There are some test cases in XTS hit this bug, and this fix can eliminate the corresponding failures. Signed-off-by: Zhigang Gong --- mi/mibitblt.c |2

RE: [PATCH] glx: Update the dispatch table according to mesa version.

2012-02-08 Thread Zhigang Gong
wed-by: Adam Jackson > Confirmed, this patch indeed a duplicate of the above one. I forgot to pull latest Xorg on my local tree. Please ignore this patch. Thanks. > On Feb 7, 2012, at 10:44 PM, zhigang.g...@linux.intel.com wrote: > > > From: Zhigang Gong > > > > The dispat

Question about xorg.conf.d's searching path

2012-03-27 Thread Zhigang Gong
Hi, I’m building xorg in a local directory $HOME/xorg, then all libraries will go to $HOME/xorg/lib, And all the configure files will go to $HOME/xorg/share/X11/xorg.conf.d/, such as the 10-evdev.conf. My question is, when I run this local Xorg it will not search the configure file at the

RE: Question about xorg.conf.d's searching path

2012-03-28 Thread Zhigang Gong
> -Original Message- > From: Dan Nicholson [mailto:dbn.li...@gmail.com] > Sent: Tuesday, March 27, 2012 9:11 PM > To: Zhigang Gong > Cc: alan.coopersm...@oracle.com; xorg-devel@lists.x.org > Subject: Re: Question about xorg.conf.d's searching path > > On

RE: [PATCH 00/54] extmod, again (and XAA)

2012-07-10 Thread Zhigang Gong
> -Original Message- > From: xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org > [mailto:xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org] On > Behalf Of Michel D?nzer > Sent: Tuesday, July 10, 2012 4:30 PM > To: Keith Packard > Cc: xorg-devel@lists.x.org; Daniel Stone;

RE: [PATCH 00/54] extmod, again (and XAA)

2012-07-11 Thread Zhigang Gong
> -Original Message- > From: xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org > [mailto:xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org] On > Behalf Of Michel D?nzer > Sent: Tuesday, July 10, 2012 6:49 PM > To: Zhigang Gong > Cc: xorg-devel@lists

[Patch] glamor: Don't build glamor egl/gbm related code if GLAMOR_DDX disabled

2011-09-27 Thread zhigang gong
. Thanks. The patch is starting as below: For Xephyr-glamor, we don't need to enable GLAMOR_DDX and don't need those egl/gbm interfaces. So we don't check the gbm and egl for that case, but we still build the corresponding code. Now fix it. Signed-off-by: Zhigang Gong --- hw/xfre

Re: [Pull Request] Glamor: A 2D rendering acceleration implementation based on OpenGL

2011-09-27 Thread zhigang gong
On Wed, Sep 28, 2011 at 1:41 AM, Alon Levy wrote: > On Tue, Sep 27, 2011 at 09:50:06PM +0800, zhigang gong wrote: >> Hi Keith, >> >> Here is the pull request to merge glamor. Basically, it has three parts. >> The first part is the 2D rendering acceleration implementa

Re: [Pull Request] Glamor: A 2D rendering acceleration implementation based on OpenGL

2011-09-28 Thread zhigang gong
2011/9/28 Michel Dänzer : > On Die, 2011-09-27 at 21:50 +0800, zhigang gong wrote: >> >> 3. Only support Intel platform currently. >> As glamor depends on KMS + MESA/EGL + GBM, currently only >> intel gfx device get supported. > > A Gallium based EGL driver (e.g.

[PATCH] GLAMOR: Fix the coding style problem

2011-10-01 Thread zhigang gong
Alan, According to your previous comments, I fixed those indentation and coding style problems except the camelCase function naming rule. Will do that soon after this patch get reviewed and committed. As the patch is too big to attach in this mail, I created a new branch to track it. Please check

RE: [Pull v2] Glamor - fixed build failure, fixed coding style problem.

2011-10-18 Thread Zhigang Gong
> -Original Message- > From: Jeremy Huddleston [mailto:jerem...@apple.com] > Sent: Tuesday, October 18, 2011 3:56 PM > To: Zhigang Gong > Cc: 'Keith Packard'; xorg-devel@lists.x.org > Subject: Re: [Pull v2] Glamor - fixed build failure, fixed coding style >

[PATCH] glamor-dix: Add two new lines to increase readability.

2011-10-19 Thread Zhigang Gong
Jeremy, Please help to review the following patch which is to address the spacing problem in Latest glamor code. Thanks. Signed-off-by: Zhigang Gong --- hw/xfree86/dixmods/Makefile.am |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/dixmods/Makefile.am b/hw

RE: [Pull v2] Glamor - fixed build failure, fixed coding style problem.

2011-10-19 Thread Zhigang Gong
> -Original Message- > From: xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org > [mailto:xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org] On > Behalf Of Jeremy Huddleston > Sent: Wednesday, October 19, 2011 12:09 AM > To: Zhigang Gong > Cc: x

Glamor - next step

2011-10-20 Thread Zhigang Gong
, 2011 11:32 PM > To: Jamey Sharp; Zhigang Gong; Jeremy Huddleston > Cc: xorg-devel@lists.x.org > Subject: Re: [Pull v2] Glamor - fixed build failure, fixed coding style > problem. > > On Thu, 20 Oct 2011 09:54:29 +0200, Jamey Sharp > wrote: > Non-text part: multipart/mixe

Glamor update

2011-11-11 Thread Zhigang Gong
Hi folks, During the last discussion about glamor’s plan in this list, we got a conclusion that to extract glamor from xorg and build a separate glamor library to be used by any possible DDX driver. And Eric suggested I can incrementally merge glamor into Intel video driver. Now here is the

RE: Glamor update

2011-11-13 Thread Zhigang Gong
> -Original Message- > From: Jamey Sharp [mailto:ja...@minilop.net] > Sent: Saturday, November 12, 2011 5:47 AM > To: Zhigang Gong > Cc: xorg-devel@lists.x.org; intel-...@lists.freedesktop.org > Subject: Re: Glamor update > > Hello! > > On Fri, Nov 11, 201

Re: [PATCH 1/3] glamor: Always destroy EGL image associated with destroyed pixmap

2014-12-09 Thread Zhigang Gong
need to make sure of that before we call into that function. Alternative is to do that check in glamor_egl_destroy_pixmap_image. The other part of this patch LGTM. Reviewed-by: Zhigang Gong Thanks, Zhigang Gong. ___ xorg-devel@lists.x.org: X.Org developme

Re: [PATCH 2/3] glamor: Remove redundant reference to screen pixmap EGL image

2014-12-09 Thread Zhigang Gong
Right, since the egl image has been moved to the normal pixmap_priv structure, we no longer need to do this type of redundant things. The patch LGTM, thanks. Revewied-by: Zhigang Gong Thanks, Zhigang Gong. On Mon, Dec 08, 2014 at 01:38:44PM -0800, Keith Packard wrote: > There's no r

Re: [PATCH 3/3] glamor: Free existing EGL image when assigning new one

2014-12-09 Thread Zhigang Gong
This patch LGTM, thanks. Reviewed-by: Zhigang Gong On Mon, Dec 08, 2014 at 01:38:45PM -0800, Keith Packard wrote: > When reallocating the framebuffer on screen resize, the old EGL image > was getting leaked. Check for an existing EGL image and free it in > this case. > > Signe

RE: glamor-egl, parameter checking

2013-09-26 Thread Zhigang Gong
Thanks for reporting these issues. I will investigate them after I back from holiday, say after 8/10. -Original Message- From: xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org [mailto:xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org] On Behalf Of Seth Arnold Sent: Thu

Re: glamor-egl, parameter checking

2013-10-08 Thread Zhigang Gong
On Wed, Sep 25, 2013 at 06:29:07PM -0700, Seth Arnold wrote: > Hello, I recently gave glamor-egl a very quick audit, and found some > issues that I wanted to run past someone who would know the code better > than I do. > > - _glamor_poly_lines(): > - unchecked malloc() return value > - if n =

RE: glamor: Changes to 'master'

2013-10-08 Thread Zhigang Gong
p.org Subject: Re: glamor: Changes to 'master' On Thu, 2013-09-26 at 14:28 -0700, Zhigang Gong wrote: > commit 0bf74791b93cd6a96ef0ba95c0e17bcf9aba5834 > Author: Zhigang Gong > Date: Fri Sep 27 05:25:54 2013 +0800 > > Shoud return null subpixmap if we f

Re: glamor cleanup series: reindent and connect to the build

2014-01-10 Thread Zhigang Gong
The whole series LGTM. Reviewed-by: Zhigang Gong BTW, I'm more than happy to see glamor is going to be merged into Xserver eventually :).Thanks. There is still a separate glamor mail list and I remember there should be one patchset pending to be merged, the subject is "[Glamor] [PA

RE: [PATCH 0/4] fb support for 8bpp bitmaps

2014-01-15 Thread Zhigang Gong
> -Original Message- > From: xorg-devel-boun...@lists.x.org [mailto:xorg-devel-boun...@lists.x.org] > On Behalf Of Keith Packard > Sent: Thursday, January 16, 2014 1:43 AM > To: Eric Anholt; Michel Dänzer > Cc: xorg-de...@lists.freedesktop.org > Subject: Re: [PATCH 0/4] fb support for 8bpp

RE: [PATCH] glamor: Disable definitions of GL extension prototypes to avoid warnings.

2014-01-26 Thread Zhigang Gong
LGTM,thanks. Reviewed-by: Zhigang Gong > -Original Message- > From: xorg-devel-boun...@lists.x.org [mailto:xorg-devel-boun...@lists.x.org] > On Behalf Of Eric Anholt > Sent: Saturday, January 25, 2014 3:01 AM > To: xorg-de...@lists.freedesktop.org > Subject: [PATC

Re: [PATCH 02/13] glamor: Add glamor_program based copy acceleration

2014-05-08 Thread Zhigang Gong
On Thu, May 08, 2014 at 12:02:50PM -0700, Eric Anholt wrote: > Keith Packard writes: > > > Michel Dänzer writes: > > > >> On 06.05.2014 07:02, Keith Packard wrote: > >>> > >>> +static Bool > >>> +glamor_copy_gl(DrawablePtr src, > >>> + DrawablePtr dst, > >>> + GCPtr

RE: [Glamor] glamor with xserver > 1.12

2013-03-18 Thread Zhigang Gong
> -Original Message- > From: > glamor-bounces+zhigang.gong=linux.intel@lists.freedesktop.org > [mailto:glamor-bounces+zhigang.gong=linux.intel.com@lists.freedesktop.o > rg] On Behalf Of Chris Wilson > Sent: Tuesday, March 12, 2013 7:05 PM > To: Michel Dänzer > Cc: Alex B; xorg-devel@lis

Re: [Glamor] glamor with xserver > 1.12

2013-03-18 Thread zhigang gong
7;s. On Mon, Mar 18, 2013 at 4:48 PM, Michel Dänzer wrote: > On Mon, 2013-03-18 at 16:40 +0800, Zhigang Gong wrote: > > > -Original Message- > > > From: > > > glamor-bounces+zhigang.gong=linux.intel@lists.freedesktop.org > > > [mailto:glamor-

RE: [Glamor] glamor with xserver > 1.12

2013-03-18 Thread Zhigang Gong
. From: xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org [mailto:xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org] On Behalf Of zhigang gong Sent: Monday, March 18, 2013 5:12 PM To: Michel Dänzer Cc: Alex B; Zhigang Gong; xorg-devel@lists.x.org; He, Junyan; gla

RE: [Glamor] glamor with xserver > 1.12

2013-03-19 Thread Zhigang Gong
+zhigang.gong=linux.intel@lists.freedesktop.org [mailto:glamor-bounces+zhigang.gong=linux.intel@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Tuesday, March 19, 2013 11:32 AM To: He, Junyan; 'Michel Dänzer' Cc: 'Alex B'; xorg-devel@lists.x.org; gla...@lists.freedes