[
https://issues.apache.org/jira/browse/YARN-6445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981635#comment-15981635
]
Wangda Tan commented on YARN-6445:
--
Latest patch looks good to me, +1. Thanks [~vvasudev] and reviews from
[
https://issues.apache.org/jira/browse/YARN-6445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978395#comment-15978395
]
Sunil G commented on YARN-6445:
---
Latest patch looks good for me. Jenkins failure is due to UI and we can skip
[
https://issues.apache.org/jira/browse/YARN-6445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976536#comment-15976536
]
Hadoop QA commented on YARN-6445:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974367#comment-15974367
]
Sunil G commented on YARN-6445:
---
Thanks [~vvasudev]
Generally changes are fine. Few more nits.
# In
[
https://issues.apache.org/jira/browse/YARN-6445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967407#comment-15967407
]
Hadoop QA commented on YARN-6445:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963457#comment-15963457
]
Daniel Templeton commented on YARN-6445:
Thanks for the patch, [~vvasudev]. A few comments:
*
[
https://issues.apache.org/jira/browse/YARN-6445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962716#comment-15962716
]
Hadoop QA commented on YARN-6445:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957705#comment-15957705
]
Hadoop QA commented on YARN-6445:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||