Re: [OpenJDK 2D-Dev] JDK-8048782, which is designated for u222, fixes a bug, but it also introduces a new one.

2019-05-30 Thread Hohensee, Paul
I filed https://bugs.openjdk.java.net/browse/JDK-8225065 to revert 
https://bugs.openjdk.java.net/browse/JDK-8221166. Separate review request email 
forthcoming.

Thanks,

Paul

On 5/29/19, 9:53 AM, "Andrew John Hughes"  wrote:

On 29/05/2019 17:45, Andrew Haley wrote:
> On 5/23/19 6:27 PM, Hohensee, Paul wrote:
>> Our current 8u222 solution would be to revert the patch for 
https://bugs.openjdk.java.net/browse/JDK-8221166 (which is the 8u222 backport 
issue for https://bugs.openjdk.java.net/browse/JDK-8048782).
> 
> Fine by me. Please open a bug and create a webrev which reverts the patch,
> and mark it jdk8u-critical-request.
> 

jdk8u-fix-request is fine if done before next Wednesday, the 5th of
June, when we enter rampdown.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew





Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

2019-05-30 Thread Phil Race




On 5/29/19 11:18 PM, Jayathirth D V wrote:

Hi,

I was also looking into this test case under 
https://bugs.openjdk.java.net/browse/JDK-8224969 I will close it as duplicate 
of this bug.
I saw that in case of Ubuntu and Mac we are throwing 
"java.awt.print.PrinterException: No print service found. " but I in case of 
Windows test just timesout.

Since there was difference in behavior between different platforms I created 
product bug : https://bugs.openjdk.java.net/browse/JDK-8224961 . If difference 
in behavior is expected then we can close this issue.
Maybe keep it open until we can close out the conversation on this with 
an evaluation.



Changes of adding @key printer under JDK-8225007 looks good to me.


Ok

-phil.



Thanks,
Jay

-Original Message-
From: Sergey Bylokhov
Sent: Thursday, May 30, 2019 7:07 AM
To: Philip Race
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR: 8225007: 
java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

On 29/05/2019 18:06, Philip Race wrote:

This test does not check. Nor does (IIRC) the implementation,

[1] I guess it is checked in the RasterPrintJob.print() where the code call the 
getPrintService(). And getPrintService() returns null if there are no printers installed, as a 
result "new PrinterException("No print service found.") is thrown.

I checked this test on win10 w/o printers installed and it pass but throw the 
next exception to the log[1]. But if I tries to print from the notepad it 
really suggest to install the printer.


because you want an experience like what you would get if you tried to
print from notepad, word, IE, whatever.
Which was to prompt you to install a printer if there is none.
That was the idea "back in the day" and is what happened on XP for
sure.>>  - When the test is executed the printer promts the location
to where store the pdf file(probably this location can be set to some
default and we will able to test printing as well at someday)

Even on a system with physical printers configured, if a pdf printer
is the default you could get prompted, but there is no API that I know of that 
can tell you this.

I guess we need to documents this, since such "additional" windows from 
printers/onenotes etc may affect other tests.


-phil

BTW this windows system was s slow so I was not able to move the mouse to 
select the file location, and have to reboot it


-Phil.


On May 29, 2019, at 3:40 PM, Phil Race  wrote:

If you try to print when there is no printer the behavior is not strictly 
specified.

-Phil.


On May 29, 2019, at 3:25 PM, Sergey Bylokhov  wrote:

On 29/05/2019 15:16, Philip Race wrote:
It doesn't hang there. It hangs in print().

I guess it is even more strange, it hangs when tries to print to non-existent printer. I guess in 
this case the "new PrinterException("No print service found.")" should be 
thrown. It looks like a bug, no?


-phil.

On 5/29/19, 3:17 PM, Sergey Bylokhov wrote:
On 29/05/2019 14:09, Phil Race wrote:
think the mystery is not why it times out now, but why it did not do so earlier.

But I assume it if the system does not have the printer then 
PrinterJob.getPrinterJob() should not hang?
It looks like the test correctly assume that .getPrinterJob() should returns 
something even if there are no printers, and also tries to catch any exceptions 
in the print(); I guess its expectation are according the specification, isn't?



--
Best regards, Sergey.




--
Best regards, Sergey.




Re: [OpenJDK 2D-Dev] [13] RFR JDK-8224824:ProblemList java/awt/Color/AlphaColorTest failure in linux_x64

2019-05-30 Thread Jayathirth D V
Changes are fine.

Thanks,
Jay

-Original Message-
From: Prasanta Sadhukhan 
Sent: Monday, May 27, 2019 3:03 PM
To: 2d-dev
Subject: [OpenJDK 2D-Dev] [13] RFR JDK-8224824:ProblemList 
java/awt/Color/AlphaColorTest failure in linux_x64

Hi All,

AlphaColorTest is failing in mach5 linux headful nightly system consistently 
and it seems to be a product bug, so needs to be problemlisted.

diff -r cb2628a4f33f test/jdk/ProblemList.txt
--- a/test/jdk/ProblemList.txt  Wed May 15 15:17:24 2019 +0530
+++ b/test/jdk/ProblemList.txt  Mon May 27 15:02:28 2019 +0530
@@ -114,6 +114,7 @@

  # jdk_awt

+java/awt/Color/AlphaColorTest.java 8224825 linux-all
  java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.java 8168389 
windows-all,macosx-all
  java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java 
8168408 windows-all,macosx-all
  java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java
8081489 generic-all

Regards
Prasanta