[OpenJDK 2D-Dev] RFR: 8196181 sun/java2d/GdiRendering/InsetClipping.java fails

2020-04-13 Thread Sergey Bylokhov

Hello.
Please review the fix for jdk/client.

Bug: https://bugs.openjdk.java.net/browse/JDK-8196181
Fix: http://cr.openjdk.java.net/~serb/8196181/webrev.01

The test tries to take a color of the pixel near the frame's insets,
exactly after the frame's decoration. The problem is that we cannot
report the size of the insets if decoration has a fractional size in
the user's space.
(if the size is 7 pixels and scale 2 we may report 3 or 4, both are inaccurate)

As a fix, I suggest checking another pixel which also can be used to
verify initial bug JDK-4873505(JDK 1.4.2).


--
Best regards, Sergey.


[OpenJDK 2D-Dev] [15] RFR JDK-8195841: PNGImageReader.readNullTerminatedString() doesnt check for non-null terminated strings with length equal to maxLen

2020-04-13 Thread Jayathirth D v
Hello All,

Please review the following fix for JDK 15:

Bug : https://bugs.openjdk.java.net/browse/JDK-8195841 

Webrev : http://cr.openjdk.java.net/~jdv/8195841/ 
 

Issue : PNGImageReader doesn’t check null terminated string for keyword when 
its length is maximum length
Solution : After we are done with reading the keyword stream make sure that 
last byte read is NUL.

Thanks,
Jay