Re: [OpenJDK 2D-Dev] RFR: 8273375: Remove redundant 'new String' calls after concatenation in java.desktop
On Fri, 3 Sep 2021 07:53:21 GMT, Andrey Turbanov wrote: > Result of string concatenation is a newly created `String` object. There is > no need it wrap it in another `new String` call. > Such calls are confusing and produce warnings in IDE. Without them code is > easier to read. Link this PR to bug in JBS. Otherwise change looks fine. - PR: https://git.openjdk.java.net/jdk/pull/5356
[OpenJDK 2D-Dev] RFR: 8273375: Remove redundant 'new String' calls after concatenation in java.desktop
Result of string concatenation is a newly created `String` object. There is no need it wrap it in another `new String` call. Such calls are confusing and produce warnings in IDE. Without them code is easier to read. - Commit messages: - [PATCH] Remove redundant 'new String' calls after concatenation in java.desktop Changes: https://git.openjdk.java.net/jdk/pull/5356/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5356=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273375 Stats: 91 lines in 15 files changed: 8 ins; 2 del; 81 mod Patch: https://git.openjdk.java.net/jdk/pull/5356.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5356/head:pull/5356 PR: https://git.openjdk.java.net/jdk/pull/5356
[OpenJDK 2D-Dev] Integrated: 8272878: JEP 381 cleanup: Remove unused Solaris code in sun.font.TrueTypeGlyphMapper
On Mon, 23 Aug 2021 22:05:13 GMT, Daniel Gredler wrote: > During the recent JEP 381 removal of Solaris code, a few Solaris-specific > constants and private methods were left behind in > sun.font.TrueTypeGlyphMapper. This PR removes these unused odds and ends. This pull request has now been integrated. Changeset: 70ed6c5b Author:Daniel Gredler Committer: Jayathirth D V URL: https://git.openjdk.java.net/jdk/commit/70ed6c5b8c52dc1c1c25967a09164a013bdb4bdd Stats: 17 lines in 1 file changed: 0 ins; 17 del; 0 mod 8272878: JEP 381 cleanup: Remove unused Solaris code in sun.font.TrueTypeGlyphMapper Reviewed-by: prr, jdv - PR: https://git.openjdk.java.net/jdk/pull/5232
