Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file
Hi,
I've just downported the fix for JDK-8212116 to 11u. A downport to
11.0.2 has been requested as well by adding the
("CPU19_01-critical-request") label to the JBS issue but it is beyond
my powers if this will be approved.
Regards,
Volker
On Thu, Dec 6, 2018 at 4:40 PM Philip Race wrote:
>
> There are often cases where a bug is "critical" to one person but
> inconsequential to almost everyone else.
> That is one of the top reasons people purchase a support contract for
> software ..
> Also, the only place we can push it (if we were allowed) is to the Oracle JDK
> LTS .. it won't appear
> in the open sources. You won't see any more Oracle fixes going into 11u.
> So if you want this fix in 11u your choices are
> 1) A support contract with Oracle or someone else offering the same level of
> support
> 2) Build your own JDK and ship it with the fix, making sure your customers
> understand
> that what you are giving them is your build .. and isn't up to date with
> Oracle 11u.
>
> -phil.
>
> On 12/6/18, 2:02 AM, Jan Vomlel wrote:
>
> Yes, but it is from my point of view critical bug (java 10 readed png files
> and java 11 many o them not). And java 12 is not released yet.
>
> Please consider this.
>
> Jan
>
> Dne 05.12.2018 v 16:38 Philip Race napsal(a):
>
> OpenJDK has no LTS releases. That's an Oracle JDK thing for which you need a
> support contract ..
> If you use free OpenJDK you can only use the latest.
> Others might provide an LTS but they aren't likely to include random
> backports on demand either .
>
> -phil.
>
> On 12/5/18, 2:53 AM, Jan Vomlel wrote:
>
> Thank you Jayathirth for bug resolution.
>
> I think it is ok, but can you fix it also in version 11? It is LTS version
> and we would like to use it for our project.
>
> Jan
>
>
Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file"
[Resending, because my first mail to2d-dev was blocked with "550 Denied by policy"] Hi Phil, I've increased the priority of the issue to P2, because it is a serious regression which breaks many applications. And I've requested a backport to 11u as described in the OpenJDK Updates Project push approval process document [1]. And you're totally right - people must finally understand the difference between Oracle- and OpenJDK and why it is so important to have downstream distributions like https://sapmachine.io . We will definitely put this fix into our 11.0.2 release :) Regards, Volker [1] http://openjdk.java.net/projects/jdk-updates/approval.html On Fri, Dec 7, 2018 at 8:45 AM Philip Race wrote: > > Hi, > > I am sympathetic to those who are affected, but all these questions are > putting us in an impossible position > since you are asking the wrong people. The development engineers are not > the 11u maintainers. > Someone who is in a position to sponsor the change needs to ask the 11u > maintainers if they will accept a request > So I cannot do that on your behalf. If they say yes, then that someone > who asked then needs to fix it. > > But 11.0.2 is baked. So I don't want to get your hopes up for that. > > And not that it applies to contributors such as you, I need to point out > so others understand that these email > lists are for people creating fixes for the main jdk development line, > and not any kind of support channel. > We love getting bug reports, and even better, contributed fixes, but it > is all for the main development line, not for older trains. > > -phil. > > On 12/6/18, 10:55 PM, Lindenmaier, Goetz wrote: > > Hi, > > > > This really seems to be a severe issue. > > We have people going from 8 to 11 and immediately reporting > > this issue. So this really is a blocker for them to use 11. > > So it should go to 11.0.2!! > > > > And 11 for sure will be supported in the open for further > > releases. > > > > Best regards, > >Goetz. > > > > > > > >> -----Original Message- > >> From: Baesken, Matthias > >> Sent: Thursday, December 6, 2018 1:18 PM > >> To: 2d-dev@openjdk.java.net > >> Cc: Lindenmaier, Goetz > >> Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt > >> chunk length is not proper" on opening png file" > >> > >> Hello , it is important to have the fix in Open JDK 11 as well . > >> > >> My colleague Goetz already commented : > >> > >> https://bugs.openjdk.java.net/browse/JDK-8212116 > >> > >>> Today one of our application teams going to Java 11 ran into this issue. > >>> Could this still be brought to 11.0.2? > >>> Else I would request a downport to jdk-updates/jdk11u, which would only > >> reach 11.0.3. > >> We support bringing it into 11 . > >> > >> > >> Thanks, Matthias > >> > >> -- > >> > >> Message: 1 > >> Date: Thu, 6 Dec 2018 11:02:11 +0100 > >> From: Jan Vomlel > >> To: 2d-dev@openjdk.java.net > >> Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt > >> chunk length is not proper" on opening png file > >> Message-ID:<436ea89f-d18d-49df-88db-4b3829061...@gmail.com> > >> Content-Type: text/plain; charset="iso-8859-2"; Format="flowed" > >> > >> Yes, but it is from my point of view critical bug (java 10 readed png > >> files and java 11 many o them not). And java 12 is not released yet. > >> > >> Please consider this. > >> > >> Jan > >> > >> Dne 05.12.2018 v 16:38 Philip Race napsal(a): > >>> OpenJDK has no LTS releases. That's an Oracle JDK thing for which you > >>> need a support contract .. > >>> If you use free OpenJDK you can only use the latest. > >>> Others might provide an LTS but they aren't likely to include random > >>> backports on demand either . > >>> > >>> -phil. > >>> > >>> On 12/5/18, 2:53 AM, Jan Vomlel wrote: > >>>> Thank you Jayathirth for bug resolution. > >>>> > >>>> I think it is ok, but can you fix it also in version 11? It is LTS > >>>> version and we would like to use it for our project. > >>>> > >>>> Jan > >>>> > >>
Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file"
Hi, I am sympathetic to those who are affected, but all these questions are putting us in an impossible position since you are asking the wrong people. The development engineers are not the 11u maintainers. Someone who is in a position to sponsor the change needs to ask the 11u maintainers if they will accept a request So I cannot do that on your behalf. If they say yes, then that someone who asked then needs to fix it. But 11.0.2 is baked. So I don't want to get your hopes up for that. And not that it applies to contributors such as you, I need to point out so others understand that these email lists are for people creating fixes for the main jdk development line, and not any kind of support channel. We love getting bug reports, and even better, contributed fixes, but it is all for the main development line, not for older trains. -phil. On 12/6/18, 10:55 PM, Lindenmaier, Goetz wrote: Hi, This really seems to be a severe issue. We have people going from 8 to 11 and immediately reporting this issue. So this really is a blocker for them to use 11. So it should go to 11.0.2!! And 11 for sure will be supported in the open for further releases. Best regards, Goetz. -Original Message- From: Baesken, Matthias Sent: Thursday, December 6, 2018 1:18 PM To: 2d-dev@openjdk.java.net Cc: Lindenmaier, Goetz Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file" Hello , it is important to have the fix in Open JDK 11 as well . My colleague Goetz already commented : https://bugs.openjdk.java.net/browse/JDK-8212116 Today one of our application teams going to Java 11 ran into this issue. Could this still be brought to 11.0.2? Else I would request a downport to jdk-updates/jdk11u, which would only reach 11.0.3. We support bringing it into 11 . Thanks, Matthias -- Message: 1 Date: Thu, 6 Dec 2018 11:02:11 +0100 From: Jan Vomlel To: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file Message-ID:<436ea89f-d18d-49df-88db-4b3829061...@gmail.com> Content-Type: text/plain; charset="iso-8859-2"; Format="flowed" Yes, but it is from my point of view critical bug (java 10 readed png files and java 11 many o them not). And java 12 is not released yet. Please consider this. Jan Dne 05.12.2018 v 16:38 Philip Race napsal(a): OpenJDK has no LTS releases. That's an Oracle JDK thing for which you need a support contract .. If you use free OpenJDK you can only use the latest. Others might provide an LTS but they aren't likely to include random backports on demand either . -phil. On 12/5/18, 2:53 AM, Jan Vomlel wrote: Thank you Jayathirth for bug resolution. I think it is ok, but can you fix it also in version 11? It is LTS version and we would like to use it for our project. Jan
Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file"
Hi, This really seems to be a severe issue. We have people going from 8 to 11 and immediately reporting this issue. So this really is a blocker for them to use 11. So it should go to 11.0.2!! And 11 for sure will be supported in the open for further releases. Best regards, Goetz. > -Original Message- > From: Baesken, Matthias > Sent: Thursday, December 6, 2018 1:18 PM > To: 2d-dev@openjdk.java.net > Cc: Lindenmaier, Goetz > Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt > chunk length is not proper" on opening png file" > > Hello , it is important to have the fix in Open JDK 11 as well . > > My colleague Goetz already commented : > > https://bugs.openjdk.java.net/browse/JDK-8212116 > > > > >Today one of our application teams going to Java 11 ran into this issue. > >Could this still be brought to 11.0.2? > >Else I would request a downport to jdk-updates/jdk11u, which would only > reach 11.0.3. > > > > We support bringing it into 11 . > > > Thanks, Matthias > > -- > > Message: 1 > Date: Thu, 6 Dec 2018 11:02:11 +0100 > From: Jan Vomlel > To: 2d-dev@openjdk.java.net > Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt > chunk length is not proper" on opening png file > Message-ID: <436ea89f-d18d-49df-88db-4b3829061...@gmail.com> > Content-Type: text/plain; charset="iso-8859-2"; Format="flowed" > > Yes, but it is from my point of view critical bug (java 10 readed png > files and java 11 many o them not). And java 12 is not released yet. > > Please consider this. > > Jan > > Dne 05.12.2018 v 16:38 Philip Race napsal(a): > > OpenJDK has no LTS releases. That's an Oracle JDK thing for which you > > need a support contract .. > > If you use free OpenJDK you can only use the latest. > > Others might provide an LTS but they aren't likely to include random > > backports on demand either . > > > > -phil. > > > > On 12/5/18, 2:53 AM, Jan Vomlel wrote: > >> > >> Thank you Jayathirth for bug resolution. > >> > >> I think it is ok, but can you fix it also in version 11? It is LTS > >> version and we would like to use it for our project. > >> > >> Jan > >> > >
Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file
There are often cases where a bug is "critical" to one person but inconsequential to almost everyone else. That is one of the top reasons people purchase a support contract for software .. Also, the only place we can push it (if we were allowed) is to the Oracle JDK LTS .. it won't appear in the open sources. You won't see any more Oracle fixes going into 11u. So if you want this fix in 11u your choices are 1) A support contract with Oracle or someone else offering the same level of support 2) Build your own JDK and ship it with the fix, making sure your customers understand that what you are giving them is your build .. and isn't up to date with Oracle 11u. -phil. On 12/6/18, 2:02 AM, Jan Vomlel wrote: Yes, but it is from my point of view critical bug (java 10 readed png files and java 11 many o them not). And java 12 is not released yet. Please consider this. Jan Dne 05.12.2018 v 16:38 Philip Race napsal(a): OpenJDK has no LTS releases. That's an Oracle JDK thing for which you need a support contract .. If you use free OpenJDK you can only use the latest. Others might provide an LTS but they aren't likely to include random backports on demand either . -phil. On 12/5/18, 2:53 AM, Jan Vomlel wrote: Thank you Jayathirth for bug resolution. I think it is ok, but can you fix it also in version 11? It is LTS version and we would like to use it for our project. Jan
Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file"
Hello , it is important to have the fix in Open JDK 11 as well .
My colleague Goetz already commented :
https://bugs.openjdk.java.net/browse/JDK-8212116
>
>Today one of our application teams going to Java 11 ran into this issue.
>Could this still be brought to 11.0.2?
>Else I would request a downport to jdk-updates/jdk11u, which would only reach
>11.0.3.
>
We support bringing it into 11 .
Thanks, Matthias
--
Message: 1
Date: Thu, 6 Dec 2018 11:02:11 +0100
From: Jan Vomlel
To: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt
chunk length is not proper" on opening png file
Message-ID: <436ea89f-d18d-49df-88db-4b3829061...@gmail.com>
Content-Type: text/plain; charset="iso-8859-2"; Format="flowed"
Yes, but it is from my point of view critical bug (java 10 readed png
files and java 11 many o them not). And java 12 is not released yet.
Please consider this.
Jan
Dne 05.12.2018 v 16:38 Philip Race napsal(a):
> OpenJDK has no LTS releases. That's an Oracle JDK thing for which you
> need a support contract ..
> If you use free OpenJDK you can only use the latest.
> Others might provide an LTS but they aren't likely to include random
> backports on demand either .
>
> -phil.
>
> On 12/5/18, 2:53 AM, Jan Vomlel wrote:
>>
>> Thank you Jayathirth for bug resolution.
>>
>> I think it is ok, but can you fix it also in version 11? It is LTS
>> version and we would like to use it for our project.
>>
>> Jan
>>
Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file
Yes, but it is from my point of view critical bug (java 10 readed png files and java 11 many o them not). And java 12 is not released yet. Please consider this. Jan Dne 05.12.2018 v 16:38 Philip Race napsal(a): OpenJDK has no LTS releases. That's an Oracle JDK thing for which you need a support contract .. If you use free OpenJDK you can only use the latest. Others might provide an LTS but they aren't likely to include random backports on demand either . -phil. On 12/5/18, 2:53 AM, Jan Vomlel wrote: Thank you Jayathirth for bug resolution. I think it is ok, but can you fix it also in version 11? It is LTS version and we would like to use it for our project. Jan
Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file
OpenJDK has no LTS releases. That's an Oracle JDK thing for which you need a support contract .. If you use free OpenJDK you can only use the latest. Others might provide an LTS but they aren't likely to include random backports on demand either . -phil. On 12/5/18, 2:53 AM, Jan Vomlel wrote: Thank you Jayathirth for bug resolution. I think it is ok, but can you fix it also in version 11? It is LTS version and we would like to use it for our project. Jan
Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file
Thank you Jayathirth for bug resolution. I think it is ok, but can you fix it also in version 11? It is LTS version and we would like to use it for our project. Jan
Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file
Looks fine. On 12/11/2018 20:22, Jayathirth D V wrote: Hello All, Gentle reminder for review. Thanks, Jay *From:* Jayathirth D V *Sent:* Tuesday, October 16, 2018 6:37 PM *To:* 2d-dev *Subject:* [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8212116 Webrev: http://cr.openjdk.java.net/~jdv/8212116/webrev.00/ Issue : When we try to read PNG image with no text in tEXt chunk we throw IIOException. Root cause : While fixing JDK-8191023 <https://bugs.openjdk.java.net/browse/JDK-8191023> we added tighter condition for chunk length in text chunks and we throw IIOException even when text length is 0. But text chunks can contain null text with just keyword and other data according to PNG spec. Solution : Allow text chunks with text length 0 in tEXt chunk. As part of this fix I have made changes to zTXt and iTXt chunk also as we will have same problem there also. In JDK-8191023 <https://bugs.openjdk.java.net/browse/JDK-8191023> we added tighter checks for iCCP and sPLT chunk also, but in these chunks we should not allow them to have null compressed profile or null palette. So no changes are made in iCCP & sPLT parse functions. Thanks, Jay -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file
Hello All, Gentle reminder for review. Thanks, Jay From: Jayathirth D V Sent: Tuesday, October 16, 2018 6:37 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8212116 Webrev: http://cr.openjdk.java.net/~jdv/8212116/webrev.00/ Issue : When we try to read PNG image with no text in tEXt chunk we throw IIOException. Root cause : While fixing HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8191023"JDK-8191023 we added tighter condition for chunk length in text chunks and we throw IIOException even when text length is 0. But text chunks can contain null text with just keyword and other data according to PNG spec. Solution : Allow text chunks with text length 0 in tEXt chunk. As part of this fix I have made changes to zTXt and iTXt chunk also as we will have same problem there also. In HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8191023"JDK-8191023 we added tighter checks for iCCP and sPLT chunk also, but in these chunks we should not allow them to have null compressed profile or null palette. So no changes are made in iCCP & sPLT parse functions. Thanks, Jay
[OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file
Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8212116 Webrev: http://cr.openjdk.java.net/~jdv/8212116/webrev.00/ Issue : When we try to read PNG image with no text in tEXt chunk we throw IIOException. Root cause : While fixing HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8191023"JDK-8191023 we added tighter condition for chunk length in text chunks and we throw IIOException even when text length is 0. But text chunks can contain null text with just keyword and other data according to PNG spec. Solution : Allow text chunks with text length 0 in tEXt chunk. As part of this fix I have made changes to zTXt and iTXt chunk also as we will have same problem there also. In HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8191023"JDK-8191023 we added tighter checks for iCCP and sPLT chunk also, but in these chunks we should not allow them to have null compressed profile or null palette. So no changes are made in iCCP & sPLT parse functions. Thanks, Jay
