Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL [v2]
On Mon, 28 Jun 2021 22:45:12 GMT, Sergey Bylokhov wrote:
>> Alexey Ushakov has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/CWrapper.m line 349:
>
>> 347: if ([window.contentView.layer isKindOfClass:[CAMetalLayer
>> class]]) {
>> 348: [window.contentView.layer setOpaque:(BOOL)opaque];
>> 349: }
>
> This class "CWrapper" is intended to be a simple wrapper on top of cocoa
> methods, the changed method above is expected to call the
> "NSWindow#setOpaque" only. So you need to place "window.contentView.layer
> setOpaque" in some other place(native or java).
Done
-
PR: https://git.openjdk.java.net/jdk17/pull/62
Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL [v2]
On Wed, 23 Jun 2021 12:15:03 GMT, Alexey Ushakov wrote: >> Implemented blit via compute kernel > > Alexey Ushakov has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of the PR. The pull request contains one new > commit since the last revision: > > 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL > > Keep MTLLayer opacity in sync with window content view All test run is green with latest commit. - PR: https://git.openjdk.java.net/jdk17/pull/62
Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL [v2]
On Wed, 23 Jun 2021 12:15:03 GMT, Alexey Ushakov wrote:
>> Implemented blit via compute kernel
>
> Alexey Ushakov has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous content of the PR. The pull request contains one new
> commit since the last revision:
>
> 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL
>
> Keep MTLLayer opacity in sync with window content view
src/java.desktop/macosx/native/libawt_lwawt/awt/CWrapper.m line 349:
> 347: if ([window.contentView.layer isKindOfClass:[CAMetalLayer
> class]]) {
> 348: [window.contentView.layer setOpaque:(BOOL)opaque];
> 349: }
This class "CWrapper" is intended to be a simple wrapper on top of cocoa
methods, the changed method above is expected to call the "NSWindow#setOpaque"
only. So you need to place "window.contentView.layer setOpaque" in some other
place(native or java).
-
PR: https://git.openjdk.java.net/jdk17/pull/62
Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL [v2]
> Implemented blit via compute kernel Alexey Ushakov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL Keep MTLLayer opacity in sync with window content view - Changes: - all: https://git.openjdk.java.net/jdk17/pull/62/files - new: https://git.openjdk.java.net/jdk17/pull/62/files/4d1b80ff..3eef431e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17=62=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17=62=00-01 Stats: 56 lines in 4 files changed: 4 ins; 50 del; 2 mod Patch: https://git.openjdk.java.net/jdk17/pull/62.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/62/head:pull/62 PR: https://git.openjdk.java.net/jdk17/pull/62
