Re: [OpenJDK 2D-Dev] RFR: 8219578 No associated icon for the leaf node of Jtree
Change looks good to me. Thanks, Jay -Original Message- From: Philip Race Sent: Thursday, March 5, 2020 7:26 AM To: Sergey Bylokhov Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>; swing-...@openjdk.java.net Subject: Re: RFR: 8219578 No associated icon for the leaf node of Jtree OK. CSR is reviewed. -phil. On 3/4/20, 5:37 PM, Sergey Bylokhov wrote: > webrev and CSR are updated: > > Fix: http://cr.openjdk.java.net/~serb/8219578/webrev.01 > CSR: https://bugs.openjdk.java.net/browse/JDK-8240554 > > On 3/4/20 5:07 pm, Philip Race wrote: >> I suggest changing + * The documentation in this module includes >> links to overviews, tutorials, >> + * examples, guides, and other documentation. This is done for >> convenience. >> + * Information at these external resources is not part of JavaSE API >> + * Specification. >> >> to >> >> + * The documentation in this module includes links to external >> overviews, tutorials, >> + * examples, guides, media format specifications, and other similar >> documentation. >> + * These links are meant to be informative to the reader and nothing >> more. >> + * Information at these external resources, no matter the hosting or >> the author, + * is not part of Java Platform APIspecification unless >> explicitly stated to be so. I wouldn't be surprised if the CSR >> process generates some more tweaks. >> >> -phil. >> >> On 3/4/20, 4:51 PM, Sergey Bylokhov wrote: >>> Hello. >>> Please review the fix for jdk/client. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8219578 >>> CSR: https://bugs.openjdk.java.net/browse/JDK-8240554 >>> Fix: http://cr.openjdk.java.net/~serb/8219578/webrev.00 >>> >>> The fix clarifies the status of the links to external resources in >>> the documentation >>> > >
Re: [OpenJDK 2D-Dev] RFR: 8219578 No associated icon for the leaf node of Jtree
OK. CSR is reviewed. -phil. On 3/4/20, 5:37 PM, Sergey Bylokhov wrote: webrev and CSR are updated: Fix: http://cr.openjdk.java.net/~serb/8219578/webrev.01 CSR: https://bugs.openjdk.java.net/browse/JDK-8240554 On 3/4/20 5:07 pm, Philip Race wrote: I suggest changing + * The documentation in this module includes links to overviews, tutorials, + * examples, guides, and other documentation. This is done for convenience. + * Information at these external resources is not part of JavaSE API + * Specification. to + * The documentation in this module includes links to external overviews, tutorials, + * examples, guides, media format specifications, and other similar documentation. + * These links are meant to be informative to the reader and nothing more. + * Information at these external resources, no matter the hosting or the author, + * is not part of Java Platform APIspecification unless explicitly stated to be so. I wouldn't be surprised if the CSR process generates some more tweaks. -phil. On 3/4/20, 4:51 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8219578 CSR: https://bugs.openjdk.java.net/browse/JDK-8240554 Fix: http://cr.openjdk.java.net/~serb/8219578/webrev.00 The fix clarifies the status of the links to external resources in the documentation
Re: [OpenJDK 2D-Dev] RFR: 8219578 No associated icon for the leaf node of Jtree
webrev and CSR are updated: Fix: http://cr.openjdk.java.net/~serb/8219578/webrev.01 CSR: https://bugs.openjdk.java.net/browse/JDK-8240554 On 3/4/20 5:07 pm, Philip Race wrote: I suggest changing + * The documentation in this module includes links to overviews, tutorials, + * examples, guides, and other documentation. This is done for convenience. + * Information at these external resources is not part of JavaSE API + * Specification. to + * The documentation in this module includes links to external overviews, tutorials, + * examples, guides, media format specifications, and other similar documentation. + * These links are meant to be informative to the reader and nothing more. + * Information at these external resources, no matter the hosting or the author, + * is not part of Java Platform APIspecification unless explicitly stated to be so. I wouldn't be surprised if the CSR process generates some more tweaks. -phil. On 3/4/20, 4:51 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8219578 CSR: https://bugs.openjdk.java.net/browse/JDK-8240554 Fix: http://cr.openjdk.java.net/~serb/8219578/webrev.00 The fix clarifies the status of the links to external resources in the documentation -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] RFR: 8219578 No associated icon for the leaf node of Jtree
I suggest changing + * The documentation in this module includes links to overviews, tutorials, + * examples, guides, and other documentation. This is done for convenience. + * Information at these external resources is not part of JavaSE API + * Specification. to + * The documentation in this module includes links to external overviews, tutorials, + * examples, guides, media format specifications, and other similar documentation. + * These links are meant to be informative to the reader and nothing more. + * Information at these external resources, no matter the hosting or the author, + * is not part of Java Platform API specification unless explicitly stated to be so. I wouldn't be surprised if the CSR process generates some more tweaks. -phil. On 3/4/20, 4:51 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8219578 CSR: https://bugs.openjdk.java.net/browse/JDK-8240554 Fix: http://cr.openjdk.java.net/~serb/8219578/webrev.00 The fix clarifies the status of the links to external resources in the documentation
[OpenJDK 2D-Dev] RFR: 8219578 No associated icon for the leaf node of Jtree
Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8219578 CSR: https://bugs.openjdk.java.net/browse/JDK-8240554 Fix: http://cr.openjdk.java.net/~serb/8219578/webrev.00 The fix clarifies the status of the links to external resources in the documentation -- Best regards, Sergey.