Re: [OpenJDK 2D-Dev] RFR: 8252817: Cleanup the classes in the java.awt.color package

2020-09-09 Thread Pankaj Bansal
On Sat, 5 Sep 2020 21:32:42 GMT, Sergey Bylokhov  wrote:

> - Class declarations reformat
> - Docs cleanup

+1

-

Marked as reviewed by pbansal (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/22


Re: [OpenJDK 2D-Dev] RFR: 8252817: Cleanup the classes in the java.awt.color package

2020-09-08 Thread Jayathirth D V
On Sat, 5 Sep 2020 21:32:42 GMT, Sergey Bylokhov  wrote:

> - Class declarations reformat
> - Docs cleanup

Looks good to me.

-

Marked as reviewed by jdv (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/22


Re: [OpenJDK 2D-Dev] RFR: 8252817: Cleanup the classes in the java.awt.color package

2020-09-05 Thread Sergey Bylokhov
On Sat, 5 Sep 2020 21:32:42 GMT, Sergey Bylokhov  wrote:

> - Class declarations reformat
> - Docs cleanup

src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 148:

> 146:  */
> 147: public static final int icSigXYZData = 0x58595A20;
> 148:

Inline comment:
Looks like this type of documentation was used before we added javadoc for each 
constant.

-

PR: https://git.openjdk.java.net/jdk/pull/22