Re: [OpenJDK 2D-Dev] RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0
On Fri, 30 Apr 2021 20:07:53 GMT, Phil Race wrote: > Upgrade to harfbuzz 2.8 https://github.com/openjdk/jdk/pull/3873 - PR: https://git.openjdk.java.net/jdk/pull/3826
Re: [OpenJDK 2D-Dev] RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0
On Fri, 30 Apr 2021 20:07:53 GMT, Phil Race wrote: > Upgrade to harfbuzz 2.8 Same here. In my case it breaks with gcc 7.5.0, which I believe is still supported. I opened https://bugs.openjdk.java.net/browse/JDK-8266545. - PR: https://git.openjdk.java.net/jdk/pull/3826
Re: [OpenJDK 2D-Dev] RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0
On Mon, 3 May 2021 23:02:01 GMT, Phil Race wrote: >> I assume the build using bundled lib is fine on all our platforms. > >> I assume the build using bundled lib is fine on all our platforms. > > Yes. Hi @prrace , Our CI/CD got the following build errors on x86_64 with gcc 8.3.1: Building target 'images' in configuration 'linux-x86_64-server-fastdebug' Updating support/modules_libs/java.base/server/libjvm.so due to 1 file(s) In file included from /home/jvm/jdk/src/java.desktop/share/native/libharfbuzz/hb-ot-shape-complex-use.cc:33: hb-ot-shape-complex-use-machine.rl: In instantiation of 'machine_index_t::machine_index_t(const machine_index_t&) [with Iter = hb_zip_iter_t, hb_filter_iter_t, hb_array_t >, find_syllables_use(hb_buffer_t*)::, const&, 0>, find_syllables_use(hb_buffer_t*)::)>, const&, 0> >]': hb-ot-shape-complex-use-machine.rl:249:11: required from here hb-ot-shape-complex-use-machine.rl:194:9: error: base class 'struct hb_iter_with_fallback_t, hb_filter_iter_t, hb_array_t >, find_syllables_use(hb_buffer_t*)::, const&, 0>, find_syllables_use(hb_buffer_t*)::)>, const&, 0> > >, hb_pair_t > >' should be explicitly initialized in the copy constructor [-Werror=extra] cc1plus: all warnings being treated as errors gmake[3]: *** [/home/jvm/jdk/build/linux-x86_64-server-fastdebug/support/native/java.desktop/libfontmanager/hb-ot-shape-complex-use.o] Error 1 gmake[2]: *** [java.desktop-libs] Error 1 ERROR: Build failed for target 'images' in configuration 'linux-x86_64-server-fastdebug' (exit code 2) === Output from failing command(s) repeated here === * For target support_native_java.desktop_libfontmanager_hb-ot-shape-complex-use.o: In file included from /home/jvm/jdk/src/java.desktop/share/native/libharfbuzz/hb-ot-shape-complex-use.cc:33: hb-ot-shape-complex-use-machine.rl: In instantiation of 'machine_index_t::machine_index_t(const machine_index_t&) [with Iter = hb_zip_iter_t, hb_filter_iter_t, hb_array_t >, find_syllables_use(hb_buffer_t*)::, const&, 0>, find_syllables_use(hb_buffer_t*)::)>, const&, 0> >]': hb-ot-shape-complex-use-machine.rl:249:11: required from here hb-ot-shape-complex-use-machine.rl:194:9: error: base class 'struct hb_iter_with_fallback_t, hb_filter_iter_t, hb_array_t >, find_syllables_use(hb_buffer_t*)::, const&, 0>, find_syllables_use(hb_buffer_t*)::)>, const&, 0> > >, hb_pair_t > >' should be explicitly initialized in the copy constructor [-Werror=extra] cc1plus: all warnings being treated as errors * All command lines available in /home/jvm/jdk/build/linux-x86_64-server-fastdebug/make-support/failure-logs. Could you please have a look? I'm on a vacation this week. Thanks. - PR: https://git.openjdk.java.net/jdk/pull/3826
Re: [OpenJDK 2D-Dev] RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0
I built with gcc 10.3 https://bugs.openjdk.java.net/browse/JDK-8265373 I expect we can accommodate disabling one more warning to support more compilers. -phil. On 5/4/21 12:31 PM, Florian Weimer wrote: * Phil Race: Upgrade to harfbuzz 2.8 I believe this causes a build failure with GCC 8.3 (from Debian buster): * For target support_native_java.desktop_libfontmanager_hb-ot-shape-complex-use.o: In file included from …/jdk/src/java.desktop/share/native/libharfbuzz/hb-ot-shape-complex-use.cc:33: hb-ot-shape-complex-use-machine.rl: In instantiation of 'machine_index_t::machine_index_t(const machine_index_t&) [with Iter = hb_zip_iter_t, hb_filter_iter_t, hb_array_t >, find_syllables_use(hb_buffer_t*)::, const&, 0>, find_syllables_use(hb_buffer_t*)::)>, const&, 0> >]': hb-ot-shape-complex-use-machine.rl:249:11: required from here hb-ot-shape-complex-use-machine.rl:194:9: error: base class 'struct hb_iter_with_fallback_t, hb_filter_iter_t, hb_array_t >, find_syllables_use(hb_buffer_t*)::, const&, 0>, find_syllables_use(hb_buffer_t*)::)>, const&, 0> > >, hb_pair_t > >' should be explicitly initialized in the copy constructor [-Werror=extra] cc1plus: all warnings being treated as errors
Re: [OpenJDK 2D-Dev] RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0
* Phil Race: > Upgrade to harfbuzz 2.8 I believe this causes a build failure with GCC 8.3 (from Debian buster): * For target support_native_java.desktop_libfontmanager_hb-ot-shape-complex-use.o: In file included from …/jdk/src/java.desktop/share/native/libharfbuzz/hb-ot-shape-complex-use.cc:33: hb-ot-shape-complex-use-machine.rl: In instantiation of 'machine_index_t::machine_index_t(const machine_index_t&) [with Iter = hb_zip_iter_t, hb_filter_iter_t, hb_array_t >, find_syllables_use(hb_buffer_t*)::, const&, 0>, find_syllables_use(hb_buffer_t*)::)>, const&, 0> >]': hb-ot-shape-complex-use-machine.rl:249:11: required from here hb-ot-shape-complex-use-machine.rl:194:9: error: base class 'struct hb_iter_with_fallback_t, hb_filter_iter_t, hb_array_t >, find_syllables_use(hb_buffer_t*)::, const&, 0>, find_syllables_use(hb_buffer_t*)::)>, const&, 0> > >, hb_pair_t > >' should be explicitly initialized in the copy constructor [-Werror=extra] cc1plus: all warnings being treated as errors
Re: [OpenJDK 2D-Dev] RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0
On Sat, 1 May 2021 01:42:04 GMT, Sergey Bylokhov wrote: > I assume the build using bundled lib is fine on all our platforms. Yes. - PR: https://git.openjdk.java.net/jdk/pull/3826
Re: [OpenJDK 2D-Dev] RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0
On Fri, 30 Apr 2021 20:07:53 GMT, Phil Race wrote: > Upgrade to harfbuzz 2.8 I assume the build using bundled lib is fine on all our platforms. - Marked as reviewed by serb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3826
