Re: [OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]
On Thu, 4 Feb 2021 22:49:23 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>+ minor change of placements
>> - Use macro conditionals instead of empty functions
>> - Add W^X to tests
>> - Do not require known W^X state
>> - Revert w^x in gtests
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 297:
>
>> 295: stub = SharedRuntime::handle_unsafe_access(thread, next_pc);
>> 296: }
>> 297: } else if (sig == SIGILL && nativeInstruction_at(pc)->is_stop()) {
>
> Can we add a comment here describing what this case means?
This was added as part of this commit ( to linux_aarch64) -
https://github.com/openjdk/jdk/commit/339d52600b285eb3bc57d9ff107567d4424efeb1
@gerard-ziemski do we really want to add anything new here ?
-
PR: https://git.openjdk.java.net/jdk/pull/2200
[OpenJDK 2D-Dev] RFR: 8196301: java/awt/print/PrinterJob/Margins.java times out
This test was timing out in windows in mach5 nightly testing. Investigation reveals that 70% of the time, it is failing due to printer being chosen was Microsoft Print to PDF which opens up a File Save Dialog when "OK" was clicked in printer pagedialog. Since no user intervention is done to dismiss the modal filedialog, so subsequent pagedialog was not dismissed resulting in timeout. Other times, it was found that "One Note" software printer was used as default printerservice which again, opens up a OneNote app which again gets focus and obscure pagedialog so PageDialog did not get dismissed. Updated test to ignore "Print To PDF", "OneNote" and "XPS Document Writer"(which again opens filedialog like PDF printer) and run it for several iteration in mach5 platforms which is ok. Link in JBS. - Commit messages: - 8196301: java/awt/print/PrinterJob/Margins.java times out Changes: https://git.openjdk.java.net/jdk/pull/2598/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2598&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8196301 Stats: 59 lines in 3 files changed: 39 ins; 18 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2598.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2598/head:pull/2598 PR: https://git.openjdk.java.net/jdk/pull/2598
Re: [OpenJDK 2D-Dev] RFR: 6206189: Graphics2D.clip specifies incorrectly that a 'null' is a valid value for this method
On Mon, 15 Feb 2021 12:44:28 GMT, Prasanta Sadhukhan wrote: >> The API doc for Graphics2D.clip(shape s) claims that passing a null argument >> would actually clear the existing clipping area, which is incorrect. >> This statement is applicable only to G2D.setClip() and not for the clip() >> method. G2D.clip() would throw a NullPointerException when it encounters a >> null argument. >> Updated spec to rectify this. > > @prrace Can you please have a look at the CSR JDK-8261426? @mrserb @prrace @jayathirthrao @aivanov-jdk @azvegint Any more comments on this? If not, can this please be approved? - PR: https://git.openjdk.java.net/jdk/pull/2476
