[389-devel] Please review (take 2): [389 Project] #338: letters in object's cn get converted to lowercase when renaming object
https://fedorahosted.org/389/ticket/338 https://fedorahosted.org/389/attachment/ticket/338/0001-Trac-Ticket-338-letters-in-object-s-cn-get-converted.2.patch Fix description: The value of newrdn was normalized as dn then decapitalized. The decapitalization was not just needed but the cause of the reported bug. This patch removes the decapitalization call (slapi_dn_ignore_case) and adds slapi_dn_ignore_case to acl_access_allowed_modrdn (acl.c) and referint_postop_modrdn (referint/referint.c). Additionally, unnecessary code is being removed from chaining_ back_modrdn (chainingdb/cb_modrdn.c). -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel
[389-devel] Please review: [389 Project] #310: Avoid calling escape_string() for logged DNs
https://fedorahosted.org/389/ticket/310 https://fedorahosted.org/389/attachment/ticket/310/0001-Trac-Ticket-310-Avoid-calling-escape_string-for-logg.patch Fix description: removed unnecessary escape_string calls and the static buffer used by escape_string. Ran slamd repeatedly (BIND+SEARCH+UNBIND from 4 threads in 10 min.), but I could not get the good evidence that No escape_string improves the performance. Please note that the bind dn contains ascii characters and digits only. The following is the average of 5 repeated attempts each. [With escape_string] Total_Duration Total_CountAvg_Duration AVG_Count/Interval --+-+-+--- 2395787.2 2404987.0 0.99840083.117 --+-+-+--- [No escape_string] Total_Duration Total_CountAvg_Duration AVG_Count/Interval --+-+-+--- 2395570.8 2314081.2 1.04538568.020 --+-+-+--- -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel
