[389-devel] Build failed in Jenkins: 389-DS-NIGHTLY #163

2017-02-13 Thread Jenkins 
See 


--
[...truncated 5453 lines...]
INFO:dirsrvtests.tests.tickets.ticket47536_test:# Extract PK12 file for 
master2: pk12util -o /tmp/Server-Cert2.pk12 -n "Server-Cert2" -d 
/etc/dirsrv/slapd-master_1 -w /etc/dirsrv/slapd-master_1/pwdfile.txt -k 
/etc/dirsrv/slapd-master_1/pwdfile.txt
INFO:dirsrvtests.tests.tickets.ticket47536_test:# Check PK12 files
INFO:dirsrvtests.tests.tickets.ticket47536_test:/tmp/Server-Cert2.pk12 is 
successfully extracted.
INFO:dirsrvtests.tests.tickets.ticket47536_test:# stop master2
INFO:dirsrvtests.tests.tickets.ticket47536_test:# Initialize Cert DB for 
master2
INFO:dirsrvtests.tests.tickets.ticket47536_test:# Create key3.db and 
cert8.db database (master2): ['\''certutil'\'', '\''-N'\'', '\''-d'\'', 
'\''/etc/dirsrv/slapd-master_2'\'', '\''-f'\'', 
'\''/etc/dirsrv/slapd-master_1/pwdfile.txt'\'']
INFO:dirsrvtests.tests.tickets.ticket47536_test:  OUT:
INFO:dirsrvtests.tests.tickets.ticket47536_test:  ERR:
INFO:dirsrvtests.tests.tickets.ticket47536_test:# Import certs to master2
INFO:dirsrvtests.tests.tickets.ticket47536_test:Importing CAcertificate
INFO:dirsrvtests.tests.tickets.ticket47536_test:# Importing Server-Cert2 to 
master2: pk12util -i /tmp/Server-Cert2.pk12 -n "Server-Cert2" -d 
/etc/dirsrv/slapd-master_2 -w /etc/dirsrv/slapd-master_1/pwdfile.txt -k 
/etc/dirsrv/slapd-master_1/pwdfile.txt
INFO:dirsrvtests.tests.tickets.ticket47536_test:copy 
/etc/dirsrv/slapd-master_1/pin.txt to /etc/dirsrv/slapd-master_2/pin.txt
INFO:dirsrvtests.tests.tickets.ticket47536_test:# start master2
INFO:dirsrvtests.tests.tickets.ticket47536_test:# enable SSL in master2 
with all ciphers
INFO:dirsrvtests.tests.tickets.ticket47536_test:
# Enabling SSL LDAPSPORT 42636 ##

INFO:dirsrvtests.tests.tickets.ticket47536_test:# restart master2
INFO:dirsrvtests.tests.tickets.ticket47536_test:# Check PEM files of 
master2 (before setting nsslapd-extract-pemfiles
INFO:dirsrvtests.tests.tickets.ticket47536_test:
# Check PEM files (CAcertificate, Server-Cert2, 
Server-Cert2-Key) not in /etc/dirsrv/slapd-master_2 ##

INFO:dirsrvtests.tests.tickets.ticket47536_test:/etc/dirsrv/slapd-master_2/CAcertificate.pem
 is correctly not generated.
INFO:dirsrvtests.tests.tickets.ticket47536_test:/etc/dirsrv/slapd-master_2/Server-Cert2.pem
 is correctly not generated.
INFO:dirsrvtests.tests.tickets.ticket47536_test:/etc/dirsrv/slapd-master_2/Server-Cert2-Key.pem
 is correctly not generated.
INFO:dirsrvtests.tests.tickets.ticket47536_test:# Set on to 
nsslapd-extract-pemfiles
INFO:dirsrvtests.tests.tickets.ticket47536_test:# restart master2
INFO:dirsrvtests.tests.tickets.ticket47536_test:# Check PEM files of 
master2 (after setting nsslapd-extract-pemfiles
INFO:dirsrvtests.tests.tickets.ticket47536_test:
# Check PEM files (CAcertificate, Server-Cert2, 
Server-Cert2-Key) in /etc/dirsrv/slapd-master_2 ##

INFO:dirsrvtests.tests.tickets.ticket47536_test:/etc/dirsrv/slapd-master_2/CAcertificate.pem
 is successfully generated.
INFO:dirsrvtests.tests.tickets.ticket47536_test:/etc/dirsrv/slapd-master_2/Server-Cert2.pem
 is successfully generated.
INFO:dirsrvtests.tests.tickets.ticket47536_test:/etc/dirsrv/slapd-master_2/Server-Cert2-Key.pem
 is successfully generated.
INFO:dirsrvtests.tests.tickets.ticket47536_test:# restart master1
INFO:dirsrvtests.tests.tickets.ticket47536_test:
# Creating SSL Keys and Certs Done 
##

INFO:dirsrvtests.tests.tickets.ticket47536_test:# 
Configure SSL/TLS agreements ##
INFO:dirsrvtests.tests.tickets.ticket47536_test: 
master1 -- startTLS -> master2 #
INFO:dirsrvtests.tests.tickets.ticket47536_test:# master1 
<- tls_clientAuth -- master2 ##
INFO:dirsrvtests.tests.tickets.ticket47536_test:# Update the agreement of 
master1
INFO:dirsrvtests.tests.tickets.ticket47536_test:# Add the cert to the repl 
manager on master1
INFO:dirsrvtests.tests.tickets.ticket47536_test:# master2 Server Cert in 
base64 format: 
MIICvjCCAaagAwIBAgICA+owDQYJKoZIhvcNAQELBQAwETEPMA0GA1UEAxMGQ0FjZXJ0MB4XDTE3MDIxMjIzMzYwOVoXDTI3MDIxMjIzMzYwOVowMzEdMBsGA1UECxMUMzkwIERpcmVjdG9yeSBTZXJ2ZXIxEjAQBgNVBAMTCWxvY2FsaG9zdDCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMYCtzVbvZUZ3fXns2Bj+o6K9XJu7b9cFLaoBFtnClb4d4/lvZDlPjIU0/7RSSoj1xOUTgfaCoPk9UqbLb1jnmIcilUDcTPF9Uh3VtRUFzX2BerEf2jebuqOo/oWNAgguJAEDXhW1o93aUu/olvu72OFtBAWzFfmFqQHW26lDm9vAMb+wBsd/01WZsLIp1NnXGNYseA5WRaS9gKPtWdOarUIh8ncE2wZGB9qX8OcEZaGPNLfZ81dF583ARsw9644rim5xtc74ZdIkRwvIwLxxrzDX0Dn3ZQM+YKtAaYoHuj20D7lFHUy/wJXj4Iv/bgoxnyAJK04LfCQxXX0v4TC7nkCAwEAATANBgkqhkiG9w0BAQsFAAOCAQEAHdrxIE2kyxZ

[389-devel] GSoc 2017:Regarding the project developing administrative tools for 389 directory server

2017-02-13 Thread Asantha Thilina 
Hi all,

I am final year software engineering student at srilanka institute of
information technology and i would like to contribute to project *developing
administrative tools for 389 directory server* for GSoC and i would like to
know more about the project and would be grateful if someone can guide me
on this

thanks,
Asantha
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Trac -> Pagure migration is complete

2017-02-13 Thread Simon Pichugin 
On Sat, Feb 11, 2017 at 05:23:24PM -0500, Mark Reynolds wrote:
>Our migration to Pagure is complete.  Please use this project for
>filing Directory Server issues (aka Tickets):
>[1]https://pagure.io/389-ds-base
>Trac is now in read-only mode.  If you need help with any of this just
>send an email to [2]389-us...@lists.fedoraproject.org or #389 channel
>on IRC (freenode)
Looks great! Thank you!

What is about lib389 migration, btw?
https://pagure.io/lib389
Should we create new issues there?

Sorry if you've posted the info about lib389 migration already, I probably
missed it.

> 
>On 02/08/2017 12:07 PM, Mark Reynolds wrote:
> 
>We are planning on doing the Trac to Pagure migration this Friday.
>Using Pagure is very similar to Trac, except you create "Issues"
>instead of "tickets".
>One change to keep in mind is that we now have separate projects for
>our components like: admin server, 389-ds-console,
>idm-console-framework, 389-dsgw, 389-ds-base, etc.  These can all be
>found under the Directory_Services group:
>[3]https://pagure.io/group/Directory_Services
>If you have an Admin Server issue to report create a new issue under
>the 389-admin project, etc.
>Please use the "389-ds-base" project for new Directory Server issues.
>Note, your previous tickets you filed, or are following, will still
>have the same ticket number:
>[4]https://fedorahosted.org/389/ticket/48118
>Will be:
>[5]https://pagure.io/389-ds-base/issue/48118
>Once the migration is complete there will be a final announcement, and
>Trac will be put into read-only mode until it is decommissioned.
>Regards,
>Mark
> 
> ___
> 389-announce mailing list -- [6]389-annou...@lists.fedoraproject.org
> To unsubscribe send an email to [7]389-announce-le...@lists.fedoraproject.org
> 
> References
> 
>1. https://pagure.io/389-ds-base/issue/
>2. mailto:389-us...@lists.fedoraproject.org
>3. https://pagure.io/group/Directory_Services
>4. https://fedorahosted.org/389/ticket/48118
>5. https://pagure.io/389-ds-base/issue/
>6. mailto:389-annou...@lists.fedoraproject.org
>7. mailto:389-announce-le...@lists.fedoraproject.org

> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Trac -> Pagure migration is complete

2017-02-13 Thread Mark Reynolds 


On 02/13/2017 05:51 AM, Simon Pichugin wrote:
> On Sat, Feb 11, 2017 at 05:23:24PM -0500, Mark Reynolds wrote:
>>Our migration to Pagure is complete.  Please use this project for
>>filing Directory Server issues (aka Tickets):
>>[1]https://pagure.io/389-ds-base
>>Trac is now in read-only mode.  If you need help with any of this just
>>send an email to [2]389-us...@lists.fedoraproject.org or #389 channel
>>on IRC (freenode)
> Looks great! Thank you!
>
> What is about lib389 migration, btw?
> https://pagure.io/lib389
> Should we create new issues there?
Yes, but the source is not migrated yet.  I'll be doing that today...
>
> Sorry if you've posted the info about lib389 migration already, I probably
> missed it.
>
>>On 02/08/2017 12:07 PM, Mark Reynolds wrote:
>>
>>We are planning on doing the Trac to Pagure migration this Friday.
>>Using Pagure is very similar to Trac, except you create "Issues"
>>instead of "tickets".
>>One change to keep in mind is that we now have separate projects for
>>our components like: admin server, 389-ds-console,
>>idm-console-framework, 389-dsgw, 389-ds-base, etc.  These can all be
>>found under the Directory_Services group:
>>[3]https://pagure.io/group/Directory_Services
>>If you have an Admin Server issue to report create a new issue under
>>the 389-admin project, etc.
>>Please use the "389-ds-base" project for new Directory Server issues.
>>Note, your previous tickets you filed, or are following, will still
>>have the same ticket number:
>>[4]https://fedorahosted.org/389/ticket/48118
>>Will be:
>>[5]https://pagure.io/389-ds-base/issue/48118
>>Once the migration is complete there will be a final announcement, and
>>Trac will be put into read-only mode until it is decommissioned.
>>Regards,
>>Mark
>>
>> ___
>> 389-announce mailing list -- [6]389-annou...@lists.fedoraproject.org
>> To unsubscribe send an email to [7]389-announce-le...@lists.fedoraproject.org
>>
>> References
>>
>>1. https://pagure.io/389-ds-base/issue/
>>2. mailto:389-us...@lists.fedoraproject.org
>>3. https://pagure.io/group/Directory_Services
>>4. https://fedorahosted.org/389/ticket/48118
>>5. https://pagure.io/389-ds-base/issue/
>>6. mailto:389-annou...@lists.fedoraproject.org
>>7. mailto:389-announce-le...@lists.fedoraproject.org
>> ___
>> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
>> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
>
>
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: #49121 ns-slapd crashes in ldif_sput due to the output buf size is less than the real size.

2017-02-13 Thread Mark Reynolds 


On 02/12/2017 06:51 PM, Noriko Hosoi wrote:
>
> https://pagure.io/389-ds-base/issue/49121
>
> https://pagure.io/389-ds-base/issue/raw/files/d857ff4919940bcebeae870774896783f7b6e86ce08a2c2e924610ac2335f8de-0001-Ticket-49121-ns-slapd-crashes-in-ldif_sput-due-to-th.patch
>
> These odd » characters are shown at some part of the patch.  I wonder
> what causes this display issue...  And non-ascii characters are not
> printed correctly although they are in the "View Raw" mode.  Please
> see the utf8str.txt file.
>
This is showing you tabs - this is working as designed
>
> 277 @@ -1499,30 +1506,36 @@ entry2str_internal_size_attrlist( const
> Slapi_Attr *attrlist, int entry2str_ctrl
> 280  »   »   /* Count the space required for the present and deleted 
> values */
> 281 -» » elen+= entry2str_internal_size_valueset(a->a_type,
> &a->a_present_values,
> 282 -» » » » » » » » » » » » entry2str_ctrl, attribute_state,
> 283 -» » » » » » » » » » » » VALUE_PRESENT); 305 +» » elen += 
> entry2str_internal_size_valueset(a, a->a_type,
> &a->a_present_values,
> 306 +» » entry2str_ctrl, attribute_state, VALUE_PRESENT);
>
>
> Note: The test build was blessed by the bug reporter.
>
>
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Q. on lib389 Re: Please review: #49121 ns-slapd crashes in ldif_sput due to the output buf size is less than the real size.

2017-02-13 Thread Mark Reynolds 


On 02/12/2017 09:14 PM, William Brown wrote:
> On Sun, 2017-02-12 at 17:42 -0800, Noriko Hosoi wrote:
>> On 02/12/2017 03:51 PM, Noriko Hosoi wrote:
>>> https://pagure.io/389-ds-base/issue/49121
>>>
>>> https://pagure.io/389-ds-base/issue/raw/files/d857ff4919940bcebeae870774896783f7b6e86ce08a2c2e924610ac2335f8de-0001-Ticket-49121-ns-slapd-crashes-in-ldif_sput-due-to-th.patch
>>>
>>> These odd » characters are shown at some part of the patch.  I wonder 
>>> what causes this display issue...  And non-ascii characters are not 
>>> printed correctly although they are in the "View Raw" mode.  Please 
>>> see the utf8str.txt file.
>>>
>>> 277  @@ -1499,30 +1506,36 @@ entry2str_internal_size_attrlist( const 
>>> Slapi_Attr *attrlist, int entry2str_ctrl
>>> 280   »   »   /* Count the space required for the present and 
>>> deleted values */
>>> 281  -» » elen+= entry2str_internal_size_valueset(a->a_type, 
>>> &a->a_present_values,
>>> 282  -» » » » » » » » » » » » entry2str_ctrl, attribute_state,
>>> 283  -» » » » » » » » » » » » VALUE_PRESENT); 305  +» » elen += 
>>> entry2str_internal_size_valueset(a, a->a_type, 
>>> &a->a_present_values,
>>> 306  +» » entry2str_ctrl, attribute_state, VALUE_PRESENT);
>>>
>>>
>>> Note: The test build was blessed by the bug reporter.
>> Thanks to William for his reviews.  I've update the patch based on his 
>> suggestion.
>>
>> I also have 2 lib389 patches (attached to this email).  Is lib389 still 
>> in fedorahosted?  I cloned pagure.io/lib389.git, but I found it empty...
>>
>> 1) could you please review the patches?
> I'm happy with the dbscan change
>
> I don't use the valgrind wrapper myself (it should disable transparently
> when ASAN is enabled). I'm not sure about the check for sbin dir though,
> because it shouldn't matter what we use. Is there a reason you need to
> check for root with just those dirs? Is it related to where the DS
> instance is from (prefix build vs rpm)
>
>> 2) if they look fine, is it ok to push them to fedorahosted git repository?
> I would ask Mark this, he knows the most about the situation. 
I will be migrating the lib389 source code today (as well as admin
server, etc)
>
>
>
>
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Q. on lib389 Re: Please review: #49121 ns-slapd crashes in ldif_sput due to the output buf size is less than the real size.

2017-02-13 Thread Noriko Hosoi 

On 02/12/2017 06:14 PM, William Brown wrote:

On Sun, 2017-02-12 at 17:42 -0800, Noriko Hosoi wrote:

On 02/12/2017 03:51 PM, Noriko Hosoi wrote:

https://pagure.io/389-ds-base/issue/49121

https://pagure.io/389-ds-base/issue/raw/files/d857ff4919940bcebeae870774896783f7b6e86ce08a2c2e924610ac2335f8de-0001-Ticket-49121-ns-slapd-crashes-in-ldif_sput-due-to-th.patch

These odd » characters are shown at some part of the patch.  I wonder
what causes this display issue...  And non-ascii characters are not
printed correctly although they are in the "View Raw" mode.  Please
see the utf8str.txt file.

277  @@ -1499,30 +1506,36 @@ entry2str_internal_size_attrlist( const
Slapi_Attr *attrlist, int entry2str_ctrl
280   »   »   /* Count the space required for the present and deleted 
values */
281  -» » elen+= entry2str_internal_size_valueset(a->a_type,
&a->a_present_values,
282  -» » » » » » » » » » » » entry2str_ctrl, attribute_state,
283  -» » » » » » » » » » » » VALUE_PRESENT); 305  +» » elen += 
entry2str_internal_size_valueset(a, a->a_type,
&a->a_present_values,
306  +» » entry2str_ctrl, attribute_state, VALUE_PRESENT);


Note: The test build was blessed by the bug reporter.

Thanks to William for his reviews.  I've update the patch based on his
suggestion.

I also have 2 lib389 patches (attached to this email).  Is lib389 still
in fedorahosted?  I cloned pagure.io/lib389.git, but I found it empty...

1) could you please review the patches?

I'm happy with the dbscan change

I don't use the valgrind wrapper myself (it should disable transparently
when ASAN is enabled).
Are there any chance to support both valgrind and ASAN?  Well, I'm not 
at the position to insist anything any more here :p, but they are just 
tools and supporting both of them is not a bad idea, is it?

I'm not sure about the check for sbin dir though,
because it shouldn't matter what we use. Is there a reason you need to
check for root with just those dirs? Is it related to where the DS
instance is from (prefix build vs rpm)
I'm running the test against the server installed in $PREFIX as my 
account.  I hope it's kept supported.

Thanks,
--noriko

2) if they look fine, is it ok to push them to fedorahosted git repository?

I would ask Mark this, he knows the most about the situation.




___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Q. on lib389 Re: Please review: #49121 ns-slapd crashes in ldif_sput due to the output buf size is less than the real size.

2017-02-13 Thread Lukas Slebodnik 
On (13/02/17 08:38), Noriko Hosoi wrote:
>On 02/12/2017 06:14 PM, William Brown wrote:
>> On Sun, 2017-02-12 at 17:42 -0800, Noriko Hosoi wrote:
>> > On 02/12/2017 03:51 PM, Noriko Hosoi wrote:
>> > > https://pagure.io/389-ds-base/issue/49121
>> > > 
>> > > https://pagure.io/389-ds-base/issue/raw/files/d857ff4919940bcebeae870774896783f7b6e86ce08a2c2e924610ac2335f8de-0001-Ticket-49121-ns-slapd-crashes-in-ldif_sput-due-to-th.patch
>> > > 
>> > > These odd » characters are shown at some part of the patch.  I wonder
>> > > what causes this display issue...  And non-ascii characters are not
>> > > printed correctly although they are in the "View Raw" mode.  Please
>> > > see the utf8str.txt file.
>> > > 
>> > > 277  @@ -1499,30 +1506,36 @@ entry2str_internal_size_attrlist( const
>> > > Slapi_Attr *attrlist, int entry2str_ctrl
>> > > 280   »   »   /* Count the space required for the present and 
>> > > deleted values */
>> > > 281  -» » elen+= entry2str_internal_size_valueset(a->a_type,
>> > > &a->a_present_values,
>> > > 282  -» » » » » » » » » » » » entry2str_ctrl, attribute_state,
>> > > 283  -» » » » » » » » » » » » VALUE_PRESENT); 305  +» » elen += 
>> > > entry2str_internal_size_valueset(a, a->a_type,
>> > > &a->a_present_values,
>> > > 306  +» » entry2str_ctrl, attribute_state, VALUE_PRESENT);
>> > > 
>> > > 
>> > > Note: The test build was blessed by the bug reporter.
>> > Thanks to William for his reviews.  I've update the patch based on his
>> > suggestion.
>> > 
>> > I also have 2 lib389 patches (attached to this email).  Is lib389 still
>> > in fedorahosted?  I cloned pagure.io/lib389.git, but I found it empty...
>> > 
>> > 1) could you please review the patches?
>> I'm happy with the dbscan change
>> 
>> I don't use the valgrind wrapper myself (it should disable transparently
>> when ASAN is enabled).
>Are there any chance to support both valgrind and ASAN?  Well, I'm not at the
>position to insist anything any more here :p, but they are just tools and
>supporting both of them is not a bad idea, is it?

FYI:
My experienceis that you should use either ASAN or valgrind.
They do not work well togeteher. That's the same for other sanitizers.

ASAN is faster but valgrind should catch more bugs.
Of course it can change in future :-)

my 2 cents

LS
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Another Q. on pagure issue page: Please review: #49121 ns-slapd crashes in ldif_sput due to the output buf size is less than the real size.

2017-02-13 Thread Noriko Hosoi 

Hi, it might be a known issue, but ...

When we have multiple links in, e.g., rhbz, what is the right way to 
list them?  Separated with ' ' does not work.  It's considered one url, 
instead of 2, and it does not jump to the bug by clicking it...


   ***rhbz* 


   https://bugzilla.redhat.com/show_bug.cgi?id=1418202
   https://bugzilla.redhat.com/show_bug.cgi?id=1421512
   



Separated with ',' fails to update...
> Meta-data "link" field (rhbz) has invalid url ()

Thanks,
--noriko

 Forwarded Message 
Subject: 	Please review: #49121 ns-slapd crashes in ldif_sput due to the 
output buf size is less than the real size.

Date:   Sun, 12 Feb 2017 15:51:21 -0800
From:   
To: 	389 Directory server developer discussion. 
<389-devel@lists.fedoraproject.org>




https://pagure.io/389-ds-base/issue/49121

https://pagure.io/389-ds-base/issue/raw/files/d857ff4919940bcebeae870774896783f7b6e86ce08a2c2e924610ac2335f8de-0001-Ticket-49121-ns-slapd-crashes-in-ldif_sput-due-to-th.patch

These odd » characters are shown at some part of the patch.  I wonder 
what causes this display issue...  And non-ascii characters are not 
printed correctly although they are in the "View Raw" mode.  Please see 
the utf8str.txt file.


277  @@ -1499,30 +1506,36 @@ entry2str_internal_size_attrlist( const 
Slapi_Attr *attrlist, int entry2str_ctrl

280   »   »   /* Count the space required for the present and deleted 
values */
281  -» » elen+= entry2str_internal_size_valueset(a->a_type, 
&a->a_present_values,

282  -» » » » » » » » » » » » entry2str_ctrl, attribute_state,
283  -» » » » » » » » » » » » VALUE_PRESENT); 305  +» » elen += entry2str_internal_size_valueset(a, a->a_type, 
&a->a_present_values,

306  +» » entry2str_ctrl, attribute_state, VALUE_PRESENT);


Note: The test build was blessed by the bug reporter.

___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Q. on lib389 Re: Please review: #49121 ns-slapd crashes in ldif_sput due to the output buf size is less than the real size.

2017-02-13 Thread Ludwig Krispenz 

 Well, I'm not at the position to insist anything any more here :p,

your comments and suggestions and requests are still very welcome and 
needed, independent of your "position". For me it is such a pity to see 
you leaving the team and I hope you will still find some time to help us 
and give us your valuable comments - I am preparing  a doc about 
replication conflicts and would really appreciate if you could 
participate in a review.


Regards,
Ludwig

PS: how is your cat, did the therapy help ?

I'm not sure about the check for sbin dir though,
because it shouldn't matter what we use. Is there a reason you need to
check for root with just those dirs? Is it related to where the DS
instance is from (prefix build vs rpm)
I'm running the test against the server installed in $PREFIX as my 
account.  I hope it's kept supported.

Thanks,
--noriko

2) if they look fine, is it ok to push them to fedorahosted git repository?

I would ask Mark this, he knows the most about the situation.




___
389-devel mailing list --389-devel@lists.fedoraproject.org
To unsubscribe send an email to389-devel-le...@lists.fedoraproject.org





___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org


--
Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael Cunningham, Michael O'Neill, Eric 
Shander

___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Q. on lib389 Re: Please review: #49121 ns-slapd crashes in ldif_sput due to the output buf size is less than the real size.

2017-02-13 Thread Noriko Hosoi 

On 02/13/2017 08:51 AM, Lukas Slebodnik wrote:

On (13/02/17 08:38), Noriko Hosoi wrote:

On 02/12/2017 06:14 PM, William Brown wrote:

On Sun, 2017-02-12 at 17:42 -0800, Noriko Hosoi wrote:

On 02/12/2017 03:51 PM, Noriko Hosoi wrote:

https://pagure.io/389-ds-base/issue/49121

https://pagure.io/389-ds-base/issue/raw/files/d857ff4919940bcebeae870774896783f7b6e86ce08a2c2e924610ac2335f8de-0001-Ticket-49121-ns-slapd-crashes-in-ldif_sput-due-to-th.patch

These odd » characters are shown at some part of the patch.  I wonder
what causes this display issue...  And non-ascii characters are not
printed correctly although they are in the "View Raw" mode.  Please
see the utf8str.txt file.

277  @@ -1499,30 +1506,36 @@ entry2str_internal_size_attrlist( const
Slapi_Attr *attrlist, int entry2str_ctrl
280   »   »   /* Count the space required for the present and deleted 
values */
281  -» » elen+= entry2str_internal_size_valueset(a->a_type,
&a->a_present_values,
282  -» » » » » » » » » » » » entry2str_ctrl, attribute_state,
283  -» » » » » » » » » » » » VALUE_PRESENT); 305  +» » elen += 
entry2str_internal_size_valueset(a, a->a_type,
&a->a_present_values,
306  +» » entry2str_ctrl, attribute_state, VALUE_PRESENT);


Note: The test build was blessed by the bug reporter.

Thanks to William for his reviews.  I've update the patch based on his
suggestion.

I also have 2 lib389 patches (attached to this email).  Is lib389 still
in fedorahosted?  I cloned pagure.io/lib389.git, but I found it empty...

1) could you please review the patches?

I'm happy with the dbscan change

I don't use the valgrind wrapper myself (it should disable transparently
when ASAN is enabled).

Are there any chance to support both valgrind and ASAN?  Well, I'm not at the
position to insist anything any more here :p, but they are just tools and
supporting both of them is not a bad idea, is it?

FYI:
My experienceis that you should use either ASAN or valgrind.
They do not work well togeteher. That's the same for other sanitizers.

I see...  Thanks, Lukas!

The current test scripts call valgrind APIs only if it's built without 
ASAN enabled as follows.  That is, if ASAN is enabled in the CI, the 
valgrind check won't be executed.  Probably, we could move this 
"has_asan" check to the inside of the valgrind APIs and keep the APIs in 
lib389?


*if not topology_m2.ms["master1"].has_asan():*
results_file = valgrind_get_results_file(topology_m2.ms["master1"])

Another question is, when the CI test enables ASAN, is this test case -- 
checking the valgrind result and determining the test case succeeded or 
failed -- still valid?  Or should we rewrite it based upon the ASAN 
syntax (if any) later?


Thanks,
--noriko


ASAN is faster but valgrind should catch more bugs.
Of course it can change in future :-)

my 2 cents

LS
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Q. on lib389 Re: Please review: #49121 ns-slapd crashes in ldif_sput due to the output buf size is less than the real size.

2017-02-13 Thread William Brown 
On Mon, 2017-02-13 at 09:31 -0800, Noriko Hosoi wrote:
> On 02/13/2017 08:51 AM, Lukas Slebodnik wrote:
> > On (13/02/17 08:38), Noriko Hosoi wrote:
> >> On 02/12/2017 06:14 PM, William Brown wrote:
> >>> On Sun, 2017-02-12 at 17:42 -0800, Noriko Hosoi wrote:
>  On 02/12/2017 03:51 PM, Noriko Hosoi wrote:
> > https://pagure.io/389-ds-base/issue/49121
> >
> > https://pagure.io/389-ds-base/issue/raw/files/d857ff4919940bcebeae870774896783f7b6e86ce08a2c2e924610ac2335f8de-0001-Ticket-49121-ns-slapd-crashes-in-ldif_sput-due-to-th.patch
> >
> > These odd » characters are shown at some part of the patch.  I wonder
> > what causes this display issue...  And non-ascii characters are not
> > printed correctly although they are in the "View Raw" mode.  Please
> > see the utf8str.txt file.
> >
> > 277  @@ -1499,30 +1506,36 @@ entry2str_internal_size_attrlist( const
> > Slapi_Attr *attrlist, int entry2str_ctrl
> > 280   »   »   /* Count the space required for the present and 
> > deleted values */
> > 281  -» » elen+= entry2str_internal_size_valueset(a->a_type,
> > &a->a_present_values,
> > 282  -» » » » » » » » » » » » entry2str_ctrl, attribute_state,
> > 283  -» » » » » » » » » » » » VALUE_PRESENT); 305  +» » elen += 
> > entry2str_internal_size_valueset(a, a->a_type,
> > &a->a_present_values,
> > 306  +» » entry2str_ctrl, attribute_state, VALUE_PRESENT);
> >
> >
> > Note: The test build was blessed by the bug reporter.
>  Thanks to William for his reviews.  I've update the patch based on his
>  suggestion.
> 
>  I also have 2 lib389 patches (attached to this email).  Is lib389 still
>  in fedorahosted?  I cloned pagure.io/lib389.git, but I found it empty...
> 
>  1) could you please review the patches?
> >>> I'm happy with the dbscan change
> >>>
> >>> I don't use the valgrind wrapper myself (it should disable transparently
> >>> when ASAN is enabled).
> >> Are there any chance to support both valgrind and ASAN?  Well, I'm not at 
> >> the
> >> position to insist anything any more here :p, but they are just tools and
> >> supporting both of them is not a bad idea, is it?
> > FYI:
> > My experienceis that you should use either ASAN or valgrind.
> > They do not work well togeteher. That's the same for other sanitizers.

They *can not* be operated together. They both try to intercept malloc,
and they break each other. 

> I see...  Thanks, Lukas!
> 
> The current test scripts call valgrind APIs only if it's built without 
> ASAN enabled as follows.  That is, if ASAN is enabled in the CI, the 
> valgrind check won't be executed.  Probably, we could move this 
> "has_asan" check to the inside of the valgrind APIs and keep the APIs in 
> lib389?

I thought I had already done that? It really only affects me anyway. 

> 
> *if not topology_m2.ms["master1"].has_asan():*
>  results_file = valgrind_get_results_file(topology_m2.ms["master1"])
> 
> Another question is, when the CI test enables ASAN, is this test case -- 
> checking the valgrind result and determining the test case succeeded or 
> failed -- still valid?  Or should we rewrite it based upon the ASAN 
> syntax (if any) later?

We can use both in the way here, I don't see a reason to change. In the
ASAN mode, the DS exits with a fail code, which crashes the test, even
if the valgrind wrapper "passes".

> 
> Thanks,
> --noriko
> >
> > ASAN is faster but valgrind should catch more bugs.
> > Of course it can change in future :-)

I disagree, but that's what we are entitled to do.

ASAN is easier to setup (compile only, no need to hack scripts),
triggers errors faster (lib389 picks up errors immediately, no need to
parse output) gives better traces (shows where the leak occured, where
it was allocated, and can even show memory addresses for you to set
watch points on to debug) and it's faster. 

-- 
Sincerely,

William Brown
Software Engineer
Red Hat, Brisbane


signature.asc
Description: This is a digitally signed message part
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: GSoc 2017:Regarding the project developing administrative tools for 389 directory server

2017-02-13 Thread William Brown 
On Mon, 2017-02-13 at 01:51 -0800, Asantha Thilina wrote:
> Hi all,
> 
> I am final year software engineering student at srilanka institute of
> information technology and i would like to contribute to project *developing
> administrative tools for 389 directory server* for GSoC and i would like to
> know more about the project and would be grateful if someone can guide me
> on this

Hi there,

I'm the developer who submitted to the Fedora GSOC project.

If you want to know more I would advise that you read about dsadm and
dsconf on our wiki:

http://www.port389.org/docs/389ds/design/dsadm-dsconf.html

A lot of work has already gone into the project, and can be found in the
lib389 repository. This is here:

https://pagure.io/lib389/tree/master

This is a system able to setup and build new Directory Server instances.
The command line tools are found:

https://pagure.io/lib389/blob/master/f/cli
https://pagure.io/lib389/blob/master/f/lib389/cli_conf
https://pagure.io/lib389/blob/master/f/lib389/tests/cli

These work by consuming our LDAP orm system which is implemented here:

https://pagure.io/lib389/blob/master/f/lib389/_mapped_object.py

And an example of the consumption of this is:

https://pagure.io/lib389/blob/master/f/lib389/plugins.py


* What would be your assigned task:

-- We would be looking for you to setup and deploy your own ldap server,
and understand how the plugins work.
-- We would then want you to add the components to plugins.py, so that
tests and the cli can manipulate those plugins.
-- You would be wiring in the plugin management command to cli_conf
-- finally, and most importantly, the cli and plugins.py code is fully
unit tested. 

I hope this helps you,

___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: GSoc 2017:Regarding the project developing administrative tools for 389 directory server

2017-02-13 Thread Asantha Thilina 
Hi William,

many thanks for the reply i go through the references and assigned tasks

thanks,

On Mon, Feb 13, 2017 at 7:43 PM, William Brown 
wrote:

> On Mon, 2017-02-13 at 01:51 -0800, Asantha Thilina wrote:
> > Hi all,
> >
> > I am final year software engineering student at srilanka institute of
> > information technology and i would like to contribute to project
> *developing
> > administrative tools for 389 directory server* for GSoC and i would like
> to
> > know more about the project and would be grateful if someone can guide me
> > on this
>
> Hi there,
>
> I'm the developer who submitted to the Fedora GSOC project.
>
> If you want to know more I would advise that you read about dsadm and
> dsconf on our wiki:
>
> http://www.port389.org/docs/389ds/design/dsadm-dsconf.html
>
> A lot of work has already gone into the project, and can be found in the
> lib389 repository. This is here:
>
> https://pagure.io/lib389/tree/master
>
> This is a system able to setup and build new Directory Server instances.
> The command line tools are found:
>
> https://pagure.io/lib389/blob/master/f/cli
> https://pagure.io/lib389/blob/master/f/lib389/cli_conf
> https://pagure.io/lib389/blob/master/f/lib389/tests/cli
>
> These work by consuming our LDAP orm system which is implemented here:
>
> https://pagure.io/lib389/blob/master/f/lib389/_mapped_object.py
>
> And an example of the consumption of this is:
>
> https://pagure.io/lib389/blob/master/f/lib389/plugins.py
>
>
> * What would be your assigned task:
>
> -- We would be looking for you to setup and deploy your own ldap server,
> and understand how the plugins work.
> -- We would then want you to add the components to plugins.py, so that
> tests and the cli can manipulate those plugins.
> -- You would be wiring in the plugin management command to cli_conf
> -- finally, and most importantly, the cli and plugins.py code is fully
> unit tested.
>
> I hope this helps you,
>
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
>



-- 
Best Regards,
Asantha Thilina



___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org