[389-devel] Please review: 49119 clean configure options

[William Brown]

https://pagure.io/389-ds-base/issue/49119

https://pagure.io/389-ds-base/issue/raw/files/b5673bc55b4fe94a630be6cdd1fb63509f05214dcc44630a5e4de48c805b1bdb-0001-Ticket-49119-Cleanup-configure.ac-options-and-define.patch

-- 
Sincerely,

William Brown
Software Engineer
Red Hat, Australia/Brisbane



signature.asc
Description: This is a digitally signed message part
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Low bound on import sizing

[William Brown]

https://pagure.io/389-ds-base/issue/49204

https://pagure.io/389-ds-base/issue/raw/files/439afb815888f065e5ad50db3918444da66758a6b85338265d8db85f115f9fce-0001-Ticket-49204-Fix-lower-bounds-on-import-autosize.patch



-- 
Sincerely,

William Brown
Software Engineer
Red Hat, Australia/Brisbane



signature.asc
Description: This is a digitally signed message part
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Build failed in Jenkins: 389-DS-NIGHTLY #204

[Jenkins]

See 


--
[...truncated 4313 lines...]
suites/paged_results/paged_results_test.py::test_search_paged_limits[conf_attr_values0-ADMINLIMIT_EXCEEDED]
 PASSED
suites/paged_results/paged_results_test.py::test_search_paged_limits[conf_attr_values1-PASS]
 PASSED
suites/paged_results/paged_results_test.py::test_search_paged_user_limits[conf_attr_values0-ADMINLIMIT_EXCEEDED]
 PASSED
suites/paged_results/paged_results_test.py::test_search_paged_user_limits[conf_attr_values1-PASS]
 PASSED
suites/paged_results/paged_results_test.py::test_ger_basic PASSED
suites/paged_results/paged_results_test.py::test_multi_suffix_search PASSED
suites/paged_results/paged_results_test.py::test_maxsimplepaged_per_conn_success[None]
 PASSED
suites/paged_results/paged_results_test.py::test_maxsimplepaged_per_conn_success[-1]
 PASSED
suites/paged_results/paged_results_test.py::test_maxsimplepaged_per_conn_success[1000]
 PASSED
suites/paged_results/paged_results_test.py::test_maxsimplepaged_per_conn_failure[0]
 PASSED
suites/paged_results/paged_results_test.py::test_maxsimplepaged_per_conn_failure[1]
 PASSED
suites/password/password_test.py::test_password_delete_specific_password PASSED
suites/password/pwdAdmin_test.py::test_pwdAdmin_init PASSED
suites/password/pwdAdmin_test.py::test_pwdAdmin PASSED
suites/password/pwdAdmin_test.py::test_pwdAdmin_config_validation PASSED
suites/password/pwdPolicy_attribute_test.py::test_change_pwd[on-off-UNWILLING_TO_PERFORM]
 PASSED
suites/password/pwdPolicy_attribute_test.py::test_change_pwd[off-off-UNWILLING_TO_PERFORM]
 PASSED
suites/password/pwdPolicy_attribute_test.py::test_change_pwd[off-on-None] PASSED
suites/password/pwdPolicy_attribute_test.py::test_change_pwd[on-on-None] PASSED
suites/password/pwdPolicy_attribute_test.py::test_pwd_min_age PASSED
suites/password/pwdPolicy_inherit_global_test.py::test_entry_has_no_restrictions[off-off]
 PASSED
suites/password/pwdPolicy_inherit_global_test.py::test_entry_has_no_restrictions[on-off]
 PASSED
suites/password/pwdPolicy_inherit_global_test.py::test_entry_has_no_restrictions[off-on]
 PASSED
suites/password/pwdPolicy_inherit_global_test.py::test_entry_has_restrictions[cn=config]
 PASSED
suites/password/pwdPolicy_inherit_global_test.py::test_entry_has_restrictions[cn="cn=nsPwPolicyEntry,ou=People,dc=example,dc=com",cn=nsPwPolicyContainer,ou=People,dc=example,dc=com]
 PASSED
suites/password/pwdPolicy_syntax_test.py::test_pwdPolicy_syntax PASSED
suites/password/pwdPolicy_warning_test.py::test_different_values[ ] PASSED
suites/password/pwdPolicy_warning_test.py::test_different_values[junk123] PASSED
suites/password/pwdPolicy_warning_test.py::test_different_values[on] PASSED
suites/password/pwdPolicy_warning_test.py::test_different_values[off] PASSED
suites/password/pwdPolicy_warning_test.py::test_expiry_time PASSED
suites/password/pwdPolicy_warning_test.py::test_password_warning[passwordSendExpiringTime-off]
 PASSED
suites/password/pwdPolicy_warning_test.py::test_password_warning[passwordWarning-3600]
 PASSED
suites/password/pwdPolicy_warning_test.py::test_with_different_password_states 
PASSED
suites/password/pwdPolicy_warning_test.py::test_default_behavior PASSED
suites/password/pwdPolicy_warning_test.py::test_with_local_policy PASSED
suites/password/pwd_algo_test.py::test_pwd_algo_test PASSED
suites/password/pwp_history_test.py::test_pwp_history_test PASSED
suites/plugins/accpol_test.py::test_actNinact_local PASSED
suites/plugins/accpol_test.py::test_noinact_local PASSED
suites/plugins/accpol_test.py::test_inact_local PASSED
suites/plugins/attr_uniqueness_test.py::test_attr_uniqueness_init PASSED
suites/plugins/attr_uniqueness_test.py::test_attr_uniqueness PASSED
suites/plugins/dna_test.py::test_basic PASSED
suites/plugins/memberof_test.py::test_memberof_setloging PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_001 PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_003 PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_004 PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_005 PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_006 PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_007 PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_008 PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_009 PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_010 PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_011 PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_012 PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_013 PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_014 PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_015 PASSED
suites/plugins/memberof_test.py::test_memberof_MultiGrpAttr_016 PASSED
suites/plugins/memberof_

[389-devel] Please review: 49214 - htree concept implementation

[William Brown]

https://pagure.io/389-ds-base/issue/49214

https://pagure.io/389-ds-base/issue/raw/files/3d594f3f0e67bed72b4b1bc67b28d5be3ee37929fb13039a75be77db60c8e484-0001-Ticket-49214-Implement-htree-concept.patch

This will get a COW version in the future, and is an alternate to the B
+Tree I proposed: Each has different use cases, so it would be good to
get this in also. 

-- 
Sincerely,

William Brown
Software Engineer
Red Hat, Australia/Brisbane



signature.asc
Description: This is a digitally signed message part
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 20 - Use the DN_DM constant instead of hard coding its value

[Ηλίας Σταμάτης]

Hello,

I would like a review on the following: https://pagure.io/lib389/issue/20

Here's the patch:

https://pagure.io/lib389/issue/raw/files/33582f0dac1d46b5c0ad37f8338722bf534e0814bc17e50787c2f6962456f8ad-0001-Ticket-20-Use-the-DN_DM-constant-instead-of-hard-cod.patch

Thanks!
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: DSLdapObject compare function and user compare tests

[William Brown]

On Fri, 2017-04-07 at 06:10 +, Ankit Yadav wrote:
> Hello Everyone,
> 
> I have changed the compare function, took help from Entry.__eq__ function. 
> I have also updated the user_compare_test.py, Now it includes 4 assertions. 
> Details can be found in lib389/tests/idm/user_compare_test.py
> Also removed the 'DeepDiff' dependency.
> Please review this commit: 
> https://pagure.io/fork/ankity10/lib389/c/762ef9054f01837a33219aa2412d428f5d783c52?branch=ticket-1-config-compare
> 
> Thanks

Hi there,

This is a big improvement! Thanks for taking all my feedback.

When we supply patches for review, we generally like to supply them as
1, so we can see the whole change in one, rather than over two commits.
I've just updated our contributing guide, so it may be worth you reading
over it.

http://www.port389.org/docs/389ds/contributing.html

It has a section on how to squash commits together in git, as well as
our commit message formats we prefer.

21 + # check if RDN is same
22 + if obj1.rdn != obj2.rdn:
23 + return False

I think the question is if we want to check if two objects in different
subtrees have the same attributes, or if we want *true* object equality.

*true* object equality, you want to check nsUniqueId first, because
that's always going to be different between everything.

But if we want to just compare arbitrary objects, I think the rdn check
is better, and we need to ignore nsUniqueId.

For this purpose perhaps we want the "loose" equality, just checking if
attributes are the same. IE if I had:

cn=user1,ou=a
cn=user1,ou=b

They should compare the same, even though their nsUniqueId differs. 

For now I think this code is okay, but we should leave some comments
around this discussion there, and certainly document in the docstring
that this is a loose equality, not a strict "this object *is* this other
object". 


46   # removing _compate_exclude attrs from all attrs
47   for key in self._compare_exclude:
48 - attrs_dict.pop(key.lower(), None)
49 + del attrs_dict[key.lower()]

Rather than deleting these, why not use a set and do:

compare_attrs = set(attrs_dict.keys) - set(self._compare_exclude)

The issue with python is that sometimes delete and operations like that
are destructive and have weird side effects, so it's better to take a
functional approach and make a new set of attributes you want, rather
than modifying a set you already have. 

48   testuser1.delete()
49   testuser2.delete()

The test teardown deletes the database, so you don't need to delete the
users at the end :) 


If you squash this patch and the last one together now, and send again
for a quick check, I think you would be pretty close to having a working
object compare to merge :) 

Thanks heaps! 

-- 
Sincerely,

William Brown
Software Engineer
Red Hat, Australia/Brisbane



signature.asc
Description: This is a digitally signed message part
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org