Re: [389-devel] Please Review: Auto Membership Plug-in

2011-04-19 Thread Nathan Kinder

On 04/19/2011 01:50 PM, Noriko Hosoi wrote:

On 04/19/2011 01:44 PM, Nathan Kinder wrote:
I've attached a revised patch to address some comments given by 
Noriko.  The only differences here are in the plug-in close() 
function.  We free the config lock now, and we also check if the 
started flag was set before freeing any of the resources.


On 04/19/2011 08:52 AM, Nathan Kinder wrote:

http://directory.fedoraproject.org/wiki/Auto_Membership_Design


--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel



--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

Reviewed++.

Thanks for your review!  Pushed to master.

Counting objects: 42, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (23/23), done.
Writing objects: 100% (24/24), 17.83 KiB, done.
Total 24 (delta 15), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
   fe9b6a6..006083a  master -> master



--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel


--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please Review: Auto Membership Plug-in

2011-04-19 Thread Noriko Hosoi

On 04/19/2011 01:44 PM, Nathan Kinder wrote:
I've attached a revised patch to address some comments given by 
Noriko.  The only differences here are in the plug-in close() 
function.  We free the config lock now, and we also check if the 
started flag was set before freeing any of the resources.


On 04/19/2011 08:52 AM, Nathan Kinder wrote:

http://directory.fedoraproject.org/wiki/Auto_Membership_Design


--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel



--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

Reviewed++.
--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel