Re: [9fans] Ports tree for Plan 9

2015-05-29 Thread lucio
 Which version?
 
 The id_t and pid_t types shall be defined as described in  
 sys/types.h. in issue 6
 
 The sys/wait.h header shall define the id_t and pid_t types as  
 described in sys/types.h. in issue 7
 
 in the sys/wait.h part of the headers section of base definitions

I haven't looked at cinap's work, but...

It is the Plan 9 Way (TM) to avoid nested inclusion of header files,
although I guess the APE may be exempted.  I also appreciate that
adding conditional definitions of id_t and pid_t in sys/wait.h that
match those in sys/types.h could lead to eventual inconsistencies,
but I would still prefer to follow the Plan 9 guidelines.

But without a more formal code review structure and the apparent
absence of guidance from Bell Labs, I suppose I'm just farting in the
wind.

Lucio.




Re: [9fans] Ports tree for Plan 9

2015-05-29 Thread Álvaro Jurado
 It is the Plan 9 Way (TM) to avoid  nested inclusion of header files,

$ arch/dat.h includes port/portdat.h in kernel. Exempted too?

Álvaro Jurado Cuevas
http://colmenar.biz.tm
El 30/05/2015 07:11, lu...@proxima.alt.za escribió:

  Which version?
 
  The id_t and pid_t types shall be defined as described in
  sys/types.h. in issue 6
 
  The sys/wait.h header shall define the id_t and pid_t types as
  described in sys/types.h. in issue 7
 
  in the sys/wait.h part of the headers section of base definitions

 I haven't looked at cinap's work, but...

 It is the Plan 9 Way (TM) to avoid nested inclusion of header files,
 although I guess the APE may be exempted.  I also appreciate that
 adding conditional definitions of id_t and pid_t in sys/wait.h that
 match those in sys/types.h could lead to eventual inconsistencies,
 but I would still prefer to follow the Plan 9 guidelines.

 But without a more formal code review structure and the apparent
 absence of guidance from Bell Labs, I suppose I'm just farting in the
 wind.

 Lucio.





Re: [9fans] Ports tree for Plan 9

2015-05-29 Thread erik quanstrom
On Wed May 27 12:51:19 PDT 2015, cinap_len...@felloff.net wrote:
  A potential bug in APE sys/wait.h : the header does not make sure that 
  pid_t 
  has been defined.
  Compiling sbase on Plan9/APE ended up in situations where there were lots 
  of 
  compilation faliures simply because sys/wait.h was included without 
  sys/types.h being included before.
 
 fixed.

uh, i just read the open group spec.  i did not see the requirement that wait.h
define pid_t.  if someone could site chapter and verse, i would be happy to add
the include, but it would seem hasty without a standards citation.

- erik



Re: [9fans] ... and ##' stuff with pcc?

2015-05-29 Thread erik quanstrom
On Mon May 25 12:39:27 PDT 2015, staal1...@gmail.com wrote:

 Hi all.
 
 I tried using the following shim header to satisfy err.h in a package I
 want to build.
 
 https://raw.githubusercontent.com/libressl-portable/portable/master/include/err.h
 
 It looked pretty neat since it does everything in the header.
 
 It did however not work (I guess the ... and ## are to blame?) so now I
 wonder how/if it is possible with the posix compiler on plan9?

there are some errors in cpp.  a gsoc student looked at fixing them, but sadly
the straightforward fix ran into some other limitations of the code.

- erik



Re: [9fans] Ports tree for Plan 9

2015-05-29 Thread cinap_lenrek
i did a google search for it and found this:

http://pubs.opengroup.org/onlinepubs/007904975/basedefs/sys/wait.h.html

which stated:

The id_t and pid_t types shall be defined as described in sys/types.h.

and also looked in openbsd's sys/wait.h which did #include sys/types.h
which was good enougth for me, tho i'm not a unix expert.

--
cinap



Re: [9fans] Ports tree for Plan 9

2015-05-29 Thread Kurt H Maier

Quoting erik quanstrom quans...@quanstro.net:


On Wed May 27 12:51:19 PDT 2015, cinap_len...@felloff.net wrote:
 A potential bug in APE sys/wait.h : the header does not make sure  
that pid_t

 has been defined.
 Compiling sbase on Plan9/APE ended up in situations where there  
were lots of

 compilation faliures simply because sys/wait.h was included without
 sys/types.h being included before.

fixed.


uh, i just read the open group spec.  i did not see the requirement  
that wait.h
define pid_t.  if someone could site chapter and verse, i would be  
happy to add

the include, but it would seem hasty without a standards citation.

- erik


Which version?

The id_t and pid_t types shall be defined as described in  
sys/types.h. in issue 6


The sys/wait.h header shall define the id_t and pid_t types as  
described in sys/types.h. in issue 7


in the sys/wait.h part of the headers section of base definitions


khm