Re: webthumbnails patches merged
On Friday 04 May 2012 00:30:23 Sebastian Kügler wrote: > Hey all, > > A quick heads up. Today, I've merged the last bits necessary to have > thumbnails for webpages work out of the box. > > That means with the KDE/4.8 branch of kdelibs and master of kde-runtime, > webthumbnails work out of the box now. I've changed the preview dataengine > accordingly in plasma-mobile master. (Changes are backwards compatible.) > > The patch which adds a thumbnailer for webpages can thus be dropped. > Everything we need is now supported by the htmlthumbnail plugin, which is > also responsible for HTML files. It also uses webkit. > > Enjoy :) I actually do enjoy it! My Activity Screens look a lot nicer now that I have thumbnails again. :) ___ Active mailing list Active@kde.org https://mail.kde.org/mailman/listinfo/active
Re: webthumbnails patches merged
On Friday, May 04, 2012 12:30:34 Marco Martin wrote: > On Friday 04 May 2012, Sebastian Kügler wrote: > > > only one thing, now plasma-mobile depends on qt 4.8 due to > > > QUrl::isLocalFile() while on meego is still on 4.7 (we tried 4.8 but > > > didn't even boot anymore) > > > > > > > > QUrl::isLocalFile() is there since Qt 4.7, according to apidocs. > > but that seems the problem.. maybethe apidocs is wrong? > > > > now, would be needed to either workaround it, ifdef that or finally > > > decide to dump meego altogether > > > > > > > > What's the build problem? > > CMakeFiles/plasma_engine_active_apps.dir/groupssource.cpp.o -c > ../../../dataengines/apps/groupssource.cpp > ../../../dataengines/preview/previewcontainer.cpp: In member function 'void > PreviewContainer::mimetypeRetrieved(KIO::Job*, const QString&)': > ../../../dataengines/preview/previewcontainer.cpp:96:22: error: 'class > QUrl' has no member named 'isLocalFile' > make[2]: *** > [dataengines/preview/CMakeFiles/plasma_engine_preview.dir/previewcontainer.c > pp.o] Error 1 > > https://build.pub.meego.com/package/live_build_log?arch=i586&package=plasma- > mobile&project=Project%3AKDE%3ADevel&repository=MeeGo_1.2_OSS I've avoided QUrl::isLocalFile() for the time being, weird, though... -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Active mailing list Active@kde.org https://mail.kde.org/mailman/listinfo/active
Re: webthumbnails patches merged
On Friday 04 May 2012, Sebastian Kügler wrote: > > only one thing, now plasma-mobile depends on qt 4.8 due to > > QUrl::isLocalFile() while on meego is still on 4.7 (we tried 4.8 but > > didn't even boot anymore) > > QUrl::isLocalFile() is there since Qt 4.7, according to apidocs. but that seems the problem.. maybethe apidocs is wrong? > > now, would be needed to either workaround it, ifdef that or finally > > decide to dump meego altogether > > What's the build problem? CMakeFiles/plasma_engine_active_apps.dir/groupssource.cpp.o -c ../../../dataengines/apps/groupssource.cpp ../../../dataengines/preview/previewcontainer.cpp: In member function 'void PreviewContainer::mimetypeRetrieved(KIO::Job*, const QString&)': ../../../dataengines/preview/previewcontainer.cpp:96:22: error: 'class QUrl' has no member named 'isLocalFile' make[2]: *** [dataengines/preview/CMakeFiles/plasma_engine_preview.dir/previewcontainer.cpp.o] Error 1 https://build.pub.meego.com/package/live_build_log?arch=i586&package=plasma- mobile&project=Project%3AKDE%3ADevel&repository=MeeGo_1.2_OSS -- Marco Martin ___ Active mailing list Active@kde.org https://mail.kde.org/mailman/listinfo/active
Re: webthumbnails patches merged
On Friday, May 04, 2012 10:19:25 Marco Martin wrote: > On Friday 04 May 2012, Sebastian Kügler wrote: > > A quick heads up. Today, I've merged the last bits necessary to have > > thumbnails for webpages work out of the box. > > > > That means with the KDE/4.8 branch of kdelibs and master of kde-runtime, > > webthumbnails work out of the box now. I've changed the preview dataengine > > accordingly in plasma-mobile master. (Changes are backwards compatible.) > > > > The patch which adds a thumbnailer for webpages can thus be dropped. > > Everything we need is now supported by the htmlthumbnail plugin, which is > > also responsible for HTML files. It also uses webkit. > > hi, thanks for this > are all relevant patches on obs disabled? > > only one thing, now plasma-mobile depends on qt 4.8 due to > QUrl::isLocalFile() while on meego is still on 4.7 (we tried 4.8 but > didn't even boot anymore) QUrl::isLocalFile() is there since Qt 4.7, according to apidocs. > now, would be needed to either workaround it, ifdef that or finally decide > to dump meego altogether What's the build problem? -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Active mailing list Active@kde.org https://mail.kde.org/mailman/listinfo/active
Re: webthumbnails patches merged
On Friday 04 May 2012, Sebastian Kügler wrote: > Hey all, > > A quick heads up. Today, I've merged the last bits necessary to have > thumbnails for webpages work out of the box. > > That means with the KDE/4.8 branch of kdelibs and master of kde-runtime, > webthumbnails work out of the box now. I've changed the preview dataengine > accordingly in plasma-mobile master. (Changes are backwards compatible.) > > The patch which adds a thumbnailer for webpages can thus be dropped. > Everything we need is now supported by the htmlthumbnail plugin, which is > also responsible for HTML files. It also uses webkit. hi, thanks for this ;) are all relevant patches on obs disabled? only one thing, now plasma-mobile depends on qt 4.8 due to QUrl::isLocalFile() while on meego is still on 4.7 (we tried 4.8 but didn't even boot anymore) now, would be needed to either workaround it, ifdef that or finally decide to dump meego altogether -- Marco Martin ___ Active mailing list Active@kde.org https://mail.kde.org/mailman/listinfo/active
webthumbnails patches merged
Hey all, A quick heads up. Today, I've merged the last bits necessary to have thumbnails for webpages work out of the box. That means with the KDE/4.8 branch of kdelibs and master of kde-runtime, webthumbnails work out of the box now. I've changed the preview dataengine accordingly in plasma-mobile master. (Changes are backwards compatible.) The patch which adds a thumbnailer for webpages can thus be dropped. Everything we need is now supported by the htmlthumbnail plugin, which is also responsible for HTML files. It also uses webkit. Enjoy :) -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Active mailing list Active@kde.org https://mail.kde.org/mailman/listinfo/active
