Re: RFC: Enable core dumps even on 64-bit platforms

[Konstantin Serebryany]

On Sat, Jul 29, 2017 at 8:02 AM, Yuri Gribov  wrote:

> On Thu, Jul 27, 2017 at 10:51 PM, Konstantin Serebryany
>  wrote:
> > Just to make sure: all you are suggesting is to change the default
> value(s)
> > of flag(s), right?
>
> Yup.
>
> > I am reluctant to change the defaults here because core dumps are rarely
> > useful with asan reports and because they will cause more trouble then is
> > worth it (atexit timeout, disk full, etc)
>
> Well, maybe this isn't an issue with madv_dont_dump being default?
>

Given the amount of different environments where asan is used, almost any
kind of default flag change is a potential for a trouble.
We do it sometimes when there is a pressing need, but this one doesn't look
like one.

--kcc


>
> > On Wed, Jul 26, 2017 at 11:57 PM, Yuri Gribov 
> wrote:
> >>
> >> Hi all,
> >>
> >> Currently core dumps are disabled on 64-bit platforms. This decisions
> >> come from old times when 16 TB shadow memory was included in coredump.
> >> Nowadays we have use_madv_dontdump (enabled by default) which keeps
> >> size of core file reasonable. Perhaps we can disable disable_coredump
> >> on all platforms unconditionally? This is causing real usability
> >> issues (see
> >> https://stackoverflow.com/questions/45280910/gcc-
> address-sanitizer-core-dump-on-error).
> >>
> >> -I
> >>
> >> --
> >> You received this message because you are subscribed to the Google
> Groups
> >> "address-sanitizer" group.
> >> To unsubscribe from this group and stop receiving emails from it, send
> an
> >> email to address-sanitizer+unsubscr...@googlegroups.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "address-sanitizer" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to address-sanitizer+unsubscr...@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups
> "address-sanitizer" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to address-sanitizer+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"address-sanitizer" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RFC: Enable core dumps even on 64-bit platforms

[Yuri Gribov]

On Thu, Jul 27, 2017 at 10:51 PM, Konstantin Serebryany
 wrote:
> Just to make sure: all you are suggesting is to change the default value(s)
> of flag(s), right?

Yup.

> I am reluctant to change the defaults here because core dumps are rarely
> useful with asan reports and because they will cause more trouble then is
> worth it (atexit timeout, disk full, etc)

Well, maybe this isn't an issue with madv_dont_dump being default?

> On Wed, Jul 26, 2017 at 11:57 PM, Yuri Gribov  wrote:
>>
>> Hi all,
>>
>> Currently core dumps are disabled on 64-bit platforms. This decisions
>> come from old times when 16 TB shadow memory was included in coredump.
>> Nowadays we have use_madv_dontdump (enabled by default) which keeps
>> size of core file reasonable. Perhaps we can disable disable_coredump
>> on all platforms unconditionally? This is causing real usability
>> issues (see
>> https://stackoverflow.com/questions/45280910/gcc-address-sanitizer-core-dump-on-error).
>>
>> -I
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "address-sanitizer" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to address-sanitizer+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "address-sanitizer" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to address-sanitizer+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"address-sanitizer" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RFC: Enable core dumps even on 64-bit platforms

[Konstantin Serebryany]

Just to make sure: all you are suggesting is to change the default value(s)
of flag(s), right?

I am reluctant to change the defaults here because core dumps are rarely
useful with asan reports and because they will cause more trouble then is
worth it (atexit timeout, disk full, etc)

--kcc

On Wed, Jul 26, 2017 at 11:57 PM, Yuri Gribov  wrote:

> Hi all,
>
> Currently core dumps are disabled on 64-bit platforms. This decisions
> come from old times when 16 TB shadow memory was included in coredump.
> Nowadays we have use_madv_dontdump (enabled by default) which keeps
> size of core file reasonable. Perhaps we can disable disable_coredump
> on all platforms unconditionally? This is causing real usability
> issues (see https://stackoverflow.com/questions/45280910/gcc-
> address-sanitizer-core-dump-on-error).
>
> -I
>
> --
> You received this message because you are subscribed to the Google Groups
> "address-sanitizer" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to address-sanitizer+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"address-sanitizer" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RFC: Enable core dumps even on 64-bit platforms

[Yuri Gribov]

Hi all,

Currently core dumps are disabled on 64-bit platforms. This decisions
come from old times when 16 TB shadow memory was included in coredump.
Nowadays we have use_madv_dontdump (enabled by default) which keeps
size of core file reasonable. Perhaps we can disable disable_coredump
on all platforms unconditionally? This is causing real usability
issues (see 
https://stackoverflow.com/questions/45280910/gcc-address-sanitizer-core-dump-on-error).

-I

-- 
You received this message because you are subscribed to the Google Groups 
"address-sanitizer" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.