Re: 2 places that might need fix
Jijun Wang wrote:
Hello:
1)
trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\util\JavaIntrospector.java
contains 2 classes: JavaIntrospector and GenericBeanInfo(which claims
to be package private). Should they be in separate file?
No. This class was written before inner classes existed.
GenericBeanInfo should be a private static inner class, which
implemantation-wise is essentially the same thing, but clearer.
2) In
org.apache.myfaces.trinidadinternal.ui.ClassRendererInstantiator.instantiate():
...
catch (ClassNotFoundException cnfe)
{
_showInstantiationError(cnfe);
throw new UndeclaredThrowableException( cnfe,
"Instantiation of UIX Components Renderer failed, class " +
_className + " not found.");
}
...
Parameters for the exception looks like reversed. There is only
(String, Throwable) but no (Throwable, String)
/**
* Constructs an UndeclaredThrowableException with the
* specified Throwable and a detail message.
*
* @paramundeclaredThrowable the undeclared checked exception
*that was thrown
* @params the detail message
*/
public UndeclaredThrowableException(Throwable undeclaredThrowable,
String s)
The code wouldn't have compiled if there wasn't an appropriate constructor.
-- Blake Sullivan
Could anyone who is familiar with the code tell me if these two need
to be fixed? Thanks.
[READ] mailing lists (was Re: [Announce] Mailinglists)
a reminder to use the myfaces lists! http://myfaces.apache.org/mail-lists.html On 5/8/07, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: a reminder to use the myfaces lists! http://myfaces.apache.org/mail-lists.html -M On 4/28/07, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > Hi all, > > as you noticed Trinidad graduated to be a subproject of Apache > MyFaces. That means these mailings aren't needed any more. > > We move forward to the larger users@ and dev@ MyFaces. Please > unsubscribe from the [EMAIL PROTECTED] lists and > subscribe for the corresponding lists inside of MyFaces. > > http://myfaces.apache.org/mail-lists.html > > How to use the MyFaces mailing lists? > If you have a question on how to use Trinidad. > Send a mail to [EMAIL PROTECTED] and use a [Trinidad] in the subject > > Are focused more on the development? > Send a mail to [EMAIL PROTECTED] and use a [Trinidad] in the subject > > (please be sure to subscribe before sending) > > The [EMAIL PROTECTED] list will not be removed within the next 72 > hours, but I hope they aren't "online" for a long timeframe. > > > Any questions? > > -Matthias > > -- > Matthias Wessendorf > http://tinyurl.com/fmywh > > further stuff: > blog: http://jroller.com/page/mwessendorf > mail: mwessendorf-at-gmail-dot-com > -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
