Re: [akka-user] ReadPrefered in FlexiMerge (akka-streams)

2015-04-14 Thread Roland Kuhn
The bug (yes, it is one) and the fix are here 
https://github.com/akka/akka/pull/17188. Thanks for the very good report, 
Johannes!

Regards,

Roland

 13 apr 2015 kl. 19:20 skrev Viktor Klang viktor.kl...@gmail.com:
 
 Is if(input eq p.priority) also true?
 
 On Mon, Apr 13, 2015 at 7:11 PM, Johannes Plapp johannes.pl...@gmail.com 
 mailto:johannes.pl...@gmail.com wrote:
 Hi,
 
 While implementing a FlexiMerge we stumbled on the following issue:
 
 override def initialState =
   State[T](ReadPreferred(p.priority, p.second)) {
 (ctx, input, element) =
   if(input == p.priority).. // always true
   ctx.emit(element)
   SameState
   }
 
 Even if ReadPrefered returns an element from the second input, the returned 
 input always equals the first one (p.priority).
 
 Is this intended behaviour? I also submitted a test covering this issue: 
 https://github.com/akka/akka/issues/17157 
 https://github.com/akka/akka/issues/17157
 
 Thanks, 
 Johannes Plapp
 
 -- 
  Read the docs: http://akka.io/docs/ http://akka.io/docs/
  Check the FAQ: 
  http://doc.akka.io/docs/akka/current/additional/faq.html 
  http://doc.akka.io/docs/akka/current/additional/faq.html
  Search the archives: https://groups.google.com/group/akka-user 
  https://groups.google.com/group/akka-user
 --- 
 You received this message because you are subscribed to the Google Groups 
 Akka User List group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to akka-user+unsubscr...@googlegroups.com 
 mailto:akka-user+unsubscr...@googlegroups.com.
 To post to this group, send email to akka-user@googlegroups.com 
 mailto:akka-user@googlegroups.com.
 Visit this group at http://groups.google.com/group/akka-user 
 http://groups.google.com/group/akka-user.
 For more options, visit https://groups.google.com/d/optout 
 https://groups.google.com/d/optout.
 
 
 
 -- 
 Cheers,
 √
 
 -- 
  Read the docs: http://akka.io/docs/ http://akka.io/docs/
  Check the FAQ: 
  http://doc.akka.io/docs/akka/current/additional/faq.html 
  http://doc.akka.io/docs/akka/current/additional/faq.html
  Search the archives: https://groups.google.com/group/akka-user 
  https://groups.google.com/group/akka-user
 --- 
 You received this message because you are subscribed to the Google Groups 
 Akka User List group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to akka-user+unsubscr...@googlegroups.com 
 mailto:akka-user+unsubscr...@googlegroups.com.
 To post to this group, send email to akka-user@googlegroups.com 
 mailto:akka-user@googlegroups.com.
 Visit this group at http://groups.google.com/group/akka-user 
 http://groups.google.com/group/akka-user.
 For more options, visit https://groups.google.com/d/optout 
 https://groups.google.com/d/optout.



Dr. Roland Kuhn
Akka Tech Lead
Typesafe http://typesafe.com/ – Reactive apps on the JVM.
twitter: @rolandkuhn
 http://twitter.com/#!/rolandkuhn

-- 
  Read the docs: http://akka.io/docs/
  Check the FAQ: 
 http://doc.akka.io/docs/akka/current/additional/faq.html
  Search the archives: https://groups.google.com/group/akka-user
--- 
You received this message because you are subscribed to the Google Groups Akka 
User List group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to akka-user+unsubscr...@googlegroups.com.
To post to this group, send email to akka-user@googlegroups.com.
Visit this group at http://groups.google.com/group/akka-user.
For more options, visit https://groups.google.com/d/optout.


[akka-user] ReadPrefered in FlexiMerge (akka-streams)

2015-04-13 Thread Johannes Plapp
Hi,

While implementing a FlexiMerge we stumbled on the following issue:

override def initialState =
  State[T](ReadPreferred(p.priority, p.second)) {
(ctx, input, element) =
  if(input == p.priority).. // always true
  ctx.emit(element)
  SameState
  }


Even if ReadPrefered returns an element from the second input, the returned 
input always equals the first one (p.priority).

Is this intended behaviour? I also submitted a test covering this issue: 
https://github.com/akka/akka/issues/17157

Thanks, 
Johannes Plapp

-- 
  Read the docs: http://akka.io/docs/
  Check the FAQ: 
 http://doc.akka.io/docs/akka/current/additional/faq.html
  Search the archives: https://groups.google.com/group/akka-user
--- 
You received this message because you are subscribed to the Google Groups Akka 
User List group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to akka-user+unsubscr...@googlegroups.com.
To post to this group, send email to akka-user@googlegroups.com.
Visit this group at http://groups.google.com/group/akka-user.
For more options, visit https://groups.google.com/d/optout.


Re: [akka-user] ReadPrefered in FlexiMerge (akka-streams)

2015-04-13 Thread Viktor Klang
Is if(input eq p.priority) also true?

On Mon, Apr 13, 2015 at 7:11 PM, Johannes Plapp johannes.pl...@gmail.com
wrote:

 Hi,

 While implementing a FlexiMerge we stumbled on the following issue:

 override def initialState =
   State[T](ReadPreferred(p.priority, p.second)) {
 (ctx, input, element) =
   if(input == p.priority).. // always true
   ctx.emit(element)
   SameState
   }


 Even if ReadPrefered returns an element from the second input, the
 returned input always equals the first one (p.priority).

 Is this intended behaviour? I also submitted a test covering this issue:
 https://github.com/akka/akka/issues/17157

 Thanks,
 Johannes Plapp

 --
  Read the docs: http://akka.io/docs/
  Check the FAQ:
 http://doc.akka.io/docs/akka/current/additional/faq.html
  Search the archives: https://groups.google.com/group/akka-user
 ---
 You received this message because you are subscribed to the Google Groups
 Akka User List group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to akka-user+unsubscr...@googlegroups.com.
 To post to this group, send email to akka-user@googlegroups.com.
 Visit this group at http://groups.google.com/group/akka-user.
 For more options, visit https://groups.google.com/d/optout.




-- 
Cheers,
√

-- 
  Read the docs: http://akka.io/docs/
  Check the FAQ: 
 http://doc.akka.io/docs/akka/current/additional/faq.html
  Search the archives: https://groups.google.com/group/akka-user
--- 
You received this message because you are subscribed to the Google Groups Akka 
User List group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to akka-user+unsubscr...@googlegroups.com.
To post to this group, send email to akka-user@googlegroups.com.
Visit this group at http://groups.google.com/group/akka-user.
For more options, visit https://groups.google.com/d/optout.