[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)
https://github.com/georgthegreat closed https://github.com/llvm/llvm-project/pull/80443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)
georgthegreat wrote: @ldionne, gentle ping https://github.com/llvm/llvm-project/pull/80443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)
georgthegreat wrote: @ldionne, gentle ping https://github.com/llvm/llvm-project/pull/80443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)
georgthegreat wrote: @ldionne, do you find @arichardson reasoning good enough to proceed with merging this PR? https://github.com/llvm/llvm-project/pull/80443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)
georgthegreat wrote: I am OK with fixing this particular guarantee with a test. However, I am not familiar with libc++ testset organization and I need to be guided. Could you, please, provide me with some clues to start wtih? https://github.com/llvm/llvm-project/pull/80443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)
georgthegreat wrote: I understand the _this will definitely break in the future without proper testing_, but libunwind does not experience frequent changes, so this might be a working soluiton even without explicit testing. https://github.com/llvm/llvm-project/pull/80443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)
georgthegreat wrote: We have pretty large codebase and we use custom command-graph based build system (consider bazel as a well-known example of such buld system). The system uses module as a basic unit, modules might depend one each other, dependencies might affect dependant modules (but not vise versa). In order to reduce the total size of the command graph, we would like to reduce the amount of `-I` flags induced by the most common modules. libunwind is one of such modules: almost every module transitively depend on it yet very little do include `unwind.h` directly. We include unwind.h using a repository-root-relative-path (i. e. `contrib/libs/libunwind/include/unwind.h`). Everything else just works if we apply this patch. https://github.com/llvm/llvm-project/pull/80443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)
https://github.com/georgthegreat created
https://github.com/llvm/llvm-project/pull/80443
We store libunwind code inside monorepo and would like to reduce the overall
amount of `-I` flags.
>From 3e8bbe318ebbd498a7457afee2192c47650b6dad Mon Sep 17 00:00:00 2001
From: Yuriy Chernyshov
Date: Fri, 2 Feb 2024 18:09:47 +0300
Subject: [PATCH] Use relative includes to allow source-based dependencies
without -I
---
libunwind/include/libunwind.h | 2 +-
libunwind/include/unwind.h| 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/libunwind/include/libunwind.h b/libunwind/include/libunwind.h
index b2dae8feed9a3..02739b384e9da 100644
--- a/libunwind/include/libunwind.h
+++ b/libunwind/include/libunwind.h
@@ -13,7 +13,7 @@
#ifndef __LIBUNWIND__
#define __LIBUNWIND__
-#include <__libunwind_config.h>
+#include "__libunwind_config.h"
#include
#include
diff --git a/libunwind/include/unwind.h b/libunwind/include/unwind.h
index b1775d3a3decc..1973c5826d3ca 100644
--- a/libunwind/include/unwind.h
+++ b/libunwind/include/unwind.h
@@ -13,7 +13,7 @@
#ifndef __UNWIND_H__
#define __UNWIND_H__
-#include <__libunwind_config.h>
+#include "__libunwind_config.h"
#include
#include
@@ -56,9 +56,9 @@ typedef enum {
typedef struct _Unwind_Context _Unwind_Context; // opaque
#if defined(_LIBUNWIND_ARM_EHABI)
-#include
+#include "unwind_arm_ehabi.h"
#else
-#include
+#include "unwind_itanium.h"
#endif
typedef _Unwind_Reason_Code (*_Unwind_Stop_Fn)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
