[libunwind] [llvm] [runtimes] remove workaround for old CMake when setting `--unwindlib=none` (PR #93429)
antmox wrote: I may be missing something, but it looks like the armv7m-picolibc-no-exceptions issue is still related to https://gitlab.kitware.com/cmake/cmake/-/issues/23454 I notice that once the `--unwindlib=none` flag is added to `CMAKE_REQUIRED_LINK_OPTIONS`, it is also added to ar commands during the next cmake tests (starting with `CXX_SUPPORTS_NOSTDLIBXX_FLAG`). Failing these tests will result in `fno-exceptions` not being used later This is probably due to the fact that for Armv7M-picolibc, `CMAKE_TRY_COMPILE_TARGET_TYPE` is set to `STATIC_LIBRARY` here: https://github.com/llvm/llvm-project/blob/main/libcxx/cmake/caches/Armv7M-picolibc.cmake#L7C35-L7C49 https://github.com/llvm/llvm-project/pull/93429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [llvm] [IR] Avoid creating icmp/fcmp constant expressions (PR #92885)
antmox wrote: Hello, some bots are broken after this patch: - https://lab.llvm.org/buildbot/#/builders/245/builds/24889 - https://lab.llvm.org/buildbot/#/builders/188/builds/46161 FAIL: Clang::weak-external.cpp Could you look at this ? https://github.com/llvm/llvm-project/pull/92885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [Clang][Sema] placement new initializes typedef array with correct size (PR #83124)
antmox wrote: hello, instantiate-new-placement-size.cpp also fails here : https://lab.llvm.org/buildbot/#/builders/188/builds/44501 https://github.com/llvm/llvm-project/pull/83124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)
antmox wrote: Hello @MaskRay @bazuzi, Looks like one of the commit ([Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin) broke the clang-arm64-windows-msvc-2stage bot here: https://lab.llvm.org/buildbot/#/builders/120/builds/6489 Old compiler-rt lib seems still used "--dependent-lib=clang_rt.builtins-aarch64.lib" https://github.com/llvm/llvm-project/pull/87866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[flang] [lldb] [openmp] [mlir] [clang] [libc] [libcxx] [compiler-rt] [llvm] [hwasan] Classify stack overflow, and use after scope (PR #76133)
antmox wrote: Hi, looks like patch broke 2 aarch64 bots: https://lab.llvm.org/buildbot/#/builders/185/builds/5675 https://lab.llvm.org/buildbot/#/builders/179/builds/8880 Could you please look at this? https://github.com/llvm/llvm-project/pull/76133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[mlir] [compiler-rt] [libc] [clang] [flang] [llvm] [openmp] [lldb] [hwasan] Respect strip_path_prefix printing locals (PR #76132)
antmox wrote: Hello, this patch broke several aarch64 bots: https://lab.llvm.org/buildbot/#/builders/198/builds/7522 https://lab.llvm.org/buildbot/#/builders/176/builds/7521 https://lab.llvm.org/buildbot/#/builders/197/builds/11545 https://lab.llvm.org/buildbot/#/builders/184/builds/8762 https://lab.llvm.org/buildbot/#/builders/185/builds/5675 Could you please look at this ? https://github.com/llvm/llvm-project/pull/76132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] Revert "[RISCV] Implement multi-lib reuse rule for RISC-V bare-metal … (PR #75789)
https://github.com/antmox closed https://github.com/llvm/llvm-project/pull/75789 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] Revert "[RISCV] Implement multi-lib reuse rule for RISC-V bare-metal … (PR #75789)
antmox wrote: I would like to revert this as several arm/aarch64 bots are broken by this patch. Do I have to first revert c7cdf3c or is it OK like this ? https://github.com/llvm/llvm-project/pull/75789 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] Revert "[RISCV] Implement multi-lib reuse rule for RISC-V bare-metal … (PR #75789)
https://github.com/antmox created https://github.com/llvm/llvm-project/pull/75789 …toolchain (#73765)" This reverts commit 111a2290650743b27f70f9b24618411e54493b59, as it broke several bots https://lab.llvm.org/buildbot/#/builders/245/builds/18162 https://lab.llvm.org/buildbot/#/builders/188/builds/39436 https://lab.llvm.org/buildbot/#/builders/187/builds/13723 https://lab.llvm.org/buildbot/#/builders/182/builds/8449 https://lab.llvm.org/buildbot/#/builders/198/builds/7438 https://lab.llvm.org/buildbot/#/builders/176/builds/7419 https://lab.llvm.org/buildbot/#/builders/186/builds/13781 https://lab.llvm.org/buildbot/#/builders/183/builds/18116 https://lab.llvm.org/buildbot/#/builders/197/builds/11410 https://lab.llvm.org/buildbot/#/builders/184/builds/8651 When reapplying, please take care of another commit that have been merged after this one: c7cdf3cd5d74 [clang] Use 'starts_with' instead of 'startswith' in Gnu.cpp (NFC) >From a8518cedb41a1aabd5dade1280cea27f961bf261 Mon Sep 17 00:00:00 2001 From: Antoine Moynault Date: Mon, 18 Dec 2023 12:27:42 + Subject: [PATCH] Revert "[RISCV] Implement multi-lib reuse rule for RISC-V bare-metal toolchain (#73765)" This reverts commit 111a2290650743b27f70f9b24618411e54493b59, as it broke several bots https://lab.llvm.org/buildbot/#/builders/245/builds/18162 https://lab.llvm.org/buildbot/#/builders/188/builds/39436 https://lab.llvm.org/buildbot/#/builders/187/builds/13723 https://lab.llvm.org/buildbot/#/builders/182/builds/8449 https://lab.llvm.org/buildbot/#/builders/198/builds/7438 https://lab.llvm.org/buildbot/#/builders/176/builds/7419 https://lab.llvm.org/buildbot/#/builders/186/builds/13781 https://lab.llvm.org/buildbot/#/builders/183/builds/18116 https://lab.llvm.org/buildbot/#/builders/197/builds/11410 https://lab.llvm.org/buildbot/#/builders/184/builds/8651 When reapplying, please take care of another commit that have been merged after this one: c7cdf3cd5d74 [clang] Use 'starts_with' instead of 'startswith' in Gnu.cpp (NFC) --- clang/lib/Driver/ToolChains/Gnu.cpp | 127 +- .../riscv-toolchain-gcc-multilib-reuse.c | 81 --- 2 files changed, 1 insertion(+), 207 deletions(-) delete mode 100644 clang/test/Driver/riscv-toolchain-gcc-multilib-reuse.c diff --git a/clang/lib/Driver/ToolChains/Gnu.cpp b/clang/lib/Driver/ToolChains/Gnu.cpp index 7f463ddd17d3d6..835215a83c4037 100644 --- a/clang/lib/Driver/ToolChains/Gnu.cpp +++ b/clang/lib/Driver/ToolChains/Gnu.cpp @@ -30,7 +30,6 @@ #include "llvm/Option/ArgList.h" #include "llvm/Support/CodeGen.h" #include "llvm/Support/Path.h" -#include "llvm/Support/RISCVISAInfo.h" #include "llvm/Support/VirtualFileSystem.h" #include "llvm/TargetParser/TargetParser.h" #include @@ -1716,129 +1715,6 @@ static void findCSKYMultilibs(const Driver &D, const llvm::Triple &TargetTriple, Result.Multilibs = CSKYMultilibs; } -/// Extend the multi-lib re-use selection mechanism for RISC-V. -/// This function will try to re-use multi-lib if they are compatible. -/// Definition of compatible: -/// - ABI must be the same. -/// - multi-lib is a subset of current arch, e.g. multi-lib=march=rv32im -/// is a subset of march=rv32imc. -/// - march that contains atomic extension can't reuse multi-lib that -/// doesn't have atomic, vice versa. e.g. multi-lib=march=rv32im and -/// march=rv32ima are not compatible, because software and hardware -/// atomic operation can't work together correctly. -static bool -selectRISCVMultilib(const MultilibSet &RISCVMultilibSet, StringRef Arch, -const Multilib::flags_list &Flags, -llvm::SmallVectorImpl &SelectedMultilibs) { - // Try to find the perfect matching multi-lib first. - if (RISCVMultilibSet.select(Flags, SelectedMultilibs)) -return true; - - Multilib::flags_list NewFlags; - std::vector NewMultilibs; - - llvm::Expected> ParseResult = - llvm::RISCVISAInfo::parseArchString( - Arch, /*EnableExperimentalExtension=*/true, - /*ExperimentalExtensionVersionCheck=*/false); - if (!ParseResult) { -// Ignore any error here, we assume it will be handled in another place. -consumeError(ParseResult.takeError()); -return false; - } - - auto &ISAInfo = *ParseResult; - - addMultilibFlag(ISAInfo->getXLen() == 32, "-m32", NewFlags); - addMultilibFlag(ISAInfo->getXLen() == 64, "-m64", NewFlags); - - // Collect all flags except march=* - for (StringRef Flag : Flags) { -if (Flag.starts_with("!march=") || Flag.starts_with("-march=")) - continue; - -NewFlags.push_back(Flag.str()); - } - - llvm::StringSet<> AllArchExts; - // Reconstruct multi-lib list, and break march option into separated - // extension. e.g. march=rv32im -> +i +m - for (const auto &M : RISCVMultilibSet) { -bool Skip = false; - -MultilibBuilder NewMultilib = -MultilibBuilder(M.gccSuffix(), M.osSuffix(), M
[clang] [RISCV] Implement multi-lib reuse rule for RISC-V bare-metal toolchain (PR #73765)
antmox wrote: Hello, looks like it broke some bots too: clang-aarch64-quick https://lab.llvm.org/buildbot/#/builders/188/builds/39436 clang-armv8-quick https://lab.llvm.org/buildbot/#/builders/245/builds/18162 https://github.com/llvm/llvm-project/pull/73765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [flang] [flang] Add dependent-lib option to flang -fc1 on Windows (PR #72121)
antmox wrote: hello! looks like this broke some bots: https://lab.llvm.org/buildbot/#/builders/175/builds/39052 https://lab.llvm.org/buildbot/#/builders/268/builds/2443 could it be the missing colon after REQUIRES in dependent-lib.f90 ? https://github.com/llvm/llvm-project/pull/72121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] Recommit "[Clang][RISCV] Introduce tuple types for RVV bfloat16 #72216" (PR #72370)
antmox wrote: @eopXD tested successfully, no failure with this commit https://github.com/llvm/llvm-project/pull/72370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] Revert "[Clang][RISCV] Introduce tuple types for RVV bfloat16 (#72216)" (PR #72367)
https://github.com/antmox approved this pull request. https://github.com/llvm/llvm-project/pull/72367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [Clang][RISCV] Introduce tuple types for RVV bfloat16 (PR #72216)
antmox wrote: This also broke several aarch64 bots: https://lab.llvm.org/buildbot/#/builders/245/builds/16676 https://lab.llvm.org/buildbot/#/builders/188/builds/37969 https://lab.llvm.org/buildbot/#/builders/198/builds/6244 https://lab.llvm.org/buildbot/#/builders/176/builds/6987 https://lab.llvm.org/buildbot/#/builders/186/builds/13185 https://lab.llvm.org/buildbot/#/builders/183/builds/17354 https://github.com/llvm/llvm-project/pull/72216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] fix test PR69717.cpp (PR #72134)
antmox wrote: did not wait for last tests. hope thats ok https://github.com/llvm/llvm-project/pull/72134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] fix test PR69717.cpp (PR #72134)
https://github.com/antmox closed https://github.com/llvm/llvm-project/pull/72134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] fix test PR69717.cpp (PR #72134)
antmox wrote: No problem, thanks : ) https://github.com/llvm/llvm-project/pull/72134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang] fix test PR69717.cpp (PR #72134)
https://github.com/antmox created https://github.com/llvm/llvm-project/pull/72134 Test still fail on ARM machine (no float_control support) >From ce6080bc9e245279a6f8fc7006b9932e4c9ab809 Mon Sep 17 00:00:00 2001 From: Antoine Moynault Date: Mon, 13 Nov 2023 16:35:50 + Subject: [PATCH] [clang] fix test PR69717.cpp --- clang/test/Sema/PR69717.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/test/Sema/PR69717.cpp b/clang/test/Sema/PR69717.cpp index 42a87bd1ac1ec8d..3d1290dcbc32b43 100644 --- a/clang/test/Sema/PR69717.cpp +++ b/clang/test/Sema/PR69717.cpp @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -verify -fsyntax-only %s +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -verify -fsyntax-only %s // REQUIRES: x86-registered-target // expected-no-diagnostics ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)
antmox wrote: Hi! This commit broke some armv8/armv7 bots: https://lab.llvm.org/buildbot/#/builders/245/builds/15263 https://lab.llvm.org/buildbot/#/builders/187/builds/13069 Int & Void* have the same size there, so no warning on bitfield-width.c:20. https://github.com/llvm/llvm-project/pull/68276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: antmox wrote: Hello, Looks like this also broke lldb-aarch64-windows bot: https://lab.llvm.org/buildbot/#/builders/219/builds/6012 ... https://lab.llvm.org/buildbot/#/builders/219/builds/6041 https://github.com/llvm/llvm-project/pull/65844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits