[dba-issues] [Issue 116214] Can't always save a default field value
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=116214 --- Additional comments from osn...@openoffice.org Tue Feb 1 11:04:12 + 2011 --- Hello, maybe I have found a similar problem with OOo-dev 3.4.0 DEV300m97 ( Build:9566 ) on a Mac ( OSX 10.6.5 ) : When I opened the attached database, - then I click on Tables ( in the Database window ), then on Table1 ( in the Tables Window) - then I open the Edit Windows ( menu Edit, submenu Edit...) - finally I click on the Field number and set the default value to 12 . Then if I close the Edit Windows, OO asks me if I want to save the DataBase, I say Yes and nothing happens ( ie. the Edit Windows remains open and the only solution to close this windows seems to remove the default value ) ... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 46315] Default values for a timestamp field in a table control is not consistent.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46315 --- Additional comments from osn...@openoffice.org Tue Feb 1 11:05:04 + 2011 --- Created an attachment (id=75743) the database file - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 116214] Can't always save a default field value
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=116214 --- Additional comments from osn...@openoffice.org Tue Feb 1 11:06:31 + 2011 --- Created an attachment (id=75744) the database file - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 46315] Default values for a timestamp field in a table control is not consistent.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=46315 --- Additional comments from osn...@openoffice.org Tue Feb 1 11:09:57 + 2011 --- Oops sorry, I added the attachment in the bad issue :-~ So the previous attachment and this message can be removed... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115096] filter: apple(pict): a pr oposition to draw thick lines/frames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115096 --- Additional comments from osn...@openoffice.org Mon Dec 6 12:58:14 + 2010 --- osnola-sj : Ok, no problem. In fact, I found the problematic function and I opened a new issue : http://www.openoffice.org/issues/show_bug.cgi?id=115917 . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115917] tools: bezier curve drawi ng and smoothness
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115917 Issue #|115917 Summary|tools: bezier curve drawing and smoothness Component|framework Version|1.0.0 Platform|Macintosh URL| OS/Version|All Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|cd Reported by|osnola --- Additional comments from osn...@openoffice.org Sat Dec 4 11:13:34 + 2010 --- To correct the smoothness of a bezier curve, the function impCorrectContinuity uses the actual point and the previous control point in order to define the position of the next control point, even if the vector between these two points is much smallest than the vector between the actual point and the next control point. This can lead to some odd drawing like in http://www.openoffice.org/nonav/issues/showattachment.cgi/75177/Image280.zoom.png ( see the last messages at the end of issue: http://www.openoffice.org/issues/show_bug.cgi?id=115096 ). Therefore, just a small proposition which first checks what is the longest vector and according to the result modifies the previous control point or the next control point. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115917] tools: bezier curve drawi ng and smoothness
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115917 --- Additional comments from osn...@openoffice.org Sat Dec 4 11:14:14 + 2010 --- Created an attachment (id=75236) the proposed patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115917] tools: bezier curve drawi ng and smoothness
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115917 --- Additional comments from osn...@openoffice.org Sat Dec 4 11:17:37 + 2010 --- Created an attachment (id=75237) the new Image280's result after applying this patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115096] filter: apple(pict): a pr oposition to draw thick lines/frames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115096 --- Additional comments from osn...@openoffice.org Tue Nov 30 11:37:54 + 2010 --- Many thanks for your help and reworking your previous patch No problem ; as these b2dpolygontools functions exist, it was quite natural to rewrite the patch to use them... I think the remaining problems with the arc can be traced back to void OutputDevice::DrawPolyLine where a conversion from b2dpolygon with double precision to a tools polygon with integer precision takes place. I dig a little more, and indeed the problem seems to come from OutputDevice::DrawPolyLine but I am not sure that the problem comes only from the double to int conversion: Ie. For the Arc: Pt=21x208, dim = 56x56, angl = 5.67232x0.0174534 b2dpolygontools generates the Polygon (*): Pt0:pos = 66.8725x175.88, prev = _, next = 67.858x177.287 Pt1:pos = 69.4974x180, prev = 68.6383x178.512, next = 74.6521x188.928 Pt2:pos = 77x208, prev = 77x197.691, next = 77x208.344 Pt3:pos = 76.9915x208.977, prev = 76.9975x208.634, next = _ which seems correct ; I will attach a picture which zooms the problematic arc, where I have added: - in blue the segments from the previous control point to position - and in green the segments from position to the next control point with the basic coordinate grid alignment. The picture made me think that OutputDevice::DrawPolyLine had used the next control point of Pt0 (instead of the previous control point of Pt1) to draw the second spline... (*) where - pos is the point obtained by poly.getB2DPoint(i) - prev is the point obtained by poly.getPrevControlPoint(i) - next is the point obtained by poly.getNextControlPoint(i) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115096] filter: apple(pict): a pr oposition to draw thick lines/frames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115096 --- Additional comments from osn...@openoffice.org Tue Nov 30 11:38:51 + 2010 --- Created an attachment (id=75177) a zoom of the small arc - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115096] filter: apple(pict): a pr oposition to draw thick lines/frames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115096 --- Additional comments from osn...@openoffice.org Mon Nov 29 11:08:13 + 2010 --- So a new version which uses the functions of b2dpolygontools which indeed simplifies a lot the code. The result between this version and the previous one seem quite similar except that in some case where b2dpolygontools seems to generate odd splines. Therefore I will also attach pict.bugs which contains two examples which seem to err a lot with the following extensions: - .pict: the original picture, - .pict.ascii: the picture parsing, - .pict.tiff: the quickdraw result, - .pict.old.png: my previous result when I generated by hand the splines, - .pict.new.png: the new result obtained with b2dpolygontools functions with a red grid to show coordinates. I dig a little to understand what happens: For Image280, the small arc around O does not look like a arc ; for the three arcs around O, the program constructs a B2DPolygon by calling tools::createPolygonFromEllipseSegment(Pt, dim[0], dim[1], angl[0], angl[1]); with Arc: Pt=21x210, dim=62x62, angl=5.60251x1.74846e-07 // Ok, the intermediate arc Arc: Pt=20x210, dim=89x89, angl=5.27089x5.61996 // Ok, the biggest arc Arc: Pt=21x208, dim=56x56, angl=5.67232x0.0174534 // the small arc which seems bugged For Image7239, there must be two ellipses (*) around B and J ; in these case, the program constructs the B2DPolygon by calling tools::createPolygonFromRect(Rect, 1., 1.); with RoundRect: Rect=125x33-143x56 // ellipse around B RoundRect: Rect=44x92-61x113 // ellipse around J so I guess that the problem was in b2dpolygontools, but I did not have time to dig further (*) in fact, the picture asks to clear two round rectangles with maximum round corners, which is a complicated way to define an ellipse - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115096] filter: apple(pict): a pr oposition to draw thick lines/frames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115096 --- Additional comments from osn...@openoffice.org Mon Nov 29 11:09:00 + 2010 --- Created an attachment (id=75159) the new proposed patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115096] filter: apple(pict): a pr oposition to draw thick lines/frames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115096 --- Additional comments from osn...@openoffice.org Mon Nov 29 11:10:15 + 2010 --- Created an attachment (id=75160) the new problematic pictures - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114361] Read Error with embedde d images in Writer
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114361 --- Additional comments from osn...@openoffice.org Mon Nov 29 14:22:47 + 2010 --- Just for note, I success to reproduce this bug on a mac OS X 10.6.5 ( **) with the following steps: - I open the odt file ARL_Workflow_User_Documentation.odt - I replace the title: The University of Texas at Austin \n Applied Research Laboratories by The University of Te xas at Austin \n Applied Research Laboratories - I save the file as ARL_Workflow_User_Documentation2.odt at this point, the pictures disappear in the Writer windows ( ie. the read error messages appear when I scroll to see a new page). - I replace again the title to The University of Te x as at Austin \n Applied Research Laboratories - I save the file as ARL_Workflow_User_Documentation3.odt The file ARL_Workflow_User_Documentation2.odt is ok , but the file ARL_Workflow_User_Documentation3.odt no longer contain any picture... (**) with DEV300_m88 and with DEV300_m94 ( compiled by hand on my compiler ). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 114361] Read Error with embedde d images in Writer
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114361 --- Additional comments from osn...@openoffice.org Mon Nov 29 14:25:41 + 2010 --- Created an attachment (id=75162) the resulting file: ARL_Workflow_User_Documentation3.odt - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115096] filter: apple(pict): a pr oposition to draw thick lines/frames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115096 --- Additional comments from osn...@openoffice.org Fri Nov 26 07:19:40 + 2010 --- Using createPolygonFromEllipse, createPolygonFromEllipseSegment, createPolygonFromRect seem effectively a good idea and will probably simplify the code. I will try to give some news next week ( ie. because of the last java update 1.6.0_22, my sources of OpenOffice no longer compile ; so before doing any test, I will need first to get again a working version, which may take some time :-~ ). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115096] filter: apple(pict): a pr oposition to draw thick lines/frames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115096 Issue #|115096 Summary|filter: apple(pict): a proposition to draw thick lines |/frames Component|framework Version|1.0.0 Platform|Macintosh URL| OS/Version|All Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|mba Reported by|osnola --- Additional comments from osn...@openoffice.org Sun Oct 17 09:11:40 + 2010 --- Actually, ipict.cxx draws the line and the shapes frame without using the pen size information (ie. it uses always a 1 pixel width to draw the curve ). A proposition to draw the line and the shape with thickness. Notes: - the shapes are now transformed in B2DPolygon ( which is in module basegfx ), so if filter CAN NOT DEPENT on basegfx, this proposition must be DISCARDED, - this patch CAN ONLY BE APPLIED AFTER applying http://www.openoffice.org/nonav/issues/showattachment.cgi/72019/ipict3.cxx.patch ( from http://www.openoffice.org/issues/show_bug.cgi?id=115029 ) - I have replaced circle/arc by cubic splines in order to represent them by a BD2Polygon ( using the same method than in http://whizkidtech.redprince.net/bezier/circle/ ), so their representations are no longer exact, - as the methods to draw the shape in OpenOffice are not the same than the Quickdraw routines, I try to do some compromises between drawing the exact Apple Pict shapes using a complex representations and drawing a approximated simple shapes, - in general, the obtained results seem better (ie. more faithful) than previously ( using my database of pictures), but I found a few Apple Pict where the opposite can be said ( mainly because some clipping regions are too big), - I add a note to explain the region format, but I do not add code because I do not know how to draw these regions. - I note a small bug when drawing some spline curves with small curvature radius, some cracks happen in the drawing ( but maybe it is limited to my version of OpenOffice ) and another one when drawing some basic B2DPolygon (ie. a little square in each corner is not drawn correctly ), - in the files' attachment, the original pict files will have extension .pict, their quickdraw representations will have extension .pict.tiff and the extension .pict.ascii correspond to a homemade parsing... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115096] filter: apple(pict): a pr oposition to draw thick lines/frames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115096 --- Additional comments from osn...@openoffice.org Sun Oct 17 09:12:25 + 2010 --- Created an attachment (id=72077) the proposed patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115096] filter: apple(pict): a pr oposition to draw thick lines/frames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115096 --- Additional comments from osn...@openoffice.org Sun Oct 17 09:17:35 + 2010 --- Created an attachment (id=72079) a pict where the result is worse than previously ( because of the clipping ) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115096] filter: apple(pict): a pr oposition to draw thick lines/frames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115096 --- Additional comments from osn...@openoffice.org Sun Oct 17 09:14:54 + 2010 --- Created an attachment (id=72078) some pictures which contain some lines/frames - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115096] filter: apple(pict): a pr oposition to draw thick lines/frames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115096 --- Additional comments from osn...@openoffice.org Sun Oct 17 09:19:04 + 2010 --- Created an attachment (id=72080) a pict to illustrate my spline bug ( each corner is composed of an unique spline curve) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115011] filter: iPict.cxx and the function ReadHeader
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115011 --- Additional comments from osn...@openoffice.org Wed Oct 13 08:08:27 + 2010 --- Created an attachment (id=72032) a new version where I add code to choose more surely between beginning position 0 and position 512 when the two positions are possible. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115029] filter: ipict.cxx, line a nd patterns
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115029 Issue #|115029 Summary|filter: ipict.cxx, line and patterns Component|framework Version|1.0.0 Platform|Macintosh URL| OS/Version|All Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|mba Reported by|osnola --- Additional comments from osn...@openoffice.org Tue Oct 12 09:11:01 + 2010 --- Actually, ipict.cxx ignores the actual pattern when we draw some lines or some shape's frames. A small proposal to modify the line color (using the pattern to define a new color) in these cases. minor modifications: - I change nActPenSize form USHORT to Size which is better if we want to draw wide line/frame ( and not only thin line as actually), - I create a function IsInvisible which tests if we are in postscript mode or if we draw a line/frame with nActPenSize == 0 . - I make some changes in order avoid drawing some shapes with transparent color... Note: - because we use thin line, the color's change are only infinitesimal... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115029] filter: ipict.cxx, line a nd patterns
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115029 --- Additional comments from osn...@openoffice.org Tue Oct 12 09:11:42 + 2010 --- Created an attachment (id=72019) the proposed patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115029] filter: ipict.cxx, line a nd patterns
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115029 --- Additional comments from osn...@openoffice.org Tue Oct 12 09:14:46 + 2010 --- Created an attachment (id=72020) Image55.pict: a picture, Image55.pict.tiff: same picture rendered with quickdraw, Image55.pict.ascii: a home-made parsing - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115011] filter: iPict.cxx and the function ReadHeader
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115011 Issue #|115011 Summary|filter: iPict.cxx and the function ReadHeader Component|framework Version|1.0.0 Platform|Macintosh URL| OS/Version|All Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|mba Reported by|osnola --- Additional comments from osn...@openoffice.org Mon Oct 11 09:29:06 + 2010 --- A small attempt to rewrite the function ReadHeader to make it more robust ( and a little more coherent ) . Note: - I try hard to accept the headers which were accepted by the previous version of this function; so some parts are not very logical, - I replace Rectangle( x1,y1, --x2, --y2 ) which does not make any sense by Rectangle( x1,y1, x2, y2 ), - I also remove a small commentary which can not be useful. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115011] filter: iPict.cxx and the function ReadHeader
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115011 --- Additional comments from osn...@openoffice.org Mon Oct 11 09:29:37 + 2010 --- Created an attachment (id=72011) the proposed patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115008] filter: Apple(pict) corre ction of a minor bug + code simplification
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115008 --- Additional comments from osn...@openoffice.org Sun Oct 10 09:58:49 + 2010 --- Created an attachment (id=72009) the proposed patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 115008] filter: Apple(pict) corre ction of a minor bug + code simplification
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115008 Issue #|115008 Summary|filter: Apple(pict) correction of a minor bug + code s |implification Component|framework Version|1.0.0 Platform|Macintosh URL| OS/Version|All Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|mba Reported by|osnola --- Additional comments from osn...@openoffice.org Sun Oct 10 09:58:12 + 2010 --- The opcode FrameRgn ( 0x80) was treated as FillRgn ; ie. it called ReadAndDrawRgn(PDM_FILL) instead of ReadAndDrawRgn(PDM_FRAME) ( a function which ignores the region :-~ ). Therefore a correction of this little bug with some code simplifications... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 114721] svtools: Apple Pict detec tor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114721 Issue #|114721 Summary|svtools: Apple Pict detector Component|framework Version|1.0.0 Platform|Macintosh URL| OS/Version|All Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|cd Reported by|osnola --- Additional comments from osn...@openoffice.org Fri Sep 24 10:23:36 + 2010 --- The files svtools/source/filter.vcl/filter/filter.cxx and filter/source/graphicfilter/ipict/ipict.cxx do not seem synchronized ; in particular (at least with my version of open office ), ipict.cxx accepts to parse standard apple pict ( version 1) while the filter.cxx detector rejects them. This means that a user can add a Apple Pict v.1 in a document ( if the filename has the good extension .pct ) and save the file ; when the user will open again his file, the picture will no longer be recognize. Note: - in fact, filter.cxx seems to try to detect Apple Pict v.1 but the test seems erroneous ( at least not standard). I keep this code in order to do not add some compatibility problems, - I add a test for version 1 picture ( the basic format and for the ``probability erroneous'' format ) to check that the picture bounding box is valid, - the same problem seems also to exist in svtools/source/filter.vcl/filter/filter2.cxx , but I do not propose a patch, because my OpenOffice version does not seem to use ipict.cxx to draw the picture, so I need to investigate a little more... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 114721] svtools: Apple Pict detec tor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114721 --- Additional comments from osn...@openoffice.org Fri Sep 24 10:24:15 + 2010 --- Created an attachment (id=71833) proposed patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 114721] svtools: Apple Pict detec tor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114721 --- Additional comments from osn...@openoffice.org Fri Sep 24 10:30:40 + 2010 --- Created an attachment (id=71835) Pict0.pct : a picture with good extension ( which can be included in a text document), Pict0.pict: same picture with bad extension (which is not recognized by the detector), test.odt : a empty text document where I added the picture Pict0.pct - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 114721] svtools: Apple Pict detec tor
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114721 --- Additional comments from osn...@openoffice.org Fri Sep 24 12:54:16 + 2010 --- Created an attachment (id=71837) the real file test.odt ( ie. sorry, the previous one does not contain Pict0.pct :-~ ) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113567] filter: Pict(apple) and P atterns
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113567 --- Additional comments from osn...@openoffice.org Thu Sep 23 06:13:51 + 2010 --- Oops sorry, the previous message concerns issue 113313: http://www.openoffice.org/issues/show_bug.cgi?id=113313 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113567] filter: Pict(apple) and P atterns
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113567 --- Additional comments from osn...@openoffice.org Wed Sep 22 15:39:43 + 2010 --- Do you need some files which contain some non standard ascii characters (ie. some characters with code 127 ) or which contain some Symbol characters ? ( ie. If needed, I can find some in my new ApplePict file database ...) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113886] filter: Pict(apple) and P ostscript instructions
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113886 --- Additional comments from osn...@openoffice.org Mon Aug 16 12:06:33 + 2010 --- Created an attachment (id=71125) fix of the proposed modification to avoid also drawing Postscript text - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113886] filter: Pict(apple) and P ostscript instructions
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113886 Issue #|113886 Summary|filter: Pict(apple) and Postscript instructions Component|framework Version|1.0.0 Platform|Macintosh URL| OS/Version|All Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|mba Reported by|osnola --- Additional comments from osn...@openoffice.org Sat Aug 14 08:15:39 + 2010 --- Postscript instructions can appear in a picture file ( in order to draw dotted lines, ... ) which makes ipict.cxx err. In this case, the file must also contain the corresponding basic quickdraw instructions. So a proposition to ignore such postscript commands (using ROP_1 mode to mark such instructions). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113886] filter: Pict(apple) and P ostscript instructions
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113886 --- Additional comments from osn...@openoffice.org Sat Aug 14 08:16:45 + 2010 --- Created an attachment (id=71105) proposed modification to ignore the Postscript instructions in a Pict(Apple) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113886] filter: Pict(apple) and P ostscript instructions
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113886 --- Additional comments from osn...@openoffice.org Sat Aug 14 08:19:02 + 2010 --- Created an attachment (id=71106) a small testcase: .pict (original), .tiff (converted on OS9 with Rosetta), .ascii ( a crude parsing of the picture) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113832] filter: Pict(apple) and R ounded Rectangles
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113832 Issue #|113832 Summary|filter: Pict(apple) and Rounded Rectangles Component|framework Version|1.0.0 Platform|Macintosh URL| OS/Version|All Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|mba Reported by|osnola --- Additional comments from osn...@openoffice.org Thu Aug 12 10:53:26 + 2010 --- When drawing a rounded rectangle, the corner's size is too big (ie. two times the normal size). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113832] filter: Pict(apple) and R ounded Rectangles
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113832 --- Additional comments from osn...@openoffice.org Thu Aug 12 10:55:05 + 2010 --- Created an attachment (id=71052) proposed modification to correct the rounded rectangle corners' size for a Pict(Apple) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113832] filter: Pict(apple) and R ounded Rectangles
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113832 --- Additional comments from osn...@openoffice.org Thu Aug 12 10:57:16 + 2010 --- Created an attachment (id=71053) a small testcase: .pict (original), .tiff (converted using NSImage: Mac API), .ascii ( a crude parsing of the picture) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113567] filter: Pict(apple) and P atterns
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113567 --- Additional comments from osn...@openoffice.org Wed Aug 4 06:23:06 + 2010 --- Created an attachment (id=70939) fix of the proposed modification to use an intermediate color to draw patterns for a Pict(Apple) (text/plain) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113567] filter: Pict(apple) and P atterns
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113567 Issue #|113567 Summary|filter: Pict(apple) and Patterns Component|framework Version|1.0.0 Platform|Macintosh URL| OS/Version|All Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|mba Reported by|osnola --- Additional comments from osn...@openoffice.org Sun Aug 1 07:31:08 + 2010 --- Ipict.cxx does not use read patterns when filling a shape, thus drawing some shapes can make disappear other shapes, texts, ... As the class VirtualDevice does not seem to contain methods to draw solid shape with patterns (or I do not find them), I propose to fill such shapes with an intermediate color ( ie. a color depending on the foregroundColor, the backgroundColor and the pattern). Note: - I do not change the code for line drawings (as they can not make disappear other shapes), - I modify the color used when we erase a shape without using patterns to use the background color and not the foregroundcolor, - I do not try to use the bitmap which can appear in a PixPat ; mainly, because I do not have enough picts which contains such PixPat, so I can not test the effects, and also because this will imply to create a new bitmap class. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113567] filter: Pict(apple) and P atterns
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113567 --- Additional comments from osn...@openoffice.org Sun Aug 1 07:32:46 + 2010 --- Created an attachment (id=70910) proposed modification to use an intermediate color to draw patterns for a Pict(Apple) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113567] filter: Pict(apple) and P atterns
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113567 --- Additional comments from osn...@openoffice.org Sun Aug 1 07:36:39 + 2010 --- Created an attachment (id=70911) a basic picture: .pict (original), .tiff (converted using NSImage: Mac API), .ascii ( a crude parsing of the picture) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113312] filter:
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=113312
Issue #|113312
Summary|filter:
Component|framework
Version|1.0.0
Platform|Macintosh
URL|
OS/Version|All
Status|UNCONFIRMED
Status whiteboard|
Keywords|
Resolution|
Issue type|PATCH
Priority|P3
Subcomponent|code
Assigned to|mba
Reported by|osnola
--- Additional comments from osn...@openoffice.org Wed Jul 21 09:26:00
+ 2010 ---
Hello,
by default, the text found in a PICT(Apple) seems to be read with
gsl_getSystemTextEncoding()'s encoding, which can give very odd
results...
So, a patch to revert to RTL_TEXTENCODING_APPLE_ROMAN if
gsl_getSystemTextEncoding() is not an apple encoding.
Note: I also make sure that the good encoding is used for symbol fonts and I
replace RTL_TEXTENCODING_SYMBOL by
RTL_TEXTENCODING_ADOBE_SYMBOL.
--- filter/source/graphicfilter/ipict/ipict.cxx.orig2010-03-13
00:08:17.0 +0100
+++ filter/source/graphicfilter/ipict/ipict.cxx 2010-07-21 11:06:23.0
+0200
@@ -146,9 +146,11 @@
void SetLineColor( const Color rColor );
void SetFillColor( const Color rColor );
+ // OSNOLA: returns the text encoding which must be used for system id
+ static rtl_TextEncoding GetTextEncoding (USHORT fId = 0x);
public:
- PictReader() {}
+ PictReader() { aActFont.SetCharSet(GetTextEncoding()); }
void ReadPict( SvStream rStreamPict, GDIMetaFile rGDIMetaFile );
// Liesst aus dem Stream eine Pict-Datei und fuellt das
GDIMetaFile
@@ -208,6 +210,42 @@
}
//=== Methoden von PictReader ==
+rtl_TextEncoding PictReader::GetTextEncoding (USHORT fId) {
+ static bool first = true;
+ static rtl_TextEncoding enc = RTL_TEXTENCODING_APPLE_ROMAN;
+ if (first) {
+rtl_TextEncoding def = gsl_getSystemTextEncoding();
+// we keep gsl_getSystemTextEncoding only if it is a mac encoding
+switch(def) {
+case RTL_TEXTENCODING_APPLE_ROMAN:
+case RTL_TEXTENCODING_APPLE_ARABIC:
+case RTL_TEXTENCODING_APPLE_CENTEURO:
+case RTL_TEXTENCODING_APPLE_CROATIAN:
+case RTL_TEXTENCODING_APPLE_CYRILLIC:
+case RTL_TEXTENCODING_APPLE_DEVANAGARI:
+case RTL_TEXTENCODING_APPLE_FARSI:
+case RTL_TEXTENCODING_APPLE_GREEK:
+case RTL_TEXTENCODING_APPLE_GUJARATI:
+case RTL_TEXTENCODING_APPLE_GURMUKHI:
+case RTL_TEXTENCODING_APPLE_HEBREW:
+case RTL_TEXTENCODING_APPLE_ICELAND:
+case RTL_TEXTENCODING_APPLE_ROMANIAN:
+case RTL_TEXTENCODING_APPLE_THAI:
+case RTL_TEXTENCODING_APPLE_TURKISH:
+case RTL_TEXTENCODING_APPLE_UKRAINIAN:
+case RTL_TEXTENCODING_APPLE_CHINSIMP:
+case RTL_TEXTENCODING_APPLE_CHINTRAD:
+case RTL_TEXTENCODING_APPLE_JAPANESE:
+case RTL_TEXTENCODING_APPLE_KOREAN:
+ enc = def; break;
+default: break;
+}
+first = false;
+ }
+ if (fId == 13) return RTL_TEXTENCODING_ADOBE_DINGBATS; // CHECKME
+ if (fId == 23) return RTL_TEXTENCODING_ADOBE_SYMBOL;
+ return enc;
+}
void PictReader::SetLineColor( const Color rColor )
{
@@ -615,7 +653,7 @@
while ( nLen 0 ( (unsigned char)sText[ nLen - 1 ] ) 32 )
nLen--;
sText[ nLen ] = 0;
- String aString( (const sal_Char*)sText, gsl_getSystemTextEncoding() );
+ String aString( (const sal_Char*)sText, aActFont.GetCharSet());//
OSNOLA: previous gsl_getSystemTextEncoding()
pVirDev-DrawText( Point( aTextPosition.X(), aTextPosition.Y() ),
aString );
return nDataLen;
}
@@ -1129,8 +1167,7 @@
else if (nUSHORT == 22) aActFont.SetFamily(FAMILY_MODERN);
else if (nUSHORT = 1023) aActFont.SetFamily(FAMILY_SWISS);
else aActFont.SetFamily(FAMILY_ROMAN);
- if ( nUSHORT == 23 ) aActFont.SetCharSet(
RTL_TEXTENCODING_SYMBOL );
- elseaActFont.SetCharSet( gsl_getSystemTextEncoding() );
+ aActFont.SetCharSet(GetTextEncoding(nUSHORT));
eActMethod=PDM_UNDEFINED;
nDataSize=2;
break;
@@ -1361,8 +1398,7 @@
else if (nUSHORT == 22) aActFont.SetFamily(FAMILY_MODERN);
else if (nUSHORT = 1023) aActFont.SetFamily(FAMILY_SWISS);
else aActFont.SetFamily(FAMILY_ROMAN);
- if (nUSHORT==23) aActFont.SetCharSet( RTL_TEXTENCODING_SYMBOL);
- else aActFont.SetCharSet( gsl_getSystemTextEncoding() );
+ aActFont.SetCharSet(GetTextEncoding(nUSHORT));
*pPict nByteLen; nLen=((USHORT)nByteLen)0x00ff;
pPict-Read( sFName, nLen );
sFName
[framework-issues] [Issue 113313] filter:
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=113313
Issue #|113313
Summary|filter:
Component|framework
Version|1.0.0
Platform|Macintosh
URL|
OS/Version|All
Status|UNCONFIRMED
Status whiteboard|
Keywords|
Resolution|
Issue type|PATCH
Priority|P3
Subcomponent|code
Assigned to|mba
Reported by|osnola
--- Additional comments from osn...@openoffice.org Wed Jul 21 09:26:25
+ 2010 ---
Hello,
by default, the text found in a PICT(Apple) seems to be read with
gsl_getSystemTextEncoding()'s encoding, which can give very odd
results...
So, a patch to revert to RTL_TEXTENCODING_APPLE_ROMAN if
gsl_getSystemTextEncoding() is not an apple encoding.
Note: I also make sure that the good encoding is used for symbol fonts and I
replace RTL_TEXTENCODING_SYMBOL by
RTL_TEXTENCODING_ADOBE_SYMBOL.
--- filter/source/graphicfilter/ipict/ipict.cxx.orig2010-03-13
00:08:17.0 +0100
+++ filter/source/graphicfilter/ipict/ipict.cxx 2010-07-21 11:06:23.0
+0200
@@ -146,9 +146,11 @@
void SetLineColor( const Color rColor );
void SetFillColor( const Color rColor );
+ // OSNOLA: returns the text encoding which must be used for system id
+ static rtl_TextEncoding GetTextEncoding (USHORT fId = 0x);
public:
- PictReader() {}
+ PictReader() { aActFont.SetCharSet(GetTextEncoding()); }
void ReadPict( SvStream rStreamPict, GDIMetaFile rGDIMetaFile );
// Liesst aus dem Stream eine Pict-Datei und fuellt das
GDIMetaFile
@@ -208,6 +210,42 @@
}
//=== Methoden von PictReader ==
+rtl_TextEncoding PictReader::GetTextEncoding (USHORT fId) {
+ static bool first = true;
+ static rtl_TextEncoding enc = RTL_TEXTENCODING_APPLE_ROMAN;
+ if (first) {
+rtl_TextEncoding def = gsl_getSystemTextEncoding();
+// we keep gsl_getSystemTextEncoding only if it is a mac encoding
+switch(def) {
+case RTL_TEXTENCODING_APPLE_ROMAN:
+case RTL_TEXTENCODING_APPLE_ARABIC:
+case RTL_TEXTENCODING_APPLE_CENTEURO:
+case RTL_TEXTENCODING_APPLE_CROATIAN:
+case RTL_TEXTENCODING_APPLE_CYRILLIC:
+case RTL_TEXTENCODING_APPLE_DEVANAGARI:
+case RTL_TEXTENCODING_APPLE_FARSI:
+case RTL_TEXTENCODING_APPLE_GREEK:
+case RTL_TEXTENCODING_APPLE_GUJARATI:
+case RTL_TEXTENCODING_APPLE_GURMUKHI:
+case RTL_TEXTENCODING_APPLE_HEBREW:
+case RTL_TEXTENCODING_APPLE_ICELAND:
+case RTL_TEXTENCODING_APPLE_ROMANIAN:
+case RTL_TEXTENCODING_APPLE_THAI:
+case RTL_TEXTENCODING_APPLE_TURKISH:
+case RTL_TEXTENCODING_APPLE_UKRAINIAN:
+case RTL_TEXTENCODING_APPLE_CHINSIMP:
+case RTL_TEXTENCODING_APPLE_CHINTRAD:
+case RTL_TEXTENCODING_APPLE_JAPANESE:
+case RTL_TEXTENCODING_APPLE_KOREAN:
+ enc = def; break;
+default: break;
+}
+first = false;
+ }
+ if (fId == 13) return RTL_TEXTENCODING_ADOBE_DINGBATS; // CHECKME
+ if (fId == 23) return RTL_TEXTENCODING_ADOBE_SYMBOL;
+ return enc;
+}
void PictReader::SetLineColor( const Color rColor )
{
@@ -615,7 +653,7 @@
while ( nLen 0 ( (unsigned char)sText[ nLen - 1 ] ) 32 )
nLen--;
sText[ nLen ] = 0;
- String aString( (const sal_Char*)sText, gsl_getSystemTextEncoding() );
+ String aString( (const sal_Char*)sText, aActFont.GetCharSet());//
OSNOLA: previous gsl_getSystemTextEncoding()
pVirDev-DrawText( Point( aTextPosition.X(), aTextPosition.Y() ),
aString );
return nDataLen;
}
@@ -1129,8 +1167,7 @@
else if (nUSHORT == 22) aActFont.SetFamily(FAMILY_MODERN);
else if (nUSHORT = 1023) aActFont.SetFamily(FAMILY_SWISS);
else aActFont.SetFamily(FAMILY_ROMAN);
- if ( nUSHORT == 23 ) aActFont.SetCharSet(
RTL_TEXTENCODING_SYMBOL );
- elseaActFont.SetCharSet( gsl_getSystemTextEncoding() );
+ aActFont.SetCharSet(GetTextEncoding(nUSHORT));
eActMethod=PDM_UNDEFINED;
nDataSize=2;
break;
@@ -1361,8 +1398,7 @@
else if (nUSHORT == 22) aActFont.SetFamily(FAMILY_MODERN);
else if (nUSHORT = 1023) aActFont.SetFamily(FAMILY_SWISS);
else aActFont.SetFamily(FAMILY_ROMAN);
- if (nUSHORT==23) aActFont.SetCharSet( RTL_TEXTENCODING_SYMBOL);
- else aActFont.SetCharSet( gsl_getSystemTextEncoding() );
+ aActFont.SetCharSet(GetTextEncoding(nUSHORT));
*pPict nByteLen; nLen=((USHORT)nByteLen)0x00ff;
pPict-Read( sFName, nLen );
sFName
[framework-issues] [Issue 113313] filter:
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113313 --- Additional comments from osn...@openoffice.org Wed Jul 21 09:28:21 + 2010 --- Created an attachment (id=70737) proposed modification to correct an encoding problem when reading a Pict(Apple) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 113312] filter:
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113312 User osnola changed the following: What|Old value |New value Summary|filter: |filter: --- Additional comments from osn...@openoffice.org Wed Jul 21 10:57:27 + 2010 --- Sorry, I duplicated by error this thread with 113313 (ie. http://www.openoffice.org/issues/show_bug.cgi? id=113313 ). So it can be closed... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
