[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 User msc changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from m...@openoffice.org Mon Aug 24 12:41:50 + 2009 --- verified in CWS dba32f find more information about this CWS, like when it is available in the master builds, in EIS, the Environment Information System: http://eis.services.openoffice.org/EIS2/cws.ShowCWS?Path=DEV300%2Fdba32f - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 User fs changed the following: What|Old value |New value Assigned to|fs|msc --- Additional comments from f...@openoffice.org Thu Aug 20 07:04:27 + 2009 --- fs-msc: please verify in CWS dba32f - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 --- Additional comments from f...@openoffice.org Thu Aug 20 07:07:00 + 2009 --- fs-msc: As said above -in the bug doc, a macro is assigned to the Document is closing event, which is wrong - it must be assigned to Document closed. Before the fix, this wasn't called, now it is. fs-thierrym: Offering the Document is closing event (which has a wrong name, see above) for the document itself is nonsense, strictly, there is no possibility that this is ever called, since by definition the document is already dead when it would need to be fired. However, Document closed works now. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 --- Additional comments from thier...@openoffice.org Thu Aug 20 09:13:56 + 2009 --- Thanks for your works and thoughts. The names of the events (as you said above) seems to be the problem. For me (a french people who speaks with some difficulty in english), Document closed means that the form is already closed so launching an embedded macro is a nonsense and Document is closing means the document is about to be closed so an embedded macro can be called. So in my humble opinion, perhaps the names should be reversed. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 --- Additional comments from f...@openoffice.org Thu Aug 20 09:55:33 + 2009 --- if you submit an issue requesting this reversal, I'm the first one to implement it :) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 --- Additional comments from thier...@openoffice.org Thu Aug 20 13:41:43 + 2009 --- thierrym-fs : So I submitted this issue to reverse the events names : issue 104364. Thank you. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 User fs changed the following: What|Old value |New value Target milestone|OOo 3.x |OOo 3.2 --- Additional comments from f...@openoffice.org Wed Aug 19 09:44:52 + 2009 --- targeting to 3.2, since the fix is part of a CWS aiming for this release - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 User fs changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from f...@openoffice.org Mon Aug 17 13:44:46 + 2009 --- okay, I committed the patch for objxtor.cxx (for notifying the event somewhat earlier) to CWS dba32f, and will ask QA to run automated tests regarding embedded objects. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 User fs changed the following: What|Old value |New value CC|'atjensen'|'atjensen,mav' --- Additional comments from f...@openoffice.org Thu Aug 13 09:02:28 + 2009 --- fs-mav: In SfxObjectShell::PrepareClose, the SFX_EVENT_PREPARECLOSEDOC event is not fired for embedded documents. It would be easy to change this, however, I do not know whether this is a good idea, so I'd be interested in your opinion. We could either say that this event is not supported for embedded documents (and thus database forms), in which case I should remove it from the Tools/Cusotmize UI. Alternatively, we could fix PrepareClose to fire the event earlier. I would prefer this approach, since it would add consistency: All other events (e.g. OnUnload, OnPrepareViewClosing, OnViewClosed) are also fired for embedded documents, so I do not see a reason why this shouldn't be the case for OnPrepareUnload. Please advice. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 --- Additional comments from f...@openoffice.org Thu Aug 13 09:21:17 + 2009 --- Argh! The Document closing event does not work for ordinary text documents, too :( - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 --- Additional comments from f...@openoffice.org Thu Aug 13 09:47:11 + 2009 --- Some terminology, as this is something which confused and mislead me, too: Document closed is the event which is fired when the document *is about to be closed*. Document is closing is the event which is fired when the document *has been closed*. (That's nothing the online help will tell you, sadly. And the wording, IMO, is most misleading here.) As a consequence, offering the Document is closing event in Tools/Customize, for a concrete given document, is questionable: When this event is fired, then the document is already dead, so you cannot call any macro code in this document, anymore. This is the reason why assigning a document-local macro to this event does not work at all. A second consequence is that in the attached database document, the macro needs to be assigned to the Document closed event in Tools/Customize. Sadly, this alone isn't enough to make it work, there's still the problem I mentioned above (internally the event is not fired at the moment, at least not for database forms). So, my suggestion here is: 1. Find a volunteer for submitting an issue requesting those event names being improved 2. Find a volunteer for submitting an issue requesting that the user is warned when she assigns a document-local macro to the Document is closing event, as this will never be executed. (Or prevent assigning document-local macros here at all, while global macros probably should still be allowed.) 3. Fix the issue that the Close document event is not fired for database forms (@mav: See my suggestion above, moving the notification of SFX_EVENT_PREPARECLOSEDOC up a few lines is sufficient here) I'd take 3. anybody for 1./2.? (Or anybody arguing that this is nonsense?) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 --- Additional comments from m...@openoffice.org Thu Aug 13 10:07:58 + 2009 --- I must confess I am also quite confused by events names now. Anyway I have nothing against activation of this event for embedded objects as well. We should only be sure that the applications do not do unnecessary actions in case of embedded object when the message has been sent. In other words the implementation should be carefully tested for all the kinds of embedded objects after the change is done. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 --- Additional comments from f...@openoffice.org Thu Aug 13 10:33:35 + 2009 --- We should only be sure that the applications do not do unnecessary actions in case of embedded object when the message has been sent. In other words the implementation should be carefully tested for all the kinds of embedded objects after the change is done. Sorry, I am a little bit lost here: Wwhat kind of testing do you mean here? In which circumstances does our application react on document events? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 --- Additional comments from f...@openoffice.org Thu Aug 13 10:40:49 + 2009 --- Grokking for SFX_EVENT_PREPARECLOSEDOC gives one occurrence, namely SwXAutoTextEntry::Notify, which looks as if it would be a good idea to fire this event for embedded documents (else SwXAutoTextEntry instances, if ever existent for such docs, might miss something). All other occurrences are trivial. Do you know of places in the OOo code which listen to the UNO events, instead of the SFX events? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 --- Additional comments from m...@openoffice.org Thu Aug 13 11:21:08 + 2009 --- Exactly, I have meant the implementations like the one in writer. I am not aware about an implementation that would catch the event in UNO format. Anyway, I would test the handling of the embedded objects during CWS testing, at least the related automated tests. Code review is good, but the review with testing is better. :) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 --- Additional comments from atjen...@openoffice.org Sat Jul 11 02:49:51 + 2009 --- Currently there are two different events one can assign to macros that may make sense here. 1 - From ToolsCustomize. Instead of selecting the events for the individual form if you select the events for the ODB file you find Closed a sub-component. An embedded form is a sub-compoenet in this context and the macro will be called when any form is closed. (or Query, Dataview, Report designer, etc) 2 - The dataform control also has two events than can be assigned to macros via the property editor. When unloading and Before unloading and a macro assigned to either will be called when the form is closed. So my question would be: Should the form also expose the Close event when embedded in an ODB file? If not then I would suggest to change this Issue to ask for the event entries to be removed from the Customize dialog when displayed for an embedded form. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 User atjensen changed the following: What|Old value |New value CC|''|'atjensen' --- Additional comments from atjen...@openoffice.org Sat Jul 11 02:50:17 + 2009 --- sorry - added self to CC - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 User msc changed the following: What|Old value |New value Assigned to|dbaneedsconfirm |fs Ever confirmed| |1 Status|UNCONFIRMED |NEW Target milestone|--- |OOo 3.x --- Additional comments from m...@openoffice.org Tue Jul 7 06:56:54 + 2009 --- confirm and reassign to the right developer. @fs: The macro is assign under TOOLS / CUSTOMIZE / EVENTS and not in the properties of the form. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 Issue #|103371 Summary|The event when you close a form doesn't launch an assi |gned macro Component|Database access Version|OOO310m11 Platform|Unknown URL| OS/Version|All Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|none Assigned to|dbaneedsconfirm Reported by|thierrym --- Additional comments from thier...@openoffice.org Mon Jul 6 22:07:44 + 2009 --- See my attachment : When you close this form, the macro ShowMessage should be launched (a message should appear). This macro is associated with the event onClose (Fermeture du document in french). Even if i associate this macro with an other event like onDeactivate (Désactivation du document in french), nothing happens. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[dba-issues] [Issue 103371] The event when you close a form doesn't launch an assigned macro
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103371 --- Additional comments from thier...@openoffice.org Mon Jul 6 22:09:17 + 2009 --- Created an attachment (id=63408) Base illustrating the issue - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org For additional commands, e-mail: issues-h...@dba.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
