[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 User sba changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from s...@openoffice.org Fri May 8 09:01:09 + 2009 --- OK in OOO310_m11 (OOo 3.1). Closed. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 User sba changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from s...@openoffice.org Fri Mar 20 16:46:58 + 2009 --- Verified in CWS fwk106. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 User ul changed the following: What|Old value |New value OtherIssuesDependingOnTh|98052 |95768,98052 is| | - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 User cd changed the following: What|Old value |New value Assigned to|cd|sba --- Additional comments from c...@openoffice.org Mon Mar 16 16:21:29 + 2009 --- cd->sba: Please verify. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 User cd changed the following: What|Old value |New value Status|STARTED |RESOLVED Resolution| |FIXED --- Additional comments from c...@openoffice.org Mon Mar 16 16:20:05 + 2009 --- cd: Fixed. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 User sba changed the following: What|Old value |New value IssuesThisDependsOn|95768 | - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 --- Additional comments from h...@openoffice.org Mon Mar 16 13:38:03 + 2009 --- code change reviewed => ok - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 User sba changed the following: What|Old value |New value IssuesThisDependsOn| |95768 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 User cd changed the following: What|Old value |New value Target milestone|OOo 3.2 |OOo 3.1 --- Additional comments from c...@openoffice.org Mon Mar 16 11:59:37 + 2009 --- cd: Set correct target. Approved as show stopper. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 --- Additional comments from w...@openoffice.org Mon Mar 16 08:45:05 + 2009 --- wuyan->cd,hdu: THANKS for the patch. Just as methioned aboved, much resource was consumed due to the KeyMapping ctor/dtor in the loop but I ignored that. Both the two solutions could solve this problem. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 User cd changed the following: What|Old value |New value Keywords|aqua, performance |aqua, performance, regress | |ion --- Additional comments from c...@openoffice.org Mon Mar 16 08:21:59 + 2009 --- cd->hdu: As discussed by phone. KeyMapping can be removed from the inner loop. You can also make this variable static. cd: Add regression keyword. Ok in OOo 3.0.1. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 User ericb changed the following: What|Old value |New value CC|'mod,wuy' |'ericb,mod,wuy' --- Additional comments from er...@openoffice.org Sat Mar 14 08:34:24 + 2009 --- +me on CC - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 --- Additional comments from er...@openoffice.org Sat Mar 14 08:34:03 + 2009 --- @hdu : I discussed the point two days ago with pl, and you come with a patch :) I'll test it immediately, because I'm very curious to see this problem solved. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 User mod changed the following: What|Old value |New value CC|'wuy' |'mod,wuy' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 User cd changed the following: What|Old value |New value CC|''|'wuy' Status|NEW |STARTED Target milestone|--- |OOo 3.2 --- Additional comments from c...@openoffice.org Fri Mar 13 10:13:42 + 2009 --- cd->wuyan: Could you please have a look at this issue. This is a performance problem for all platforms although the Mac is hurt most. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 User hdu changed the following: What|Old value |New value OtherIssuesDependingOnTh| |98052 is| | Keywords| |aqua, performance - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100172] performance: framework::K eyMapping should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100172 Issue #|100172 Summary|performance: framework::KeyMapping should be reused Component|framework Version|OOO310m5 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|code Assigned to|cd Reported by|hdu --- Additional comments from h...@openoffice.org Fri Mar 13 10:03:22 + 2009 --- While debugging into issue 98052 I noticed that a lot of cycles in that use case (first keypress in empty Writer) are completely wasted by framework::KeyMapping objects. Since the implementation of that class only seems to deal with constant data rebuilding the key<->name maps shouldn't be done each time. Also the query methods in that class should be const-ified, as they don't change the KeyMapping object. Maybe the class should be pImpled and the const pImpl-entation should be reused. Especially the method XCUBasedAcceleratorConfiguration::impl_ts_load() seems to be infamous for constructing/destructing the currently expensive KeyMapping object over and over. In the use case mentioned above (first keypress in Writer) this was done 5460 times!!! Here is a simple patch to reduce the thousands of invocations to one by reusing the (to-be const) object: --- a/framework/source/accelerators/acceleratorconfiguration.cxx +++ b/framework/source/accelerators/acceleratorconfiguration.cxx @@ -1287,1 +1287,1 @@ void XCUBasedAcceleratorConfiguration::impl_ts_load( sal_Bool bPreferred, const -KeyMapping aKeyMapping; +static KeyMapping aKeyMapping; - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
