[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 User sba changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from s...@openoffice.org Fri May 8 09:04:55 + 2009 --- OK in OOO310_m11 (OOo 3.1). Closed. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 User sba changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from s...@openoffice.org Fri Mar 20 16:47:23 + 2009 --- Verified in CWS fwk106. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 --- Additional comments from h...@openoffice.org Mon Mar 16 07:59:49 + 2009 --- @ericb: thanks for testing the fix. The problem really proves that one should never trust explanations for performance issues unless they have been analyzed. The two performance bugs mentioned were responsible for much more of the UI-delay than the real work (loading the spell-checker, hyphenator, grammar checker and keyboard shortcuts). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 User cd changed the following: What|Old value |New value CC|'ericb' |'ericb,wuy' --- Additional comments from c...@openoffice.org Mon Mar 16 08:19:23 + 2009 --- cd-hdu: We discussed by phone with as that moving the line out of the loop is an easy fix with is NOT dangerous. cd: Therefore approved by me and as. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 User cd changed the following: What|Old value |New value Keywords|aqua, performance |aqua, performance, regress | |ion --- Additional comments from c...@openoffice.org Mon Mar 16 08:20:28 + 2009 --- cd: Add regression keyword. Ok in OOo 3.0.1. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 User cd changed the following: What|Old value |New value Status|NEW |STARTED --- Additional comments from c...@openoffice.org Mon Mar 16 09:52:28 + 2009 --- cd: Started. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 User cd changed the following: What|Old value |New value Target milestone|--- |OOo 3.1 --- Additional comments from c...@openoffice.org Mon Mar 16 12:00:05 + 2009 --- cd: Set correct target. Approved as show stopper. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 User sba changed the following: What|Old value |New value IssuesThisDependsOn| |95768 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 --- Additional comments from h...@openoffice.org Mon Mar 16 13:42:09 + 2009 --- code change reviewed = ok Copying the locales into the vector seems like a waste of time too. Compared to the improvements by the current fix it is only a minor issue though. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 User sba changed the following: What|Old value |New value IssuesThisDependsOn|95768 | - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 User cd changed the following: What|Old value |New value Status|STARTED |RESOLVED Resolution| |FIXED --- Additional comments from c...@openoffice.org Mon Mar 16 16:20:50 + 2009 --- cd: Fixed. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 User cd changed the following: What|Old value |New value Assigned to|cd|sba --- Additional comments from c...@openoffice.org Mon Mar 16 16:21:49 + 2009 --- cd-sba: Please verify. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 User ul changed the following: What|Old value |New value OtherIssuesDependingOnTh|98052 |95768,98052 is| | - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 --- Additional comments from er...@openoffice.org Sat Mar 14 13:06:19 + 2009 --- +me on CC @hdu : I have tested this patch (with DEV300_m43) + the other patch found at issue 100172 : the change is really visible. thanks a lot !! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 User ericb changed the following: What|Old value |New value CC|''|'ericb' --- Additional comments from er...@openoffice.org Sat Mar 14 13:06:37 + 2009 --- . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 Issue #|100177 Summary|performance: impl_ts_getLocale result should be reused Component|framework Version|OOO310m5 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|code Assigned to|cd Reported by|hdu --- Additional comments from h...@openoffice.org Fri Mar 13 12:22:19 + 2009 --- While debugging into issue 98052 and issue 100172 it showed that the method impl_ts_getLocale() is reponsible for almost half of the multi-second wait because the underlying configmgr is so slow. The header file comments that We does not cache this value, because we are not listen for changes on the configuration layer ... but it is easily possible to reduce the 140 expensive invokations to 4 without loosing anything by moving the expensive call outside the inner loop in impl_ts_load(). On this dualcore 2GHz system the patch below saves more than a second: --- a/framework/source/accelerators/acceleratorconfiguration.cxx +++ b/framework/source/accelerators/acceleratorconfiguration.cxx @@ -1247,2 +1245,3 @@ css::uno::Sequence ::rtl::OUString lKeys = xAccess-getElementNames(); +const ::rtl::OUString sLocale = impl_ts_getLocale().toISO(); sal_Int32 nKeys = lKeys.getLength(); @@ -1264,1 +1262,1 @@ -if ( *pFound == impl_ts_getLocale().toISO() ) +if ( *pFound == sLocale ) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 User hdu changed the following: What|Old value |New value OtherIssuesDependingOnTh| |98052 is| | Keywords| |aqua, performance - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 100177] performance: impl_ts_getL ocale result should be reused
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 --- Additional comments from h...@openoffice.org Fri Mar 13 13:31:53 + 2009 --- s/sLocale/sCfgLocale/ - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
