[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 User sb changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from s...@openoffice.org Fri Sep 25 11:11:23 + 2009 --- . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 User mba changed the following: What|Old value |New value Assigned to|mba |sb --- Additional comments from m...@openoffice.org Tue Sep 1 10:29:41 + 2009 --- The code obviously works fine. Please have a look on the code and verify that the change is correct. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 User sb changed the following: What|Old value |New value Status|RESOLVED |REOPENED Resolution|FIXED | --- Additional comments from s...@openoffice.org Tue Sep 1 11:32:55 + 2009 --- @mba: The modification of idl/source/objects/bastype.cxx in http://hg.services.openoffice.org/hg/cws/mba32issues02/rev/53b0444724da is still not correct: - it fails to multiply the final result assigned to *pValue by nSign; - it arbitrarily fails for LONG_MIN; - technically speaking, it incurs undefined behavior when casting between long and unsigned long; - it violates our coding standards (tabs, C-style casts). As the only call to ReadRangeSvIdl is with nMin == 0, why not simply drop support for reading negative numbers in the first place and simplify accordingly? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 User sb changed the following: What|Old value |New value Assigned to|sb|mba Status|REOPENED |NEW --- Additional comments from s...@openoffice.org Tue Sep 1 11:34:00 + 2009 --- . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 --- Additional comments from m...@openoffice.org Tue Sep 1 11:58:03 + 2009 --- Good idea. :-) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=101455
--- Additional comments from m...@openoffice.org Tue Sep 1 12:14:12 +
2009 ---
So something like that:
static BOOL ReadRangeSvIdl( SvStringHashEntry * pName, SvTokenStream rInStm,
ULONG nMin, ULONG nMax, ULONG* pValue )
{
UINT32 nTokPos = rInStm.Tell();
SvToken * pTok = rInStm.GetToken_Next();
if( pTok-Is( pName ) )
{
BOOL bOk = TRUE;
BOOL bBraket = rInStm.Read( '(' );
if( bBraket || rInStm.Read( '=' ) )
{
short nSign = 1;
pTok = rInStm.GetToken_Next();
if( pTok-IsChar() pTok-GetChar() == '-' )
{
nSign = -1;
pTok = rInStm.GetToken_Next();
}
else if( pTok-IsChar() pTok-GetChar() == '+' )
pTok = rInStm.GetToken_Next();
if( pTok-IsInteger() )
{
if ( nSign == -1 )
return FALSE;
ULONG n = pTok-GetNumber();
if ( n = nMin n = nMax )
{
*pValue = n;
}
else
bOk = FALSE;
if( bOk bBraket )
bOk = rInStm.Read( ')' );
}
else
bOk = pTok-IsChar() pTok-GetChar() == ')';
}
if( bOk )
return TRUE;
}
rInStm.Seek( nTokPos );
return FALSE;
}
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org
-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 --- Additional comments from s...@openoffice.org Tue Sep 1 13:11:18 + 2009 --- @mba: looks better (it fails for input -0 for which the original would have succeeded, however, and it might make sense to drop scanning for '-' and having nSign in the code completely) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=101455
User mba changed the following:
What|Old value |New value
Status|NEW |RESOLVED
Resolution| |FIXED
--- Additional comments from m...@openoffice.org Tue Sep 1 14:54:32 +
2009 ---
OK, makes sense. Then it also makes sense not to look for brackets. Looks very
simple now and of course works. Please verify:
static BOOL ReadRangeSvIdl( SvStringHashEntry * pName, SvTokenStream rInStm,
ULONG nMin, ULONG nMax, ULONG* pValue )
{
UINT32 nTokPos = rInStm.Tell();
SvToken * pTok = rInStm.GetToken_Next();
if( pTok-Is( pName ) )
{
BOOL bOk = FALSE;
if( rInStm.Read( '=' ) )
{
pTok = rInStm.GetToken_Next();
if( pTok-IsInteger() )
{
ULONG n = pTok-GetNumber();
if ( n = nMin n = nMax )
{
*pValue = n;
bOK = TRUE;
}
}
}
if( bOk )
return TRUE;
}
rInStm.Seek( nTokPos );
return FALSE;
}
Now the method does much less than the old one, but everything needed at the
only place where it is used.
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org
-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 User mba changed the following: What|Old value |New value Assigned to|mba |sb --- Additional comments from m...@openoffice.org Tue Sep 1 14:55:57 + 2009 --- Code works in all tested modules. Please verify again. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 User sb changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from s...@openoffice.org Tue Sep 1 15:09:51 + 2009 --- yes, final version looks good---if n at calling site is changed from long to ULONG and code is actually committed ;) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 --- Additional comments from m...@openoffice.org Tue Sep 1 15:13:00 + 2009 --- Of course. :-) I will now push it to the outgoing repository. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 User mba changed the following: What|Old value |New value Status|NEW |STARTED --- Additional comments from m...@openoffice.org Fri Jun 26 08:35:27 + 2009 --- Fixed in CWS mba32issues02 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 User mba changed the following: What|Old value |New value Status|STARTED |RESOLVED Resolution| |FIXED --- Additional comments from m...@openoffice.org Fri Jun 26 13:09:08 + 2009 --- . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 User cmc changed the following: What|Old value |New value OtherIssuesDependingOnTh| |96084 is| | - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 Issue #|101455 Summary|Code in idl/source/objects/bastyp.cxx smells Component|framework Version|1.0.0 Platform|Unknown URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|code Assigned to|mba Reported by|mba --- Additional comments from m...@openoffice.org Thu Apr 30 12:12:07 + 2009 --- Found during review of a compiler warning patch: the code patche in issue 96834 does not look as if it does what it is meant to do. To verify the proposed changes, a test case is needed, means: idl files that can trigger the smelling code. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 User mba changed the following: What|Old value |New value Target milestone|--- |OOo 3.2 --- Additional comments from m...@openoffice.org Thu Apr 30 12:13:09 + 2009 --- Just to make hay while the sun shines: target 3.2 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 User cli changed the following: What|Old value |New value CC|'cloph,sb'|'cli,cloph,sb' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101455] Code in idl/source/object s/bastyp.cxx smells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101455 --- Additional comments from c...@openoffice.org Thu Apr 30 12:50:12 + 2009 --- Btw. translate the German comment... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
