[framework-issues] [Issue 105835] Improvement program broke n in DEV300_m58
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835 User of changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from o...@openoffice.org Fri Oct 16 14:19:56 + 2009 --- of: Improvement program gives results and can display them in OOo. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105835] Improvement program broke n in DEV300_m58
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835 --- Additional comments from f...@openoffice.org Thu Oct 15 06:55:09 + 2009 --- @fs: Could you please review the changes made in extensions/logging? Looks fine to me. Thanks for taking *this* road ;-) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105835] Improvement program broke n in DEV300_m58
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835 User b_michaelsen changed the following: What|Old value |New value Assigned to|b_michaelsen |of --- Additional comments from b_michael...@openoffice.org Thu Oct 15 18:36:03 + 2009 --- @of: reassigning, please verify - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105835] Improvement program broke n in DEV300_m58
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835 User b_michaelsen changed the following: What|Old value |New value CC|'fl,fma,fs,mav,of'|'fl,fma,fs,of' --- Additional comments from b_michael...@openoffice.org Wed Oct 14 10:19:22 + 2009 --- Separated out the zero length file issue as issue 105894 (might be a showstopper in itself, mav will investigate). Therefore removing mav from this issue. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105835] Improvement program broke n in DEV300_m58
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835 --- Additional comments from b_michael...@openoffice.org Wed Oct 14 11:48:25 + 2009 --- started work in cws oooimprovement5 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105835] Improvement program broke n in DEV300_m58
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835 --- Additional comments from f...@openoffice.org Wed Oct 14 12:16:36 + 2009 --- fs-b_michaelsen: sorry for the delay ... I'm somewhat undecided with respect to flush. Given that you say nobody currently calls XLogHandler::flush, it might be a good idea to add this to the publish call, just to catch the other occurrences where logger clients forgot the flush. On the other hand, it'd be somewhat hacky, as it would render XLogHandler::flush useless (it's effectively a no-op then). Given that the only existing client for XLogHandler::publish currently is the Logger implementation itself (http://svn.services.openoffice.org/opengrok/xref/Current%20%28trunk%29/extensions/source/logging/logger.cxx#224), I tend to think that EventLogger::impl_ts_logEvent_nothrow should not only call publish at each handler, but also flush. This way, it could be considered an implementation detail of the Logger implementation that publishing a record also means flushing all handlers where it was logged to. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105835] Improvement program broke n in DEV300_m58
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835 User ul changed the following: What|Old value |New value Target milestone|--- |OOo 3.2 --- Additional comments from u...@openoffice.org Wed Oct 14 13:50:36 + 2009 --- set target - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105835] Improvement program broke n in DEV300_m58
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835 User b_michaelsen changed the following: What|Old value |New value Status|STARTED |RESOLVED Resolution| |FIXED --- Additional comments from b_michael...@openoffice.org Wed Oct 14 14:40:38 + 2009 --- fixed in cws oooimprovement5 in revision 276854. @fs: Could you please review the changes made in extensions/logging? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105835] Improvement program broke n in DEV300_m58
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835 --- Additional comments from o...@openoffice.org Tue Oct 13 06:32:54 + 2009 --- @b_michaelsen: The csv file will be written when the office dies or when the logger will be disposed. I remember that the cws mhu20 has changed something in the file world. Perhaps you could ask mav for more information. May be you have to flush the stream. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105835] Improvement program broke n in DEV300_m58
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835 User oj changed the following: What|Old value |New value CC|'fl,of,oj'|'fl,fma,of,oj' --- Additional comments from o...@openoffice.org Tue Oct 13 11:58:52 + 2009 --- add fma on cc - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105835] Improvement program broke n in DEV300_m58
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835 User ul changed the following: What|Old value |New value OtherIssuesDependingOnTh| |9 is| | - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105835] Improvement program broke n in DEV300_m58
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835 User b_michaelsen changed the following: What|Old value |New value CC|'fl,fma,of,oj'|'fl,fma,fs,mav,of' --- Additional comments from b_michael...@openoffice.org Tue Oct 13 18:48:29 + 2009 --- Ok, The Improvement program itself is _not_ broken. Logging works. However, if the logfile (which is open for writing logdata) gets opened (via a normal file-url dispatch), strange things happen: - The file show up as having some weird binary content in OOo. However, when looking at the file with other tools (stat, cat, vim) the file shows up as empty (as expected). - When the loaded document (however it was imported) gets open, OOo _writes_ binary garbage into the logfile. This is without ever notifying the user that data is changed in the filesystem. So, as long as the data is not being looked at with OOo while logging, everything works. All this was tested with the latest fixes for the new buffered IO introduced with mhu20. Further investigation showed the following root causes: - Premature optimization in comphelper::UiEventslogger and logging::FileHandler skip flushing because they expect osl::File to be unbuffered. Currently nothing calls logging::FileHandler::flush(). @fs: Should logging::FileHandler::publish() do so, or is this client expected to explicitly call flush() on the FileHandler? - This leaves the logfile as an empty (zero byte) file. - OOo inappropriately handles zero byte files. If one clicks File-Open it shows an import dialog. Even if one presses Cancel the file gets overridden (with binary garbage/likely an empty storage). The same happens when the file is opened and closed (_without_ saving). Opening the file read-only fixes this for the usage tracking, but the issue is serious enough in itself. @mav: Please have a look. removing oj from cc as this is indeed not related to cws oj18. Adding mav to cc because of opening empty files issue. Adding fs to cc because of flush issue in logging::FileHandler. Should we separate the issues? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105835] Improvement program broke n in DEV300_m58
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835 Issue #|105835 Summary|Improvement program broken in DEV300_m58 Component|framework Version|DEV300m58 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|code Assigned to|b_michaelsen Reported by|b_michaelsen --- Additional comments from b_michael...@openoffice.org Mon Oct 12 16:04:21 + 2009 --- The Openoffice Improvement Program is broken in DEV300_m58, was fine in DEV300_m57. The log file only contains binary garbage. biased guess: Reason is somewhere in oj18, which is huge. @oj: Do you have a InstSet for oj18 to confirm this? I have had a look at the changes made, but that cws is huge. Just guessing one think to check for: Have all URLs passed on to the UiEventsLogger been passed through XURLTransformer-parseStrict, like they have been before? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105835] Improvement program broke n in DEV300_m58
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105835 User b_michaelsen changed the following: What|Old value |New value Status|NEW |STARTED Keywords| |regression, usagetracking --- Additional comments from b_michael...@openoffice.org Mon Oct 12 16:08:08 + 2009 --- added usagetracking, regression keywords - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
