[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 User tono changed the following: What|Old value |New value Status|RESOLVED |CLOSED --- Additional comments from t...@openoffice.org Wed May 5 02:58:21 + 2010 --- Closing. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 User ihi changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from i...@openoffice.org Thu Mar 4 12:36:45 + 2010 --- fixed in DEV300 m74 master - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 --- Additional comments from m...@openoffice.org Wed Mar 3 08:09:13 + 2010 --- Created an attachment (id=68121) patch to fix the build breaker - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 --- Additional comments from m...@openoffice.org Wed Mar 3 08:10:08 + 2010 --- I just verified my assumption that the problem was caused by a merging of several CWS. In my CWS svxsplit where I moved to definition of SID_SFX_START to svl/inc/svl/solar.hrc I couldn't reproduce the breaker, on the contrary: removing the definition of SID_SFX_START didn't compile, but adding an include for solar.hrc fixed that. So it seems that on m72 solar.hrc is included indirectly here. Anyway, the attached patch should fix that. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 User cmc changed the following: What|Old value |New value CC|'cmc,mba,mh' |'cmc,gh,mba,mh' --- Additional comments from c...@openoffice.org Wed Mar 3 12:10:09 + 2010 --- cmc-gh: Can rel-eng bung the above in as a masterfix then ? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 --- Additional comments from t...@openoffice.org Wed Mar 3 12:32:36 + 2010 --- I have found out that the inclusion of svl/solar.hrc is dependent to the use of precompiled headers. So the real solution is to explicitly include svl/solar.hrc and remove constant definitions. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 --- Additional comments from m...@openoffice.org Wed Mar 3 14:26:38 + 2010 --- Yes. :-) (see my patch) Indeed I didn't compile with PCH. Sorry, my fault. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 --- Additional comments from r...@openoffice.org Wed Mar 3 15:08:32 + 2010 --- mba: You are talking about including 'svl/solar.hrc', but you patch has '+#include svl/svtools.hrc'. Could you please clarify what's correct? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 User rt changed the following: What|Old value |New value CC|'cmc,gh,mba,mh' |'cmc,gh,ihi,mba,mh,rt' --- Additional comments from r...@openoffice.org Wed Mar 3 15:24:27 + 2010 --- When you're sure what to do please contact Ivo. He'll do a masterfix for upcoming m74 than. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 --- Additional comments from m...@openoffice.org Wed Mar 3 16:18:45 + 2010 --- Oops, yes: solar.hrc should be enough. I used svtools.hrc in compiling that itself includes solar.hrc. But for a minimum include solar.hrc would be better. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 --- Additional comments from t...@openoffice.org Tue Mar 2 12:14:08 + 2010 --- @cmc: I do not know why the builds on unix platforms do not break. Have you investigated it? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 User gh changed the following: What|Old value |New value Ever confirmed| |1 Status|UNCONFIRMED |NEW --- Additional comments from g...@openoffice.org Wed Mar 3 07:53:52 + 2010 --- If someone attaches a patch I will install it on the windows buildbot until discussion ends here and confirmed as it does break the buildbot - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 User mba changed the following: What|Old value |New value Assigned to|hr|mba --- Additional comments from m...@openoffice.org Mon Mar 1 11:13:35 + 2010 --- Reassigned again. :-) As the code didn't break in the CWS where the relocation has been done, there must have been a problem with a CWS integrated later. IMHO this needs investigation, perhaps more erros have been introduced, e.g. by inappropriate merge conflict handling. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 --- Additional comments from m...@openoffice.org Mon Mar 1 14:01:54 + 2010 --- The defines have been moved to svl/inc/svl/solar.hrc, yes, but that should be even better as now we can included the #define here instead of doing it twice. I'm confused as I can't see why the mentioned fix from Caolan was done: in m72 this file wasn't changed at all and all he did was replacing const USHORT declarations by #define macros. Can you please explain what exactly the problem is? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 --- Additional comments from c...@openoffice.org Mon Mar 1 14:12:00 + 2010 --- Can you please explain what exactly the problem is? See http://buildbot.go-oo.org/buildbot/builders/Windows-2003/ all m72 based workspaces are failing on the windows buildbot, e.g. e.g. http://buildbot.go-oo.org/buildbot/builders/Windows-2003/builds/877/steps/Compile/logs/stdio i.e. f:/termite/slavedir/win2003/workdir/framework/source/classes/addonmenu.cxx(67) : error C2220: warning treated as error - no 'object' file generated^M^M f:/termite/slavedir/win2003/workdir/framework/source/classes/addonmenu.cxx(67) : warning C4091: '' : ignored on left of 'const sal_uInt16' when no variable is declared^M^M f:/termite/slavedir/win2003/workdir/framework/source/classes/addonmenu.cxx(67) : error C2143: syntax error : missing ';' before 'constant'^M^M f:/termite/slavedir/win2003/workdir/framework/source/classes/addonmenu.cxx(67) : error C2059: syntax error : 'constant'^M^M Compiling: framework/source/classes/dmake: Error code 2, while making '../../wntmsci12.pro/slo/addonmenu.obj'^M which sort of suggests that there's something like #define SID_SFX_START somewhere or something of that nature. (If it doesn't happen locally on windows, perhaps its a parallel build or nodep issue seeing as the buildbot builds with build.pl --all nodep=TRUE -P2 -- -P2) My fix is only on a scratch workspace where I wanted to test the compilation of a proposed future version of hunspell on windows, so I just hacked in something to get the buildbot to compile the bit I was interested in checking built on windows) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 --- Additional comments from m...@openoffice.org Mon Mar 1 15:32:52 + 2010 --- So the correct fix (on m72) would be just to remove the #define of SID_SFX_START as obviously the definition in svl/inc/svl/solar.hrc is included here and interferes with the const declaration. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 --- Additional comments from m...@openoffice.org Mon Mar 1 15:33:46 + 2010 --- Sorry, not the #define, of course the declaration of the integer variable. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 User of changed the following: What|Old value |New value CC|'cmc,mba' |'cmc,mba,mh' Assigned to|tm|hr --- Additional comments from o...@openoffice.org Mon Mar 1 06:50:28 + 2010 --- reassigned - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 109670] Build breaker in framewor k/source/classes/addonmenu.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109670 Issue #|109670 Summary|Build breaker in framework/source/classes/addonmenu.cx |x Component|framework Version|DEV300m72 Platform|All URL| OS/Version|Windows, all Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P1 Subcomponent|code Assigned to|tm Reported by|tono --- Additional comments from t...@openoffice.org Sat Feb 27 23:55:49 + 2010 --- As the definition of SID_SFX_START macro has been relocated, the compilation of framework/source/classes/addonmenu.cxx breaks. I found it was fixed in cws hunspell129 by cmc, I think it better to be masterfixed. http://www.openoffice.org/servlets/ReadMsg?listName=allhgmsgNo=1203 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
