[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=80769 User oc changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from [EMAIL PROTECTED] Tue Feb 12 10:39:05 + 2008 --- closed because fix available in builds OOH680_m7 (OOo 2.4) and SRC680_m245 (OOo 3.0) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=80769 User oc changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from [EMAIL PROTECTED] Thu Aug 23 07:21:29 + 2007 --- verified in internal build cws_bfbasic - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=80769 User fs changed the following: What|Old value |New value Assigned to|fs|oc --- Additional comments from [EMAIL PROTECTED] Wed Aug 22 07:55:53 + 2007 --- fs-> oc: please verify in CWS bfbasic - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=80769 User fs changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Wed Aug 22 07:21:55 + 2007 --- fix committed in CWS bfbasic - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=80769 User oc changed the following: What|Old value |New value OtherIssuesDependingOnTh| |80294 is| | - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=80769 User oc changed the following: What|Old value |New value Priority|P3|P2 Target milestone|OOo 2.x |OOo 2.3 --- Additional comments from [EMAIL PROTECTED] Wed Aug 22 06:53:09 + 2007 --- adjusting prio and target 2.3 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=80769 --- Additional comments from [EMAIL PROTECTED] Wed Aug 22 06:31:10 + 2007 --- Thanks, Frank. Oliver, as Frank pointed out this issue is not new but IIRC it was not present in 2.2.x so it is a regression. In case Christian Guenther didn't complain we could add the patch to the CWS binfilterregression though it is already "ready for QA". Perhaps you can negotiate with Christian. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=80769 User fs changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |47694) sugegsted patch --- Additional comments from [EMAIL PROTECTED] Tue Aug 21 19:21:09 + 2007 --- Created an attachment (id=47694) sugegsted patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=80769 --- Additional comments from [EMAIL PROTECTED] Tue Aug 21 19:18:43 + 2007 --- Excellent analysis, I'd say. Going to attach a patch. Oliver, this patch can go into any version you like ... I'd fix this for 2.4, but if you need it earlier, tell me. (Though, the bug exists for quite a while now, and has never been noticed so far, so I assume it isn't that urgent.) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=80769 --- Additional comments from [EMAIL PROTECTED] Tue Aug 21 18:07:48 + 2007 --- I was too pessimistic. :-) All occurrences where either includes or code that was commented out. :-) So fixing the quoted methods is enough. Frank, please comment. Oliver, what about the target? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80769
--- Additional comments from [EMAIL PROTECTED] Tue Aug 21 18:01:37 +
2007 ---
This is the killer - together with another bug:
StarBASIC::StarBASIC( StarBASIC* p )
: SbxObject( String( RTL_CONSTASCII_USTRINGPARAM("StarBASIC") ) )
{
SetParent( p );
pLibInfo = NULL;
bNoRtl = bBreak = FALSE;
pModules = new SbxArray;
if( !GetSbData()->nInst++ ) // ***
{
pSBFAC = new SbiFactory;
AddFactory( pSBFAC );
pUNOFAC = new SbUnoFactory;
AddFactory( pUNOFAC );
pTYPEFAC = new SbTypeFactory;
AddFactory( pTYPEFAC );
pCLASSFAC = new SbClassFactory;
AddFactory( pCLASSFAC );
pOLEFAC = new SbOLEFactory;
AddFactory( pOLEFAC );
}
// pRtl = new SbiStdObject( String( RTL_CONSTASCII_USTRINGPARAM(RTLNAME)
), this );
// Suche ueber StarBASIC ist immer global
SetFlag( SBX_GBLSEARCH );
}
The marked line is an object that is shared between binfilter and "the other
code". So as soon as the first "sb" instance is created elsewhere binfilter
refuses to instantiate its own SbxFactories. So even fixing the first problem
(replacing SHL_PTR by a static pointer) is not enough. We need an own instance
counter for binfilter:
SbiGlobals* GetSbData()
{
SbiGlobals** pp = (SbiGlobals**) ::GetAppData( SHL_SBC );
SbiGlobals* p = *pp;
if( !p )
p = *pp = new SbiGlobals;
return p;
}
is the culprit - again a SHL_PTR problem.
grepping for "SHL_" in bf_basic showed me more of them. :-(
So I'm afraid that this will take some more work to do.
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80769
--- Additional comments from [EMAIL PROTECTED] Tue Aug 21 17:43:47 +
2007 ---
I found binfilter/bf_basic/source/sbx/sbxbase.cxx:
SbxAppData* GetSbxData_Impl()
{
#ifndef DOS
SbxAppData** ppData = (SbxAppData**) ::GetAppData( SHL_SBX );
SbxAppData* p = *ppData;
if( !p )
p = *ppData = new SbxAppData;
return p;
#else
SbxAppData** ppData;
SbxAppData* p;
p = *ppData = new SbxAppData;
return p;
#endif
}
That looks as if the "SHL_PTR" bug is not or only partially fixed.
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80769
User mba changed the following:
What|Old value |New value
Assigned to|as|fs
Keywords| |regression
--- Additional comments from [EMAIL PROTECTED] Tue Aug 21 17:36:24 +
2007 ---
Frank, this is a problem with the basic code you added to binfilter. If any
non-binfilter document has been created before the binfilter basic module is
dysfunctional. ("-enableautomation" errornouosly always creates an empty Writer
doc and so triggers the bug.)
The following code in binfilter/bf_basic/source/basmgr/basmgr.cxx:
BOOL BasicManager::HasBasicWithModules( const SotStorage& rStorage, const
String& rBaseURL )
{
if( !rStorage.IsStream( ManagerStreamName ) )
return FALSE;
StarBASIC* pDummyParentBasic = new StarBASIC();
BasicManager* pBasMgr = new BasicManager( (SotStorage&)rStorage, rBaseURL,
pDummyParentBasic );
BOOL bRet = FALSE;
USHORT nLibs = pBasMgr->GetLibCount();
for( USHORT nL = 0; nL < nLibs; nL++ )
{
BasicLibInfo* pInfo = pBasMgr->pLibs->GetObject( nL );
StarBASIC* pLib = pInfo->GetLib();
if( !pLib )
{
BOOL bLoaded = pBasMgr->ImpLoadLibary( pInfo, NULL, FALSE );
if( bLoaded )
pLib = pInfo->GetLib();
}
if( pLib )
{
SbxArray* pModules = pLib->GetModules();
if( pModules->Count() ) // ***
{
bRet = TRUE;
break;
}
}
}
delete pBasMgr;
return bRet;
}
always returns "FALSE" in the marked code line when the bug is triggered. This
is different if the binary document is the first to be loaded.
This reminds me of a problem with SHL_PTR in Basic but AFAIR it was fixed by
Carsten. So it seems that there is another global variable that is shared
between binfilter's basic and the "other one".
In result basic from binary files is always lost as soon as the first non-binary
file was loaded. I have no idea if this is a showstopper but surely it's a
regression.
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=80769 User oc changed the following: What|Old value |New value CC|''|'mba' --- Additional comments from [EMAIL PROTECTED] Tue Aug 21 12:37:37 + 2007 --- cc'ing mba - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=80769 User ab changed the following: What|Old value |New value Assigned to|ab|as --- Additional comments from [EMAIL PROTECTED] Fri Aug 17 12:33:00 + 2007 --- ab->as: According to gh -enableautomation is only used for low level things like different window manager handling for testtool. So the connection to macro import is unclear. Anyway this is done in the framework. Please have a look. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=80769 --- Additional comments from [EMAIL PROTECTED] Fri Aug 17 06:41:38 + 2007 --- Created an attachment (id=47581) Bugdoc with macro - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 80769] Macros will not be loaded if OOo is started with parameter
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=80769 Issue #|80769 Summary|Macros will not be loaded if OOo is started with param |eter Component|framework Version|680m225 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|code Assigned to|ab Reported by|oc --- Additional comments from [EMAIL PROTECTED] Fri Aug 17 06:39:10 + 2007 --- Start OOo with parameter -enableautomation and load attached bugdoc => there is no warning about the macro and the macro will not be loaded - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
