[framework-issues] [Issue 96155] desktop: dubious ||

2009-04-09 Thread dtardon
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96155


User dtardon changed the following:

What|Old value |New value

  Status|VERIFIED  |CLOSED





--- Additional comments from dtar...@openoffice.org Thu Apr  9 06:41:55 
+ 2009 ---
seen in DEV300_m45 and OOO310_m9

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 96155] desktop: dubious ||

2008-12-15 Thread cd
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96155


User cd changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from c...@openoffice.org Mon Dec 15 09:04:26 + 
2008 ---
cd: Verified.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 96155] desktop: dubious ||

2008-11-18 Thread cd
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96155


User cd changed the following:

What|Old value |New value

  Status|NEW   |STARTED





--- Additional comments from [EMAIL PROTECTED] Tue Nov 18 09:18:52 + 
2008 ---
cd-cmc: Thanks for your patch. I think it's obvious that your patch 2 is what
was intended. 

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[framework-issues] [Issue 96155] desktop: dubious ||

2008-11-18 Thread cd
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96155


User cd changed the following:

What|Old value |New value

  Status|STARTED   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from [EMAIL PROTECTED] Tue Nov 18 14:00:32 + 
2008 ---
cd: Fixed. Committed to CWS fwk95.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[framework-issues] [Issue 96155] desktop: dubious ||

2008-11-12 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96155


User cmc changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |57938)
but perhaps this wa
|  |s what was intended






--- Additional comments from [EMAIL PROTECTED] Wed Nov 12 14:33:57 + 
2008 ---
Created an attachment (id=57938)
but perhaps this was what was intended


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[framework-issues] [Issue 96155] desktop: dubious ||

2008-11-12 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96155


User cmc changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |57937)
makes current logic
|  | explicit






--- Additional comments from [EMAIL PROTECTED] Wed Nov 12 14:33:33 + 
2008 ---
Created an attachment (id=57937)
makes current logic explicit


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[framework-issues] [Issue 96155] desktop: dubious ||

2008-11-12 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96155


User cmc changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|  |96084
  is|  |





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[framework-issues] [Issue 96155] desktop: dubious ||

2008-11-12 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96155


User mba changed the following:

What|Old value |New value

 Assigned to|mba   |cd

Target milestone|---   |OOo 3.1





--- Additional comments from [EMAIL PROTECTED] Wed Nov 12 20:29:41 + 
2008 ---
Thanks for the patch, Caolan, I forward it to who IIRC wrote that code.

If I see your patch and your latest blog entries - do you have a new tool that
finds dubious if-statements? ;-)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[framework-issues] [Issue 96155] desktop: dubious ||

2008-11-12 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96155
 Issue #|96155
 Summary|desktop: dubious  ||
   Component|framework
 Version|DEV300m35
Platform|All
 URL|
  OS/Version|Linux
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|PATCH
Priority|P3
Subcomponent|code
 Assigned to|mba
 Reported by|cmc





--- Additional comments from [EMAIL PROTECTED] Wed Nov 12 14:32:42 + 
2008 ---
in desktop/source/offacc/acceptor.cxx

we have

if ((nArgs == 1   (aArguments[0] = bEnable) )
|| (nArgs == 2  (aArguments[1] = bEnable))
 bEnable )

by operator precedence that's equivalent to

if (
(nArgs == 1  (aArguments[0] = bEnable)) ||
((nArgs == 2  (aArguments[1] = bEnable))  bEnable)
   )

(as attachment 1 makes explicit if this is what we want)

But that looks sort of dubious, did we really mean

if (
(
 (nArgs == 1  (aArguments[0] = bEnable)) ||
 (nArgs == 2  (aArguments[1] = bEnable))
)  bEnable
   )

if so, then attachment 2 fixes this

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[framework-issues] [Issue 96155] desktop: dubious ||

2008-11-12 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96155





--- Additional comments from [EMAIL PROTECTED] Wed Nov 12 23:05:55 + 
2008 ---
No magic tool, except a recent gcc that spits out warnings on a few hundred of
these and these are the ones that look ambiguous to a human.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]