[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 --- Additional comments from m...@openoffice.org Thu Apr 30 06:17:32 + 2009 --- I think that the patched code is correct. But admittedly I don't know how to construct a situation where this is relevant at all. Why do you think that it is wrong? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 User cli changed the following: What|Old value |New value Assigned to|christianlins |cli Status|REOPENED |NEW --- Additional comments from c...@openoffice.org Thu Apr 30 09:38:35 + 2009 --- I can verify the applied patch, but I have no idea whether the code semantic is correct or not... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 --- Additional comments from m...@openoffice.org Thu Apr 30 09:58:34 + 2009 --- Yes, that's the problem. For now we don't need a case where the current code is responsible for a bug. OTOH if we just change it because it looks odd, there is a chance that we break something without even knowing about it. So before changing the code I would like to see a test case that shows that the current code is wrong and the proposed change makes it better. Unfortunately this may be some effort as this would require to construct a suitable set of input files that is able to trigger this code. So in case we agree that this is necessary, I would like to move that to a different CWS as mba32issues01 is hopefully done now and it contains some fixes that will get more complicated to integrate the longer we hold them back. OTOH removing the patch from the CWS doesn't make sense also as it doesn't break anything that isn't broken anyway and it fixes the compiler problem. @cloph: as you raised the doubt, are you fine with my proposal? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 --- Additional comments from s...@openoffice.org Thu Apr 30 11:20:59 + 2009 --- For what its worth, the attached idl.patch indeed looks wrong---but the whole code appears to be broken, anyway. The code in question is as follows: There are integers nMin (encoded as a long, it can be negative or non-negative), nMax (encoded as an ULONG, it must thus necessarily be non-negative, and is probably supposed to be no less than nMin), and N (encoded as nSign * n, where nSign is either +1 or -1, and n is an ULONG and thus non-negative). Now, what the code shall apparently do is store N in *pValue iff nMin = N = nMax. For this, the parentheses in the relevant sub-condition must be placed as nSign == 1 (n = 0x8000 || (long)n nMin) What the sub-condition shall apparently check is that if N is non-negative it also is no less than nMin. That means that n must either be greater than the largest possible long value (which is here, incorrectly, assumed to be 0x7FFF) or else be no less than nMin. However, there are at least three other things that also look wrong: - the 32-bit assumption that the largest possible long value is 0x7FFF; - mixing -(long)n = nMin and (long)n Min, i.e., confusion whether N = nMin or N nMin must hold; - forgetting to multiply by nSign when assigning (long)n to *pValue. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 --- Additional comments from cl...@openoffice.org Thu Apr 30 11:07:28 + 2009 --- The code just looks wrong to me as it is now. I still find it ambigous though and don't really consider this properly fixed. if the sign is -1 you check for foo -n=nMin , then when sign is 1 you check for bar - but in the end you don't care, since nnMin works as well. I have neither proof that the code is correct, nor that it is incorrect. My gut feeling is that if you do a check for sign=-1 ab -n=nMin, then you probably also want to check for sign=1 a=b nnMin as well. Either (sign=-1 foo) || (sign=+1 bar). and not: (sign=-1 foo) || ( (sign=+1 part1-of-bar) || part2-of-bar ) (Note the additional parentheses that strongly suggest another intention) And exactly that is why the compiler warning is useful, and fixing it by silencing the compiler warning without making the code clear is useless. Fixing it without adding a //FIXME: is this correct? - issue 96834 or similar is even worse IMHO. But well, as it doesn't change behaviour it is harmless to have it changed, I could live with it, but please add the FIXME or other marker. The warning-inducing code makes it apparent that there might be wrong logic/not what was intended. The fix hides this error, the code looks like it was intended. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 --- Additional comments from m...@openoffice.org Thu Apr 30 09:20:57 + 2009 --- Let's put it that way: We have a build break that should be fixed as soon as possible. The patch fixes the compile problem without changing the behavior of the code. So this is a step forward: it fixes the urgent problem without introducing a new one. You raised some doubts whether the code as it currently is (with or without the patch) is correct. This is a valid question that deserves an answer. Unfortunately there is no test case how we can verify the correctness of the proposed code change, so IMHO it's better to keep the code as it is now (just silencing the compiler, as you wrote). We can create a follow-up issue that asks for a check for correctness and that can be done once we have a test case to verify that. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 User mba changed the following: What|Old value |New value Assigned to|mba |christianlins --- Additional comments from m...@openoffice.org Wed Apr 29 18:39:16 + 2009 --- please verify in cws mba32issues01 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 User cloph changed the following: What|Old value |New value CC|'cloph,sb'|'cloph,mba,sb' Status|RESOLVED |REOPENED Keywords| |oooqa Resolution|FIXED | --- Additional comments from cl...@openoffice.org Wed Apr 29 19:38:41 + 2009 --- @mba Don't even bother answering the question. :-( Reopen. It just doesn't make sense to silence the compiler without actually cleaning up the statement. Ambiguity is NOT fixed. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 User cloph changed the following: What|Old value |New value CC|'sb' |'cloph,sb' --- Additional comments from cl...@openoffice.org Thu Mar 26 13:32:22 + 2009 --- Sure that the patch is correct? To me it doesn't really make it less ambiguous. if (long)nnMin it will make the whole if-clause true but the parentheses assign it to the preceding statement which is kind of void, isn't it? Before: ... || (nSign == 1 n = 0x800 || (long)n nMin) After (just to make the compiler happy, but not really make the statement clear): ... || ((nSign == 1 n = 0x800) || (long)n nMin) both are the same as (long)n nMin || ... || (nSign == 1 n = 0x800) Is this really intended? The initial grouping suggest something different... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 User cmc changed the following: What|Old value |New value OtherIssuesDependingOnTh| |96084 is| | - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 User mba changed the following: What|Old value |New value Status|STARTED |RESOLVED Resolution| |FIXED --- Additional comments from m...@openoffice.org Thu Feb 12 15:36:31 + 2009 --- fixed in CWS mba32issues01 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 User mba changed the following: What|Old value |New value Target milestone|OOo 3.1 |OOo 3.2 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 --- Additional comments from [EMAIL PROTECTED] Wed Dec 10 12:16:51 + 2008 --- Patch works well for DEV300_m37, too. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 User mba changed the following: What|Old value |New value Status|NEW |STARTED Target milestone|--- |OOo 3.1 --- Additional comments from [EMAIL PROTECTED] Sun Dec 7 14:02:19 + 2008 --- I see. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 --- Additional comments from [EMAIL PROTECTED] Sat Dec 6 17:54:12 + 2008 --- @mba: See cmc's activity at issue 96084 (and this issue is potentially a duplicate to one of the issues that tracker issue depends on): making the warning go away (by adding explicit braces) instead of just disabling it unearthed some errors in the code. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 User mba changed the following: What|Old value |New value CC|''|'sb' --- Additional comments from [EMAIL PROTECTED] Fri Dec 5 16:43:10 + 2008 --- Perhaps it makes sense to disable this warning. There is something called operator precedence and forcing developers to use braces even if they are not necessary looks exaggerated to me. (cc'ed Stephan as our ultimate authority if it comes to compiler warnings ;-)) I would expect to find loads of places where this warning would come up. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 Issue #|96834 Summary|Build breaks with warning error in idl bastype.cxx Component|framework Version|DEV300m36 Platform|PC URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P2 Subcomponent|code Assigned to|mba Reported by|christianlins --- Additional comments from [EMAIL PROTECTED] Wed Dec 3 10:07:41 + 2008 --- On Ubuntu Intrepid with gcc-4.3.2 (-Werror): Making: ../../unxlngi6.pro/obj/bastype.obj g++ -fmessage-length=0 -c -Os -fno-strict-aliasing -I. -I../../unxlngi6.pro/inc/objects -I../inc -I../../inc/pch -I../../inc -I../../unx/inc -I../../unxlngi6.pro/inc -I. -I/media/sdb1/buildbot/slavedir/ubuntu/workdir/solver/300/unxlngi6.pro/inc/stl -I/media/sdb1/buildbot/slavedir/ubuntu/workdir/solver/300/unxlngi6.pro/inc/external -I/media/sdb1/buildbot/slavedir/ubuntu/workdir/solver/300/unxlngi6.pro/inc -I/media/sdb1/buildbot/slavedir/ubuntu/workdir/solenv/unxlngi6/inc -I/media/sdb1/buildbot/slavedir/ubuntu/workdir/solenv/inc -I/media/sdb1/buildbot/slavedir/ubuntu/workdir/res -I/media/sdb1/buildbot/slavedir/ubuntu/workdir/solver/300/unxlngi6.pro/inc/stl -I/media/sdb1/buildbot/slavedir/ubuntu/workdir/solenv/inc/Xp31 -I/usr/lib/jvm/java-6-sun/include -I/usr/lib/jvm/java-6-sun/include/linux -I/usr/lib/jvm/java-6-sun/include/native_threads/include -I/usr/include -I/media/sdb1/buildbot/slavedir/ubuntu/workdir/solver/300/unxlngi6.pro/inc/offuh -I. -I../../res -I. -pipe -mtune=pentiumpro -fvisibility-inlines-hidden -Wall -Wextra -Wendif-labels -Wshadow -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Werror-DLINUX -DUNX -DVCL -DGCC -DC341 -DINTEL -DCVER=C341 -DNPTL -DGLIBC=2 -DX86 -D_PTHREADS -D_REENTRANT -DNEW_SOLAR -D_USE_NAMESPACE=1 -DSTLPORT_VERSION=400 -DHAVE_GCC_VISIBILITY_FEATURE -D__DMAKE -DUNIX -DCPPU_ENV=gcc3 -DGXX_INCLUDE_PATH=/usr/include/c++/4.3 -DSUPD=300 -DPRODUCT -DNDEBUG -DPRODUCT_FULL -DOSL_DEBUG_LEVEL=0 -DOPTIMIZE -DCUI -DSOLAR_JAVA -DIDL_COMPILER -fno-exceptions -DEXCEPTIONS_OFF -o ../../unxlngi6.pro/obj/bastype.o /media/sdb1/buildbot/slavedir/ubuntu/workdir/idl/source/objects/bastype.cxx cc1plus: warnings being treated as errors /media/sdb1/buildbot/slavedir/ubuntu/workdir/idl/source/objects/bastype.cxx: In function BOOL ReadRangeSvIdl(SvStringHashEntry*, SvTokenStream, long int, ULONG, long int*): /media/sdb1/buildbot/slavedir/ubuntu/workdir/idl/source/objects/bastype.cxx:75: Fehler: Klammern um innerhalb von || empfohlen dmake: Error code 1, while making '../../unxlngi6.pro/obj/bastype.obj' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 96834] Build breaks with warning error in idl bastype.cxx
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96834 --- Additional comments from [EMAIL PROTECTED] Wed Dec 3 10:08:08 + 2008 --- Created an attachment (id=58459) Patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
