[graphics-issues] [Issue 85921] impress: right click to ed it slide master
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=85921 User cmc changed the following: What|Old value |New value OtherIssuesDependingOnTh|90439 | is| | Status|VERIFIED |CLOSED --- Additional comments from c...@openoffice.org Tue May 12 21:56:16 + 2009 --- integrated DEV300_m48 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org For additional commands, e-mail: issues-h...@graphics.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[graphics-issues] [Issue 85921] impress: right click to ed it slide master
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=85921 User wg changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from w...@openoffice.org Mon Apr 27 11:32:03 + 2009 --- Verified in CWS. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org For additional commands, e-mail: issues-h...@graphics.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[graphics-issues] [Issue 85921] impress: right click to ed it slide master
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=85921 User af changed the following: What|Old value |New value Assigned to|af|wg --- Additional comments from a...@openoffice.org Fri Apr 24 11:32:50 + 2009 --- @wg: Please verify. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org For additional commands, e-mail: issues-h...@graphics.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[graphics-issues] [Issue 85921] impress: right click to ed it slide master
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=85921 User af changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from a...@openoffice.org Thu Apr 9 09:19:36 + 2009 --- Finally applied the patch (with some minor modifications) and the change described above. SVN revision is 270683. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org For additional commands, e-mail: issues-h...@graphics.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[graphics-issues] [Issue 85921] impress: right click to ed it slide master
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85921
User af changed the following:
What|Old value |New value
Target milestone|OOo 3.1 |OOo 3.2
--- Additional comments from a...@openoffice.org Tue Jan 20 12:23:28 +
2009 ---
I finally found the time to review the patch. Late again, I am terribly sorry.
Most of the patch looks good except for the part in MasterPagesSelector.cxx.
The handling of the SID_TP_EDIT_MASTER slot relies solely on the slide sorter
for switching to master mode and then for switching to the selected master page.
This is not the right way to do it. I am even surprised and, as the author of
the slide sorter, somewhat pleased that this works at all.
Better use something like the code below to handle the slot. It first
dispatches slot SID_MASTERPAGE (synchronously) to switch to master mode. After
that the XDrawController::setCurrentPage(.) method is used to switch to the
selected master page:
case SID_TP_EDIT_MASTER:
{
using namespace ::com::sun::star;
uno::Reference xSelectedMaster (
GetSelectedMasterPage()->getUnoPage(), uno::UNO_QUERY);
SfxViewFrame* pViewFrame = mrBase.GetViewFrame();
if (pViewFrame != NULL && xSelectedMaster.is())
{
SfxDispatcher* pDispatcher = pViewFrame->GetDispatcher();
if (pDispatcher != NULL)
{
USHORT nIndex = mpPageSet->GetSelectItemId();
pDispatcher->Execute(SID_MASTERPAGE, SFX_CALLMODE_SYNCHRON);
mpPageSet->SelectItem (nIndex);
mrBase.GetDrawController().setCurrentPage(xSelectedMaster);
}
}
break;
}
I have submitted issue 98272 for an assertion that is triggered when the
previews are created and that makes testing and debugging the code above harder
than necessary.
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org
-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
[graphics-issues] [Issue 85921] impress: right click to ed it slide master
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=85921 --- Additional comments from c...@openoffice.org Wed Jan 7 12:42:04 + 2009 --- How about 3.1, is this still going to make it ? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org For additional commands, e-mail: issues-h...@graphics.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[graphics-issues] [Issue 85921] impress: right click to ed it slide master
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=85921 --- Additional comments from [EMAIL PROTECTED] Mon Nov 17 10:54:23 + 2008 --- KA=>AF: any news on verifying the patch? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[graphics-issues] [Issue 85921] impress: right click to ed it slide master
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=85921 User cl changed the following: What|Old value |New value Assigned to|cl|af Target milestone|OOo 3.x |OOo 3.0 --- Additional comments from [EMAIL PROTECTED] Thu Feb 7 19:24:25 + 2008 --- looks good, af, please apply this patch. It would be cool if we hit ui freeze for 3.0. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[graphics-issues] [Issue 85921] impress: right click to ed it slide master
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=85921 User hub changed the following: What|Old value |New value CC|''|'hub' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[graphics-issues] [Issue 85921] impress: right click to ed it slide master
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=85921 User cgu changed the following: What|Old value |New value Assigned to|cgu |cl Target milestone|--- |OOo 3.x --- Additional comments from [EMAIL PROTECTED] Wed Feb 6 17:45:05 + 2008 --- Please have a look on this patch. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[graphics-issues] [Issue 85921] impress: right click to ed it slide master
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=85921 User cmc changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |51408) proposed patch --- Additional comments from [EMAIL PROTECTED] Wed Feb 6 16:37:02 + 2008 --- Created an attachment (id=51408) proposed patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[graphics-issues] [Issue 85921] impress: right click to ed it slide master
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=85921 Issue #|85921 Summary|impress: right click to edit slide master Component|Drawing Version|680m245 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|cgu Reported by|cmc --- Additional comments from [EMAIL PROTECTED] Wed Feb 6 16:36:36 + 2008 --- A quick straw poll in my work group shows that the ability to edit the master slide is just not easily found in the view menu. The first place that the majority look to find this functionality is by right clicking the relevant preview in the master section of slide panel hoping to see something there. So attached is a patch that lets us edit the slide master under the mouse if we're not in master view already and the slide master is an applied one. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
