[graphics-issues] [Issue 96083] goodies: dubious and ||

2009-05-05 Thread sj
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96083


User sj changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from s...@openoffice.org Tue May  5 15:16:18 + 
2009 ---
The patch has been verified by af in cws[impress169]

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 96083] goodies: dubious and ||

2009-03-23 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96083





--- Additional comments from c...@openoffice.org Mon Mar 23 11:56:03 + 
2009 ---
This patch didn't end up in integrated-DEV300m40 sjfixes10 

is it in some other workspace ? (eis doesn't list it anywhere)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 96083] goodies: dubious and ||

2009-03-23 Thread sj
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96083


User sj changed the following:

What|Old value |New value

Target milestone|OOo 3.1   |OOo 3.2





--- Additional comments from s...@openoffice.org Mon Mar 23 13:44:29 + 
2009 ---
s...@cmc: I am helpless, the patch does not make it into the master. I committed
the patch again in cws[impress169] rev 269872.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 96083] goodies: dubious and ||

2008-11-20 Thread sj
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96083


User sj changed the following:

What|Old value |New value

  Status|NEW   |RESOLVED

  Resolution|  |FIXED

Target milestone|---   |OOo 3.1





--- Additional comments from [EMAIL PROTECTED] Thu Nov 20 19:18:43 + 
2008 ---
This patch has been applied to cws[sjfixes10]

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[graphics-issues] [Issue 96083] goodies: dubious and ||

2008-11-17 Thread ka
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96083





--- Additional comments from [EMAIL PROTECTED] Mon Nov 17 10:38:15 + 
2008 ---
KA=SJ: could you verify this patch, please?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[graphics-issues] [Issue 96083] goodies: dubious and ||

2008-11-11 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96083
 Issue #|96083
 Summary|goodies: dubious  and ||
   Component|Drawing
 Version|DEV300m31
Platform|All
 URL|
  OS/Version|Linux
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|PATCH
Priority|P3
Subcomponent|code
 Assigned to|sj
 Reported by|cmc





--- Additional comments from [EMAIL PROTECTED] Tue Nov 11 09:09:52 + 
2008 ---
X  Y || Z
binds operator precedence-wise as...
(X  Y) || Z

There are three suspicious cases of this in goodies

i.e.

source/filter.vcl/eps/eps.cxx
while ( ( --nSecurityCount )  ( *pDest == ' ' ) || ( *pDest == 0x9 ) ) 
pDest++;

i.e. means...

while ( (( --nSecurityCount )  ( *pDest == ' ' )) || ( *pDest == 0x9 ) ) 
pDest++;


source/filter.vcl/ieps/ieps.cxx
while ( ( --nSecurityCount )  ( **pBuf == ' ' ) || ( **pBuf == 0x9 ) ) 
(*pBuf)++;

i.e. means

while ( (( --nSecurityCount )  ( **pBuf == ' ' )) || ( **pBuf == 0x9 ) )
(*pBuf)++;

and

if( bEnlarge 
rCropLeftTop.Width()  0 ||
rCropLeftTop.Height()  0 ||
rCropRightBottom.Width()  0 ||
rCropRightBottom.Height()  0 )

i.e. means

if( (bEnlarge 
rCropLeftTop.Width()  0) ||
rCropLeftTop.Height()  0 ||
rCropRightBottom.Width()  0 ||
rCropRightBottom.Height()  0 )

Those meanings look very suspicious to me, I suspect that the intention is as
the attached patch changes them to be.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[graphics-issues] [Issue 96083] goodies: dubious and ||

2008-11-11 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96083


User cmc changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |57865)
I bet this is what 
|  |we really mean






--- Additional comments from [EMAIL PROTECTED] Tue Nov 11 09:10:26 + 
2008 ---
Created an attachment (id=57865)
I bet this is what we really mean


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[graphics-issues] [Issue 96083] goodies: dubious and ||

2008-11-11 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96083


User cmc changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|  |96084
  is|  |





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]