[gsl-issues] [Issue 68978] X11SalGraphics::Init can g et called twice, but leaks memory

2006-10-18 Thread pl
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68978


User pl changed the following:

What|Old value |New value

  Status|VERIFIED  |CLOSED





--- Additional comments from [EMAIL PROTECTED] Wed Oct 18 01:14:48 -0700 
2006 ---
seen in 680m188

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[gsl-issues] [Issue 68978] X11SalGraphics::Init can g et called twice, but leaks memory

2006-09-08 Thread pl
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68978


User pl changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from [EMAIL PROTECTED] Fri Sep  8 04:50:11 -0700 
2006 ---
verified in CWS vcl65

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[gsl-issues] [Issue 68978] X11SalGraphics::Init can g et called twice, but leaks memory

2006-08-28 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68978


User hdu changed the following:

What|Old value |New value

  CC|''|'pl'

 Assigned to|pl|hdu

  OS/Version|Linux |Unix, X11

Target milestone|---   |OOo 2.1





--- Additional comments from [EMAIL PROTECTED] Mon Aug 28 00:14:29 -0700 
2006 ---
PL is still on vacation = reassigning

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[gsl-issues] [Issue 68978] X11SalGraphics::Init can g et called twice, but leaks memory

2006-08-28 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68978


User hdu changed the following:

What|Old value |New value

  Status|NEW   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from [EMAIL PROTECTED] Mon Aug 28 00:15:49 -0700 
2006 ---
Applied in CWS vcl65. Thanks for finding the problem and the patch!

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[gsl-issues] [Issue 68978] X11SalGraphics::Init can g et called twice, but leaks memory

2006-08-26 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68978
 Issue #|68978
 Summary|X11SalGraphics::Init can get called twice, but leaks m
|emory
   Component|gsl
 Version|OOo 2.0.3
Platform|All
 URL|
  OS/Version|Linux
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|PATCH
Priority|P3
Subcomponent|code
 Assigned to|pl
 Reported by|cmc





--- Additional comments from [EMAIL PROTECTED] Sat Aug 26 08:16:14 -0700 
2006 ---
i.e. in 

salvd.cxx

SalVirtualDevice* X11SalInstance::CreateVirtualDevice( SalGraphics* pGraphics,
long nDX, long nDY, USHORT nBitCount, const SystemGraphicsData *pData )

calls -
  else if( !pVDev-Init( pSalDisplay, nDX, nDY, nBitCount ) )

and then later calls

   pVDev-InitGraphics( pVDev );

But...

BOOL X11SalVirtualDevice::Init( SalDisplay *pDisplay, long nDX, long nDY,
USHORT nBitCount, Pixmap hDrawable, void* pRenderFormatVoid )

calls -  pGraphics_-Init( this, pColormap, bDeleteColormap );

and X11SalVirtualDevice::InitGraphics is also

calls -  pGraphics_-Init( this, pColormap, bDeleteColormap );

so X11SalGraphics::Init gets called twice and can leak some memory, patch
attached to make Double Init safe

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[gsl-issues] [Issue 68978] X11SalGraphics::Init can g et called twice, but leaks memory

2006-08-26 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68978


User cmc changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |38781)
patch to fix






--- Additional comments from [EMAIL PROTECTED] Sat Aug 26 08:16:29 -0700 
2006 ---
Created an attachment (id=38781)
patch to fix


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]