[gsl-issues] [Issue 108914] vcl: Lost mpGraphics in O utputDevice::ImplNewFont()
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108914 User hdu changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from h...@openoffice.org Tue Jun 1 11:56:50 + 2010 --- Got into DEV300_m75 = closing - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 108914] vcl: Lost mpGraphics in O utputDevice::ImplNewFont()
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108914 --- Additional comments from h...@openoffice.org Wed May 19 11:58:00 + 2010 --- Fix got into DEV300_m75, closing. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 108914] vcl: Lost mpGraphics in O utputDevice::ImplNewFont()
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108914 User hdu changed the following: What|Old value |New value Status|RESOLVED |VERIFIED Issue type|PATCH |TASK --- Additional comments from h...@openoffice.org Wed Feb 17 08:55:37 + 2010 --- . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 108914] vcl: Lost mpGraphics in O utputDevice::ImplNewFont()
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108914 User hdu changed the following: What|Old value |New value Status|STARTED |RESOLVED OS/Version|Linux |Unix, X11 Resolution| |FIXED Target milestone|--- |OOo 3.3 --- Additional comments from h...@openoffice.org Fri Feb 12 12:10:22 + 2010 --- CWS fchints01 now got the fix mentioned in the previous comment to prevent the downstream regression from hitting upstream. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 108914] vcl: Lost mpGraphics in O utputDevice::ImplNewFont()
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108914 --- Additional comments from h...@openoffice.org Thu Feb 4 09:55:35 + 2010 --- Except for a multi-threading problem with insufficient locking there is AFAIK no scenario which would change the mpGraphics inside an ImplNewFont(). There is no vdev created in any of the codepaths as the gcach_vdev was only used in the ancient SRD-codeline... RIP. So, if there really is a multi-threading problem with insufficient locking then the patch only works around some bad aspect but there are countless other scenarios that could fail. Is it possible that you could put a hardware watchpoint on who sets the mpGraphics to NULL while we are inside the ImplNewFont() method? The mentioned line SalGraphics* pGraphics = mpGraphics is ancient (=Y2K). In my experience such a line is the result of crunch mode before a release, where the changes are intented to be minimally- invasive. The goal was probably to make a free-standing function a member of the OutputDevice class to give it access to its other members... Didn't do much more code archeology on that line since the pre-OOo repo is not easily available. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 108914] vcl: Lost mpGraphics in O utputDevice::ImplNewFont()
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108914 User thb changed the following: What|Old value |New value CC|'pl,thb' |'cmc,pl,thb' Status|NEW |RESOLVED Resolution| |WORKSFORME --- Additional comments from t...@openoffice.org Thu Feb 4 11:05:17 + 2010 --- @hdu: sigh. you're completely right. the line in question was added by the issue 59127 cairo font patches here, I'm sorry to not have checked that before. @cmc @pl: still something to keep in mind though, there are a couple of other places in vcl with that suspicious VirtualDevice aVDev(1) line, and unguarded access to mpGraphics. Closing as worksforme. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 108914] vcl: Lost mpGraphics in O utputDevice::ImplNewFont()
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108914 User thb changed the following: What|Old value |New value Status|RESOLVED |CLOSED --- Additional comments from t...@openoffice.org Thu Feb 4 11:05:58 + 2010 --- . - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 108914] vcl: Lost mpGraphics in O utputDevice::ImplNewFont()
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108914 --- Additional comments from t...@openoffice.org Thu Feb 4 11:08:35 + 2010 --- Hm, that did not come out all too clear: @cmc: with the line in question, I was referring to the VirtualDevice aVDev(1) one, inside the FreetypeServerFont ctor - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 108914] vcl: Lost mpGraphics in O utputDevice::ImplNewFont()
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108914 User hdu changed the following: What|Old value |New value Status|CLOSED|REOPENED Resolution|WORKSFORME| --- Additional comments from h...@openoffice.org Thu Feb 4 11:44:36 + 2010 --- ooops, now that you mention it: the problematic change is already applied in CWS fchints01, which was about ready for QA... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 108914] vcl: Lost mpGraphics in O utputDevice::ImplNewFont()
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108914 User hdu changed the following: What|Old value |New value Status|REOPENED |STARTED --- Additional comments from h...@openoffice.org Thu Feb 4 12:20:18 + 2010 --- The easiest solution is probably to get the fonthint-attributes while we are in the SalGraphics layer and pass them down. This also avoid the (potentially expensive) creation of that particular VirtualDevice, which is just used for that purpose. Will do it in CWS fchints01. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 108914] vcl: Lost mpGraphics in O utputDevice::ImplNewFont()
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108914 Issue #|108914 Summary|vcl: Lost mpGraphics in OutputDevice::ImplNewFont() Component|gsl Version|OOO320m11 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|pl Reported by|pmladek --- Additional comments from pmla...@openoffice.org Wed Feb 3 17:34:12 + 2010 --- This bug is related to https://bugzilla.novell.com/show_bug.cgi?id=575698. The ReportBuilder crashed with our build. The mpGraphics pointer is lost in vcl/source/gdi/outdev3.cxx:3540 + method: OutputDevice::ImplNewFont() + line:ImplInitFont(); + called from: vcl/source/gdi/outdev3.cxx:6442 + method: OutputDevice::ImplLayout + line:if( !ImplNewFont() ) The method OutputDevice::ImplNewFont() has the following command on vcl/source/gdi/outdev3.cxx:3501: SalGraphics* pGraphics = mpGraphics; = the pointer mpGraphics is saved and used later = it is expected that it will be lost or modified My solution was to call ImplGetGraphics() in OutputDevice::ImplLayout when the pointer was lost. Another solution would be to restore the mpGraphics pointer at the end of OutputDevice::ImplNewFont(): mpGraphics = pGraphics; I am not 100% sure what happens there and I did not have power do debug it in more deep. Anyway, the current code looks suspicious and a change might be needed. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 108914] vcl: Lost mpGraphics in O utputDevice::ImplNewFont()
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108914 User pmladek changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |67585) Possible fix. --- Additional comments from pmla...@openoffice.org Wed Feb 3 17:35:10 + 2010 --- Created an attachment (id=67585) Possible fix. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 108914] vcl: Lost mpGraphics in O utputDevice::ImplNewFont()
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108914 User pl changed the following: What|Old value |New value Assigned to|pl|hdu --- Additional comments from p...@openoffice.org Wed Feb 3 17:53:53 + 2010 --- I think this is a duplicate to issue 108138. @hdu: can you please have a look ? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 108914] vcl: Lost mpGraphics in O utputDevice::ImplNewFont()
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=108914 User thb changed the following: What|Old value |New value CC|''|'pl,thb' --- Additional comments from t...@openoffice.org Wed Feb 3 19:47:10 + 2010 --- @pl: hmm - not so sure about the duplicity. So this is what happens here: deep inside the ImplLayout ctor, a new FreetypeServerFont is created, which in turn constructs a temporary VirtualDevice vdev( 1 ) - and _that_ ends up in failing to grab a free SalGraphics (inside SalFrame::GetGraphics, called from OutputDevice::ImplGetGraphics()), and happily destroys the current one from underneath all the methods on the callstack - which most likely is the reason why OutputDevice::ImplNewFont() caches the graphics (historic code): pGraphics = mpGraphics (which actually may or may not be such a good idea). Anyway, calling ImplNewFont() bears the risk of killing mpGraphics, so there are other places in outdev3 pdfwriter_impl that might need fixing ... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
