[gsl-issues] [Issue 114706] vcl: ImplDevFontList::Add loop always completes on first iteration ?
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114706 User hdu changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from h...@openoffice.org Wed Oct 20 09:01:09 + 2010 --- Got into DEV300_m90 = closed - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 114706] vcl: ImplDevFontList::Add loop always completes on first iteration ?
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114706 User pl changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from p...@openoffice.org Mon Oct 11 11:21:07 + 2010 --- v - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 114706] vcl: ImplDevFontList::Add loop always completes on first iteration ?
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114706 User dtardon changed the following: What|Old value |New value CC|''|'dtardon' --- Additional comments from dtar...@openoffice.org Fri Sep 24 06:49:16 + 2010 --- dtardon-hdu: If I understand it correctly, the function is supposed to add a font and all it's aliases. In that case the comparison should be the other way around, i.e. aMapNames.Len() = nMapNameIndex, otherwise no alias would be ever added. The condition in the for loop is wrong too, because GetNextFontToken sets nMapNameIndex to STRING_NOTFOUND on the last token already, so the last alias would be always missed. Attached is a patch that does what I think is the right thing. dtardon-cmc: Thanks for digging into the autocorrect stuff. You were quicker than me, as usual :) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 114706] vcl: ImplDevFontList::Add loop always completes on first iteration ?
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114706 User dtardon changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |71827) like this --- Additional comments from dtar...@openoffice.org Fri Sep 24 06:50:05 + 2010 --- Created an attachment (id=71827) like this - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 114706] vcl: ImplDevFontList::Add loop always completes on first iteration ?
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114706 User hdu changed the following: What|Old value |New value Status|NEW |RESOLVED OS/Version|Linux |All Resolution| |FIXED Target milestone|--- |OOo 3.4 --- Additional comments from h...@openoffice.org Fri Sep 24 07:00:56 + 2010 --- Darn, that condition was inverted so the alternative names never got registered... since 2004! Fixed in CWS vcl115, thanks! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 114706] vcl: ImplDevFontList::Add loop always completes on first iteration ?
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=114706
Issue #|114706
Summary|vcl: ImplDevFontList::Add loop always completes on fir
|st iteration ?
Component|gsl
Version|DEV300m88
Platform|All
URL|
OS/Version|Linux
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|code
Assigned to|hdu
Reported by|cmc
--- Additional comments from c...@openoffice.org Thu Sep 23 14:02:00 +
2010 ---
cmc-hdu: in source/gdi/outdev3.cxx ImplDevFontList::Add we have...
String aMapNames = pNewData-maMapNames;
for( xub_StrLen nMapNameIndex = 0; nMapNameIndex != STRING_NOTFOUND; )
{
if( aMapNames.Len() = nMapNameIndex )
break;
some stuff
}
under what circumstances could some stuff be executed ?, I mean aMapNames is
always going to be = 0 right , and nMapNameIndex is always going to be 0 on
the first iteration through there, so that loop will always break out the first
time its entered. Or am I having a bad day and missing the obvious
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org
-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
