[gsl-issues] [Issue 116048] vcl: make X11 clipboard s hutdown more robust
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=116048 --- Additional comments from p...@openoffice.org Mon Dec 13 15:19:47 + 2010 --- *** Issue 116056 has been marked as a duplicate of this issue. *** - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 116048] vcl: make X11 clipboard s hutdown more robust
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=116048 User pl changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from p...@openoffice.org Mon Dec 13 14:46:15 + 2010 --- comitted in CWS vcl118 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 116048] vcl: make X11 clipboard s hutdown more robust
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=116048 User pl changed the following: What|Old value |New value Target milestone|--- |OOo 3.4 --- Additional comments from p...@openoffice.org Mon Dec 13 10:20:03 + 2010 --- Ok, then I'll commit this to vcl118 Thanks for the patch ! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 116048] vcl: make X11 clipboard s hutdown more robust
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=116048 --- Additional comments from s...@openoffice.org Mon Dec 13 08:06:38 + 2010 --- @pl: Yes, the namespace thing is unfortunate. And no, I have not integrated the patch myself (as it turned out not really necessary on my CWS, after I fixed my own mistake). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 116048] vcl: make X11 clipboard s hutdown more robust
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=116048 --- Additional comments from p...@openoffice.org Fri Dec 10 16:37:54 + 2010 --- looks good, although the main thrust seems to be introducing namespaces :-) Should I commit or do you have this already in a CWS ? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 116048] vcl: make X11 clipboard s hutdown more robust
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=116048 --- Additional comments from s...@openoffice.org Fri Dec 10 14:02:20 + 2010 --- Created an attachment (id=75313) proposed fix - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 116048] vcl: make X11 clipboard s hutdown more robust
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=116048 Issue #|116048 Summary|vcl: make X11 clipboard shutdown more robust Component|gsl Version|DEV300m95 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|pl Reported by|sb --- Additional comments from s...@openoffice.org Fri Dec 10 14:01:49 + 2010 --- While working on issue 116038 on a DEV300_m95 based CWS, I temporarily made a mistake so that, for example when executing smoketestoo_native, framework::Desktop::terminate (called from outside OOo) could be still running when desktop::Desktop::Main was past the DeregisterServices call. At least on unxsoli4 non-pro, this lead to various crashes related to the X11 clipboard shutdown code. The attached DEV300_m95.vcl.patch attempts to make the code more robust, so that those crashes would be avoided: - DisplayConnection::dispatchEvent (vcl/source/helper/xconnection.cxx) could be called with a void*pThis that is already destroyed, or is destroyed concurrently in another thread. This is prevented by replacing the m_pEvent/ErrorCallback in SalInstance with an rtl::Reference, so that the relevant object's lifetime cannot end prematurely. Unfortunately, adding rtl/ref.hxx to vcl/salinst.hxx caused plain "Reference" to become ambiguous in many places, fixing which accounts for the bulk of the patch's changes. - Multiple threads could concurrently call into SelectionManager::shutdown (vcl/unx/source/dtrans/X11_selection.cxx). This has been addressed with an additional m_bShutDown member flag. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
