[gsl-issues] [Issue 80754] toolkit - virtual size req uest code ...

2008-03-12 Thread jsk
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80754


User jsk changed the following:

What|Old value |New value

  Status|VERIFIED  |CLOSED





--- Additional comments from [EMAIL PROTECTED] Wed Mar 12 09:26:19 + 
2008 ---
Closed

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[gsl-issues] [Issue 80754] toolkit - virtual size req uest code ...

2007-12-19 Thread jsk
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80754


User jsk changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from [EMAIL PROTECTED] Wed Dec 19 12:09:45 + 
2007 ---
verified

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[gsl-issues] [Issue 80754] toolkit - virtual size req uest code ...

2007-12-10 Thread jsk
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80754


User jsk changed the following:

What|Old value |New value

 Assigned to|mmeeks|jsk

Target milestone|---   |OOo 2.4





--- Additional comments from [EMAIL PROTECTED] Mon Dec 10 14:41:21 + 
2007 ---
Target/Owner

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[gsl-issues] [Issue 80754] toolkit - virtual size req uest code ...

2007-12-10 Thread jsk
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80754


User jsk changed the following:

What|Old value |New value

  Status|NEW   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from [EMAIL PROTECTED] Mon Dec 10 14:42:43 + 
2007 ---
Fixed

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[gsl-issues] [Issue 80754] toolkit - virtual size req uest code ...

2007-08-29 Thread pl
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80754


User pl changed the following:

What|Old value |New value

  CC|''|'cd'





--- Additional comments from [EMAIL PROTECTED] Wed Aug 29 11:36:02 + 
2007 ---
The vcl changes seem to be OK (basically the GetOptimalSize() methods call the
various ImplCalcSize methods).

The toolkit changes seem to be about registering some properties, which I don't
know about, I'll set cd to CC and ask him to review the toolkit part.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[gsl-issues] [Issue 80754] toolkit - virtual size req uest code ...

2007-08-29 Thread mmeeks
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80754


User mmeeks changed the following:

What|Old value |New value

  CC|'cd'  |'cd,pl'





--- Additional comments from [EMAIL PROTECTED] Wed Aug 29 12:08:13 + 
2007 ---
Thanks for the review Philipp - Carsten  others have already reviewed the
properties work in toolkit/ which I guess leaves only the (rather
non-controversial) connection of the virtual methods to VCL.

Having said that - I would like to push down some of the work inside toolkit/ to
get the sizing 'right' down into the VCL GetOptimalSize method impl.s eg.

::com::sun::star::awt::Size VCLXEdit::getMinimumSize( sal_Int16 nCols, sal_Int16
) throw(::com::sun::star::uno::RuntimeException)
{
::vos::OGuard aGuard( GetMutex() );

Size aSz;
Edit* pEdit = (Edit*) GetWindow();
if ( pEdit )
{
if ( nCols )
aSz = pEdit-CalcSize( nCols );
else
aSz = pEdit-CalcMinimumSize();
}

or: vclxwindow.cxx's:

case WINDOW_TIMEBOX:
case WINDOW_LONGCURRENCYBOX:
aSz.Width() = GetWindow()-GetTextWidth( 
GetWindow()-GetText() )+2*2;
aSz.Height() = GetWindow()-GetTextHeight()+2*2;
break;

But basically some small changes.

Thanks :-)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[gsl-issues] [Issue 80754] toolkit - virtual size req uest code ...

2007-08-29 Thread pl
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80754





--- Additional comments from [EMAIL PROTECTED] Wed Aug 29 12:16:44 + 
2007 ---
Seems good to me, please do that.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[gsl-issues] [Issue 80754] toolkit - virtual size req uest code ...

2007-08-27 Thread pl
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80754


User pl changed the following:

What|Old value |New value

 Assigned to|pl|mmeeks





--- Additional comments from [EMAIL PROTECTED] Mon Aug 27 08:37:32 + 
2007 ---
If you want to add that virtual method, please proceed. Would you want to add it
to Window or Control ? I'll try to have a look at that CWS.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[gsl-issues] [Issue 80754] toolkit - virtual size req uest code ...

2007-08-16 Thread mmeeks
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80754
 Issue #|80754
 Summary|toolkit - virtual size request code ...
   Component|gsl
 Version|680m225
Platform|All
 URL|
  OS/Version|Linux
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|DEFECT
Priority|P3
Subcomponent|code
 Assigned to|pl
 Reported by|mmeeks





--- Additional comments from [EMAIL PROTECTED] Thu Aug 16 16:16:41 + 
2007 ---
Sooo ... :-)
The layout work is running up against some problems with the toolkit/
implementations, in particular for things like 'FixedLine' - it's not possible
to get a meaningful preferred size.

Also, the getPreferredSize / getMinimumSize (etc.) method impls in
toolkit/source/awt/vclxtoolkit.cxx are rather a nasty kludge :-)

What I would -love- is to add a virtual method to vcl:

enum WidgetSize { MIN, PREFERRED, MAX };
virtual Size getSizeHint( WidgetSize type );

Implement that in vcl (based on the toolkit impls) and the rip/simplify the
toolkit/ code here.

I'm happy to do all the work :-) all I want is approval in principle.
My existing CWS is 'awtfixes1' - any chance you can review / approve the changes
etc. ? :-)

I attach a motivational picture of it not working :-)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[gsl-issues] [Issue 80754] toolkit - virtual size req uest code ...

2007-08-16 Thread mmeeks
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80754





--- Additional comments from [EMAIL PROTECTED] Thu Aug 16 16:17:22 + 
2007 ---
Created an attachment (id=47574)
a photo ...


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]