[gsl-issues] [Issue 96089] vcl: ambiguous || seque nce
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96089 User cmc changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from c...@openoffice.org Fri Dec 12 11:49:41 + 2008 --- seen in DEV300_m37 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 96089] vcl: ambiguous || seque nce
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96089 User pl changed the following: What|Old value |New value Assigned to|pl|cmc --- Additional comments from [EMAIL PROTECTED] Mon Nov 17 12:31:57 + 2008 --- please verify in CWS vcl96 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 96089] vcl: ambiguous || seque nce
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96089 User cmc changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from [EMAIL PROTECTED] Mon Nov 17 14:01:01 + 2008 --- verified - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 96089] vcl: ambiguous || seque nce
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96089 User cmc changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |57869) dodgy code --- Additional comments from [EMAIL PROTECTED] Tue Nov 11 11:32:27 + 2008 --- Created an attachment (id=57869) dodgy code - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 96089] vcl: ambiguous || seque nce
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96089 Issue #|96089 Summary|vcl: ambiguous || sequence Component|gsl Version|DEV300m35 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|pl Reported by|cmc --- Additional comments from [EMAIL PROTECTED] Tue Nov 11 11:32:02 + 2008 --- X Y || Z binds operator precedence-wise as (X Y) || Z not X (Y || Z) so I am a little suspicious about... vcl/source/window/menu.cxx if ( ImplIsVisible( i ) ( pData-eType == MENUITEM_IMAGE ) || ( pData-eType == MENUITEM_STRINGIMAGE )) which means if ( (ImplIsVisible( i ) ( pData-eType == MENUITEM_IMAGE )) || ( pData-eType == MENUITEM_STRINGIMAGE )) is that what we really mean, or do we mean if ( ImplIsVisible( i ) (( pData-eType == MENUITEM_IMAGE ) || ( pData-eType == MENUITEM_STRINGIMAGE ))) seeing as both MENUITEMs refer to images of one type of another ? similarly in unx/gtk/gdi/salnativewidgets-gtk.cxx there is a confusing sequence of || where one of them (the menu) section is slightly different to the other ones, which makes me suspicious that it might be intended to be the same as the others. If they're currently correct, then lets just stick some brackets around it to confirm it, but if not then the following patch might be what was intended. Just a guess though - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 96089] vcl: ambiguous || seque nce
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96089 User pl changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED Target milestone|--- |OOo 3.1 --- Additional comments from [EMAIL PROTECTED] Tue Nov 11 17:17:05 + 2008 --- committed in CWS vcl96 thanks for noticing. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 96089] vcl: ambiguous || seque nce
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=96089 User cmc changed the following: What|Old value |New value OtherIssuesDependingOnTh| |96084 is| | - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
