[l10n-issues] [Issue 96059] transex3: dodgy use of && and ||

2009-03-20 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96059


User cmc changed the following:

What|Old value |New value

  Status|VERIFIED  |CLOSED





--- Additional comments from c...@openoffice.org Fri Mar 20 13:20:42 + 
2009 ---
closing, is in m44

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@l10n.openoffice.org
For additional commands, e-mail: issues-h...@l10n.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[l10n-issues] [Issue 96059] transex3: dodgy use of && and ||

2009-03-06 Thread dtardon
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96059


User dtardon changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from dtar...@openoffice.org Sat Mar  7 07:31:11 
+ 2009 ---
Verified in CWS cmcfixes55.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@l10n.openoffice.org
For additional commands, e-mail: issues-h...@l10n.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[l10n-issues] [Issue 96059] transex3: dodgy use of && and ||

2009-02-27 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96059


User cmc changed the following:

What|Old value |New value

  Status|NEW   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from c...@openoffice.org Fri Feb 27 12:06:00 + 
2009 ---
done in cmcfixes55

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@l10n.openoffice.org
For additional commands, e-mail: issues-h...@l10n.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[l10n-issues] [Issue 96059] transex3: dodgy use of && and ||

2009-02-27 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96059


User cmc changed the following:

What|Old value |New value

 Assigned to|ihi   |cmc

Target milestone|---   |OOo 3.2





--- Additional comments from c...@openoffice.org Fri Feb 27 12:04:10 + 
2009 ---
I'll take this, its low-hanging and blocks warnings-free on new compilers

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@l10n.openoffice.org
For additional commands, e-mail: issues-h...@l10n.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[l10n-issues] [Issue 96059] transex3: dodgy use of && and ||

2008-11-11 Thread ihi
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96059





--- Additional comments from [EMAIL PROTECTED] Tue Nov 11 11:37:41 + 
2008 ---
hahahaha nice one!

This is used in the readme ... I guess  is never ever used in the translation
as the layout is done in the xml code

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[l10n-issues] [Issue 96059] transex3: dodgy use of && and ||

2008-11-11 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96059


User cmc changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|  |96084
  is|  |





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[l10n-issues] [Issue 96059] transex3: dodgy use of && and ||

2008-11-10 Thread pjanik
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96059


User pjanik changed the following:

What|Old value |New value

 Assigned to|pjanik|ihi





--- Additional comments from [EMAIL PROTECTED] Tue Nov 11 07:05:51 + 
2008 ---
Ivo's playground :-)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[l10n-issues] [Issue 96059] transex3: dodgy use of && and ||

2008-11-10 Thread dtardon
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96059


User dtardon changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |57863)
fix of the fix :)






--- Additional comments from [EMAIL PROTECTED] Tue Nov 11 06:50:15 + 
2008 ---
Created an attachment (id=57863)
fix of the fix :)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[l10n-issues] [Issue 96059] transex3: dodgy use of && and ||

2008-11-10 Thread dtardon
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96059





--- Additional comments from [EMAIL PROTECTED] Tue Nov 11 06:48:04 + 
2008 ---
There is another issue that I've found highly suspicious: the

rString.GetChar( +2 ) == '>' 

thing. Shouldn't it be

rString.GetChar( i+2 ) == '>'

instead? I've 'reused' caolan's patch to fix this issue too.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[l10n-issues] [Issue 96059] transex3: dodgy use of && and ||

2008-11-10 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96059


User cmc changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |57843)
what we probably wa
|  |nt to do






--- Additional comments from [EMAIL PROTECTED] Mon Nov 10 17:04:30 + 
2008 ---
Created an attachment (id=57843)
what we probably want to do


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[l10n-issues] [Issue 96059] transex3: dodgy use of && and ||

2008-11-10 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96059
 Issue #|96059
 Summary|transex3: dodgy use of && and ||
   Component|l10n
 Version|DEV300m35
Platform|All
 URL|
  OS/Version|Linux
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|PATCH
Priority|P3
Subcomponent|code
 Assigned to|pjanik
 Reported by|cmc





--- Additional comments from [EMAIL PROTECTED] Mon Nov 10 17:03:21 + 
2008 ---
in transex3/source/export2.cxx we have...

if( i+2 < rString.Len() &&
   rString.GetChar( i+1 ) == 'b' || rString.GetChar( i+1 ) == 'B' &&
   rString.GetChar( +2 ) == '>' )

i.e. 

if (a && b || c && d)

rules of precedence means this is equivalent to 

if ( (a && b) || (c && d) )

i.e. 

if( (i+2 < rString.Len() &&
   rString.GetChar( i+1 ) == 'b') || (rString.GetChar( i+1 ) == 'B' &&
   rString.GetChar( +2 ) == '>') )

which really doesn't look like what this code probably wants to do.

Attached is a patch to do the more likely 

if( i+2 < rString.Len() &&
   (rString.GetChar( i+1 ) == 'b' || (rString.GetChar( i+1 ) == 'B') &&
   rString.GetChar( +2 ) == '>') )

including the same type of thing later on

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]