[lingucomponent-issues] [Issue 113293] lingucomponent: merge enc oding detection code and make it accept more p ossibilities

2010-09-13 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=113293


User cmc changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from c...@openoffice.org Mon Sep 13 07:53:52 + 
2010 ---
looks reasonable

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@lingucomponent.openoffice.org
For additional commands, e-mail: issues-h...@lingucomponent.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[lingucomponent-issues] [Issue 113293] lingucomponent: merge enc oding detection code and make it accept more p ossibilities

2010-09-13 Thread tl
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=113293


User tl changed the following:

What|Old value |New value

 Assigned to|tl|cmc





--- Additional comments from t...@openoffice.org Mon Sep 13 07:30:26 + 
2010 ---
tl->cmc: Can you verify this one? Thanks in advance!


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@lingucomponent.openoffice.org
For additional commands, e-mail: issues-h...@lingucomponent.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[lingucomponent-issues] [Issue 113293] lingucomponent: merge enc oding detection code and make it accept more p ossibilities

2010-07-21 Thread tl
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=113293


User tl changed the following:

What|Old value |New value

  Status|STARTED   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from t...@openoffice.org Wed Jul 21 14:31:19 + 
2010 ---
.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@lingucomponent.openoffice.org
For additional commands, e-mail: issues-h...@lingucomponent.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[lingucomponent-issues] [Issue 113293] lingucomponent: merge enc oding detection code and make it accept more p ossibilities

2010-07-21 Thread tl
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=113293





--- Additional comments from t...@openoffice.org Wed Jul 21 14:31:05 + 
2010 ---
Fixed in CWS tl82.
(also did some more text formatting)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@lingucomponent.openoffice.org
For additional commands, e-mail: issues-h...@lingucomponent.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[lingucomponent-issues] [Issue 113293] lingucomponent: merge enc oding detection code and make it accept more p ossibilities

2010-07-21 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=113293





--- Additional comments from c...@openoffice.org Wed Jul 21 10:02:15 + 
2010 ---
re: "is there something like a default encoding set that gets used if
determining the actual encoding fails? If so I like to propose to get rid of 
that"
Sure, we could do that, i.e. remove the eRet = RTL_TEXTENCODING_ISO_8859_1 in
the suggested getTextEncodingFromCharset and then add diagnostics and early
returns everywhere (three places I think) where its used if its ret is
RTL_TEXTENCODING_DONTKNOW

re: "Do you think this one qualifies a as show-stopper?"
Nah, I don't think so.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@lingucomponent.openoffice.org
For additional commands, e-mail: issues-h...@lingucomponent.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[lingucomponent-issues] [Issue 113293] lingucomponent: merge enc oding detection code and make it accept more p ossibilities

2010-07-21 Thread tl
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=113293


User tl changed the following:

What|Old value |New value

  Status|NEW   |STARTED

Target milestone|---   |OOo 3.4





--- Additional comments from t...@openoffice.org Wed Jul 21 09:39:16 + 
2010 ---
As discussed with SBA: setting target to 3.4.
(To address the Slovenian hyphenation problem for OOo 3.3: This should be fixed
as part of the regular dictionary updates before the release, by setting the
correct currently expected string.)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@lingucomponent.openoffice.org
For additional commands, e-mail: issues-h...@lingucomponent.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[lingucomponent-issues] [Issue 113293] lingucomponent: merge enc oding detection code and make it accept more p ossibilities

2010-07-21 Thread tl
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=113293





--- Additional comments from t...@openoffice.org Wed Jul 21 08:45:55 + 
2010 ---
tl->CMC: Btw, is there something like a default encoding set that gets used if
determining the actual encoding fails? If so I like to propose to get rid of
that default encoding and to read any data at all when the encoding could not
properly be identified. That way at least it will become obvious right away that
something went wrong.

Do you think this one qualifies a as show-stopper? If so, I already have a CWS
at hand. ^_-

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@lingucomponent.openoffice.org
For additional commands, e-mail: issues-h...@lingucomponent.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[lingucomponent-issues] [Issue 113293] lingucomponent: merge enc oding detection code and make it accept more p ossibilities

2010-07-20 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=113293


User cmc changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |70718)
like so






--- Additional comments from c...@openoffice.org Tue Jul 20 15:06:54 + 
2010 ---
Created an attachment (id=70718)
like so


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@lingucomponent.openoffice.org
For additional commands, e-mail: issues-h...@lingucomponent.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[lingucomponent-issues] [Issue 113293] lingucomponent: merge enc oding detection code and make it accept more p ossibilities

2010-07-20 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=113293
 Issue #|113293
 Summary|lingucomponent: merge encoding detection code and make
| it accept more possibilities
   Component|lingucomponent
 Version|DEV300m84
Platform|Unknown
 URL|
  OS/Version|All
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|PATCH
Priority|P3
Subcomponent|other
 Assigned to|tl
 Reported by|cmc





--- Additional comments from c...@openoffice.org Tue Jul 20 15:05:22 + 
2010 ---
As we were discussing recently with the Slovenian hyphenation that had a
ISO-8859-X encoding instead of the required ISO8859-X encoding we should share
the encoding helper code between all three linguistic components and accept
ISO-8859-X as well as ISO8859-X. 

Helpfully we already have the code for this. So easiest thing to do is move
everything to one place, and try rtl_getTextEncodingFromMimeCharset and
rtl_getTextEncodingFromUnixCharset, that'll cause ISO-8859-X as well as
ISO8859-X to work.

The patch also cleans up the indentation of nthesimp.cxx, which I'd normally not
stick in a patch, but the braces were lining up very misleadingly in places.

If you want I can take care of this, just send it back to me in that case.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@lingucomponent.openoffice.org
For additional commands, e-mail: issues-h...@lingucomponent.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org