[porting-issues] [Issue 108618] mingw port: Getting PATH in unicode

2010-02-27 Thread tono
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=108618


User tono changed the following:

What|Old value |New value

  Status|VERIFIED  |CLOSED





--- Additional comments from t...@openoffice.org Sun Feb 28 03:01:41 + 
2010 ---
Closing as the fix has been integrated.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 108618] mingw port: Getting PATH in unicode

2010-02-01 Thread vg
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=108618


User vg changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from v...@openoffice.org Mon Feb  1 08:36:02 + 
2010 ---
verified in the CWS mingwport27

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 108618] mingw port: Getting PATH in unicode

2010-01-28 Thread tono
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=108618


User tono changed the following:

What|Old value |New value

  Status|STARTED   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from t...@openoffice.org Thu Jan 28 13:05:42 + 
2010 ---
Fixed in cws mingwport27.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 108618] mingw port: Getting PATH in unicode

2010-01-28 Thread tono
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=108618


User tono changed the following:

What|Old value |New value

 Assigned to|tono  |vg





--- Additional comments from t...@openoffice.org Thu Jan 28 14:11:03 + 
2010 ---
@vg: Please verify.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 108618] mingw port: Getting PATH in unicode

2010-01-25 Thread sb
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=108618


User sb changed the following:

What|Old value |New value

  CC|'cmc,vg'  |'cmc,sb,vg'





--- Additional comments from s...@openoffice.org Mon Jan 25 08:12:15 + 
2010 ---
@tono:  rtl::OUString::createFromAscii(getenv(PATH)) is wrong, as PATH may
contain non-ASCII characters.  You would need something like
rtl_convertStringToUString(path.pData, getenv(PATH), strlen(getenv(PATH)),
osl_getThreadTextEncoding(), RTL_TEXTTOUNICODE_FLAGS_UNDEFINED_ERROR |
RTL_TEXTTOUNICODE_FLAGS_MBUNDEFINED_ERROR |
RTL_TEXTTOUNICODE_FLAGS_INVALID_ERROR), handling a false return code
appropriately, to do the conversion correctly.  And this would still produce
wrong results if the (UTF-16) Windows PATH environment variable happens to
contain encodings of Unicode characters that cannot be represented in the
current Windows code page (osl_getThreadTextEncoding).

In what is apparently Windows-only code, I would always use Windows-specific
_wgetenv plus any necessary wchar_t/sal_Unicode casting, as it avoids problems
due to character encoding conversion failures.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 108618] mingw port: Getting PATH in unicode

2010-01-25 Thread tono
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=108618





--- Additional comments from t...@openoffice.org Mon Jan 25 13:15:55 + 
2010 ---
@sb: Thank you. I thought PATH is always encoded with system default encoding 
and available in UCS and MBCS.
I will switch to reinterpret_castconst sal_Unicode*(_wgetenv(LPATH)).

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 108618] mingw port: Getting PATH in unicode

2010-01-24 Thread tono
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=108618


User tono changed the following:

What|Old value |New value

  Ever confirmed|  |1

  Status|UNCONFIRMED   |STARTED





--- Additional comments from t...@openoffice.org Sun Jan 24 10:11:26 + 
2010 ---
Started in cws mingwport27.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 108618] mingw port: Getting PATH in unicode

2010-01-24 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=108618





--- Additional comments from c...@openoffice.org Sun Jan 24 10:42:23 + 
2010 ---
Hmm, sorry about that. Is there a list of common mingw porting gotchas to
refer to in the wiki or anything that would act as a handy reference ?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 108618] mingw port: Getting PATH in unicode

2010-01-24 Thread tono
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=108618





--- Additional comments from t...@openoffice.org Sun Jan 24 12:20:36 + 
2010 ---
@cmc: Thank you. There exist no such a handbook right now. I think I should 
write an article of mingw port pitfall.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 108618] mingw port: Getting PATH in unicode

2010-01-23 Thread tono
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=108618


User tono changed the following:

What|Old value |New value

 Summary|Getting PATH in unicode   |mingw port: Getting PATH i
|  |n unicode





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org