[porting-issues] [Issue 109142] Let assertions abort

2011-02-07 Thread fs
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=109142





--- Additional comments from f...@openoffice.org Mon Feb  7 12:50:29 + 
2011 ---
*** Issue 116845 has been marked as a duplicate of this issue. ***

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 109142] Let assertions abort

2010-04-30 Thread sb
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=109142





--- Additional comments from s...@openoffice.org Fri Apr 30 09:18:41 + 
2010 ---
@mt: see OSL_TRACE to flag "unusual program states"

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 109142] Let assertions abort

2010-04-30 Thread mt
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=109142


User mt changed the following:

What|Old value |New value

  CC|'400guy,dtardon,fs,mst'   |'400guy,dtardon,fs,mst,mt'





--- Additional comments from m...@openoffice.org Fri Apr 30 09:11:36 + 
2010 ---
cc me 

And still -1 - IMHO there are situations where assertion should about, but also
some where they shouldn't, so the developer should choose the appropriate macro
for this, instead of blindly letting all assertions about.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 109142] Let assertions abort

2010-02-16 Thread dtardon
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=109142


User dtardon changed the following:

What|Old value |New value

  CC|'400guy,fs,mst'   |'400guy,dtardon,fs,mst'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 109142] Let assertions abort

2010-02-12 Thread fs
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=109142





--- Additional comments from f...@openoffice.org Fri Feb 12 09:15:38 + 
2010 ---
http://www.openoffice.org/servlets/ReadMsg?list=dev&msgNo=26561

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 109142] Let assertions abort

2010-02-11 Thread sb
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=109142





--- Additional comments from s...@openoffice.org Thu Feb 11 15:42:44 + 
2010 ---
@fs:  yes, please start over on a mailing list, and I'll answer you there, then

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 109142] Let assertions abort

2010-02-11 Thread fs
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=109142


User fs changed the following:

What|Old value |New value

  CC|'400guy,mst'  |'400guy,fs,mst'





--- Additional comments from f...@openoffice.org Thu Feb 11 13:24:48 + 
2010 ---
-1

This would just cause people to not add assertions to their code anymore. We
need to solve this on a social level (well, backed up by management, and this is
what's missing at the moment), not on a technical level.

Also, not every of today's assertions justifies an abort when failing.
Historically, DBG_ASSERT/OSL_ENSURE simply have not been used in the same way
::std::assert is intended to be used, so treating both the same way is
inappropriate.

Now that I've said this, let's start the discussion/war. But in a mailing list,
please, not in this issue here.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 109142] Let assertions abort

2010-02-11 Thread 400guy
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=109142


User 400guy changed the following:

What|Old value |New value

  CC|'mst' |'400guy,mst'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 109142] Let assertions abort

2010-02-11 Thread mst
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=109142


User mst changed the following:

What|Old value |New value

  CC|''|'mst'





--- Additional comments from m...@openoffice.org Thu Feb 11 09:59:42 + 
2010 ---
+1

that will finally give me a reason to track a lot of these down...
though i would not want this change integrated until after 3.3 branches off :)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 109142] Let assertions abort

2010-02-11 Thread sb
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=109142


User sb changed the following:

What|Old value |New value

  Status|NEW   |STARTED

Target milestone|---   |OOo 3.x





--- Additional comments from s...@openoffice.org Thu Feb 11 08:39:43 + 
2010 ---
.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[porting-issues] [Issue 109142] Let assertions abort

2010-02-11 Thread sb
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=109142
 Issue #|109142
 Summary|Let assertions abort
   Component|porting
 Version|DEV300m71
Platform|All
 URL|
  OS/Version|All
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|ENHANCEMENT
Priority|P3
Subcomponent|code
 Assigned to|sb
 Reported by|sb





--- Additional comments from s...@openoffice.org Thu Feb 11 08:39:11 + 
2010 ---
Assertions (OSL_ASSERT et al from osl/debug.h, and DBG_ASSERT et al from
tools/debug.hxx), if enabled (i.e., doing an --enable-dbgutil build, or building
parts of the code with debug=x) should abort (following practices established by
C assert.h etc.).  Without such a strict measure, the many assertions occurring
in a run of OOo (e.g., even executing the smoke test produces lots of them)
would probably never go a away, and the assertion tool would remain practically
useless (as developers hardly notice assertions newly introduced by their code
changes, in the sea of existing ones).

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org